From: Stephen Smalley <sds@tycho.nsa.gov>
To: Richard Haines <richard_c_haines@btinternet.com>,
David Howells <dhowells@redhat.com>,
paul@paul-moore.com
Cc: keyrings@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: SELinux: How to split permissions for keys?
Date: Mon, 3 Feb 2020 09:48:12 -0500 [thread overview]
Message-ID: <bd03ab75-7df5-7de8-4d31-9f3e02bcb10e@tycho.nsa.gov> (raw)
In-Reply-To: <de8d82ba7db7abdf2a72d88c8cbc590e289f5f6f.camel@btinternet.com>
On 2/3/20 9:03 AM, Richard Haines wrote:
> On Mon, 2020-02-03 at 08:13 -0500, Stephen Smalley wrote:
>> Was that kernel patch ever posted to selinux list and/or the selinux
>> kernel maintainers? I don't recall seeing it. If not, please send
>> it
>> to the selinux list for review; at least one selinux maintainer
>> should
>> ack it before it gets accepted into any other tree.
>>
>>
>
> Not formally. I did post it in a discussion about keys in [2]. Since
> then it's been modified to support the split permissions.
Yes, that doesn't count since a) it wasn't the final version of the
patch which changed significantly afterward and b) even it had been the
final version, there was no acked-by or reviewed-by from a selinux
maintainer, just some suggestions. A non-trivial patch that modifies
security/selinux needs to be at least acked by a selinux maintainer and
often should go through the upstream selinux maintainer (Paul).
> I've extracted the patch from [1] and will post that to list for
> comments.
Thanks.
> [2]
> https://lore.kernel.org/selinux/35455b30b5185780628e92c98ec8191c70f39bde.camel@btinternet.com/
prev parent reply other threads:[~2020-02-03 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 10:28 SELinux issue with 'keys-acl' patch in kernel.org's 'linux-next' tree Richard Haines
2020-01-23 15:12 ` SELinux: How to split permissions for keys? David Howells
2020-01-23 15:46 ` Stephen Smalley
2020-01-23 20:35 ` Stephen Smalley
2020-02-02 19:30 ` Richard Haines
2020-02-03 13:13 ` Stephen Smalley
2020-02-03 14:03 ` Richard Haines
2020-02-03 14:48 ` Stephen Smalley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd03ab75-7df5-7de8-4d31-9f3e02bcb10e@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=richard_c_haines@btinternet.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).