From: Mimi Zohar <zohar@linux.ibm.com>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>,
mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
dmitry.kasatkin@gmail.com, paul@paul-moore.com,
jmorris@namei.org, serge@hallyn.com,
stephen.smalley.work@gmail.com, eparis@parisplace.org,
casey@schaufler-ca.com
Cc: ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
linux-kernel@vger.kernel.org, keescook@chromium.org,
nicolas.bouchinet@clip-os.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH v5 1/6] reiserfs: Switch to security_inode_init_security()
Date: Wed, 23 Nov 2022 08:12:27 -0500 [thread overview]
Message-ID: <c5cea3cad1eaf79c29e91e9ecf8e8b7dcee2ce2c.camel@linux.ibm.com> (raw)
In-Reply-To: <20221123095202.599252-2-roberto.sassu@huaweicloud.com>
On Wed, 2022-11-23 at 10:51 +0100, Roberto Sassu wrote:
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> In preparation for removing security_old_inode_init_security(), switch to
> security_inode_init_security().
>
> Define the initxattrs callback reiserfs_initxattrs(), to populate the
> name/value/len triple in the reiserfs_security_handle() with the first
> xattr provided by LSMs. Multiple xattrs are currently not supported, as the
> reiserfs_security_handle structure is exported to user space.
The security_old_inode_init_security() hook doesn't support EVM.
Missing from this patch description is whether the move to the
security_inode_init_security() hook changes security.evm. FYI, I'm not
suggesting it should. Please update the patch description accordingly.
Mimi
>
> In reiserfs_initxattrs(), make a copy of the first xattr value, as
> security_inode_init_security() frees it.
>
> After the call to security_inode_init_security(), remove the check for
> returning -EOPNOTSUPP, as security_inode_init_security() changes it to
> zero.
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> ---
> fs/reiserfs/xattr_security.c | 23 ++++++++++++++++++-----
> 1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/fs/reiserfs/xattr_security.c b/fs/reiserfs/xattr_security.c
> index 857a65b05726..0ba96757681d 100644
> --- a/fs/reiserfs/xattr_security.c
> +++ b/fs/reiserfs/xattr_security.c
> @@ -39,6 +39,22 @@ static bool security_list(struct dentry *dentry)
> return !IS_PRIVATE(d_inode(dentry));
> }
>
> +static int
> +reiserfs_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> + void *fs_info)
> +{
> + struct reiserfs_security_handle *sec = fs_info;
> +
> + sec->value = kmemdup(xattr_array->value, xattr_array->value_len,
> + GFP_KERNEL);
> + if (!sec->value)
> + return -ENOMEM;
> +
> + sec->name = xattr_array->name;
> + sec->length = xattr_array->value_len;
> + return 0;
> +}
> +
> /* Initializes the security context for a new inode and returns the number
> * of blocks needed for the transaction. If successful, reiserfs_security
> * must be released using reiserfs_security_free when the caller is done. */
> @@ -56,12 +72,9 @@ int reiserfs_security_init(struct inode *dir, struct inode *inode,
> if (IS_PRIVATE(dir))
> return 0;
>
> - error = security_old_inode_init_security(inode, dir, qstr, &sec->name,
> - &sec->value, &sec->length);
> + error = security_inode_init_security(inode, dir, qstr,
> + &reiserfs_initxattrs, sec);
> if (error) {
> - if (error == -EOPNOTSUPP)
> - error = 0;
> -
> sec->name = NULL;
> sec->value = NULL;
> sec->length = 0;
next prev parent reply other threads:[~2022-11-23 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 9:51 [PATCH v5 0/6] evm: Prepare for moving to the LSM infrastructure Roberto Sassu
2022-11-23 9:51 ` [PATCH v5 1/6] reiserfs: Switch to security_inode_init_security() Roberto Sassu
2022-11-23 13:12 ` Mimi Zohar [this message]
2022-11-23 9:51 ` [PATCH v5 2/6] ocfs2: " Roberto Sassu
2022-11-23 17:46 ` Mimi Zohar
2022-11-24 8:11 ` Roberto Sassu
2022-11-29 13:14 ` Mimi Zohar
2022-12-13 8:05 ` Roberto Sassu
2022-11-23 9:51 ` [PATCH v5 3/6] security: Remove security_old_inode_init_security() Roberto Sassu
2022-11-23 9:52 ` [PATCH v5 4/6] security: Allow all LSMs to provide xattrs for inode_init_security hook Roberto Sassu
2022-11-23 9:52 ` [PATCH v5 5/6] evm: Align evm_inode_init_security() definition with LSM infrastructure Roberto Sassu
2022-11-23 9:52 ` [PATCH v5 6/6] evm: Support multiple LSMs providing an xattr Roberto Sassu
2022-11-23 12:28 ` [PATCH v5 0/6] evm: Prepare for moving to the LSM infrastructure Mimi Zohar
2022-11-23 12:44 ` Roberto Sassu
2022-11-23 13:06 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5cea3cad1eaf79c29e91e9ecf8e8b7dcee2ce2c.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=casey@schaufler-ca.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=eparis@parisplace.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=keescook@chromium.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=nicolas.bouchinet@clip-os.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=paul@paul-moore.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).