From: Stephen Smalley <sds@tycho.nsa.gov>
To: "Christian Göttsche" <cgzones@googlemail.com>, selinux@vger.kernel.org
Subject: Re: [PATCH] libselinux: drop error return from is_selinux_enabled documentation
Date: Fri, 14 Feb 2020 14:42:58 -0500 [thread overview]
Message-ID: <c62a2099-fa22-2ff8-bf14-0350e786864d@tycho.nsa.gov> (raw)
In-Reply-To: <20200214184751.8211-1-cgzones@googlemail.com>
On 2/14/20 1:47 PM, Christian Göttsche wrote:
> Since commit e3cab998b48ab293a9962faf9779d70ca339c65d ("libselinux
> mountpoint changing patch.") for version 20120216 is_selinux_enabled()
> does never return -1; drop mentions in the man-page and header file.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> libselinux/include/selinux/selinux.h | 2 +-
> libselinux/man/man3/is_selinux_enabled.3 | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libselinux/include/selinux/selinux.h b/libselinux/include/selinux/selinux.h
> index 7922d96b..883d8b85 100644
> --- a/libselinux/include/selinux/selinux.h
> +++ b/libselinux/include/selinux/selinux.h
> @@ -8,7 +8,7 @@
> extern "C" {
> #endif
>
> -/* Return 1 if we are running on a SELinux kernel, or 0 if not or -1 if we get an error. */
> +/* Return 1 if we are running on a SELinux kernel, or 0 otherwise. */
> extern int is_selinux_enabled(void);
> /* Return 1 if we are running on a SELinux MLS kernel, or 0 otherwise. */
> extern int is_selinux_mls_enabled(void);
> diff --git a/libselinux/man/man3/is_selinux_enabled.3 b/libselinux/man/man3/is_selinux_enabled.3
> index df62c225..a887b48c 100644
> --- a/libselinux/man/man3/is_selinux_enabled.3
> +++ b/libselinux/man/man3/is_selinux_enabled.3
> @@ -15,7 +15,6 @@ is_selinux_mls_enabled \- check whether SELinux is enabled for (Multi Level Secu
> .SH "DESCRIPTION"
> .BR is_selinux_enabled ()
> returns 1 if SELinux is running or 0 if it is not.
> -On error, \-1 is returned.
>
> .BR is_selinux_mls_enabled ()
> returns 1 if SELinux is capable of running in MLS mode or 0 if it is not. To
>
next prev parent reply other threads:[~2020-02-14 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 14:37 [PATCH] libselinux: drop error return from is_selinux_enabled.3 Christian Göttsche
2020-02-07 15:39 ` Petr Lautrbach
2020-02-07 17:51 ` Stephen Smalley
2020-02-11 19:12 ` Christian Göttsche
2020-02-11 19:52 ` Stephen Smalley
2020-02-14 18:47 ` [PATCH] libselinux: drop error return from is_selinux_enabled documentation Christian Göttsche
2020-02-14 19:42 ` Stephen Smalley [this message]
2020-02-18 15:41 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62a2099-fa22-2ff8-bf14-0350e786864d@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).