selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Casey Schaufler <casey@schaufler-ca.com>,
	Aaron Goidel <acgoide@tycho.nsa.gov>,
	paul@paul-moore.com
Cc: selinux@vger.kernel.org, linux-security-module@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, dhowells@redhat.com, jack@suse.cz,
	amir73il@gmail.com, jmorris@namei.org, sds@tycho.nsa.gov,
	linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [RFC PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications
Date: Wed, 10 Jul 2019 09:49:40 -0700	[thread overview]
Message-ID: <cb754dda-fbce-8169-4cd7-eef66e8d809e@infradead.org> (raw)
In-Reply-To: <4fd98c88-61a6-a155-5028-db22a778d3c1@schaufler-ca.com>

On 7/10/19 9:38 AM, Casey Schaufler wrote:
> On 7/10/2019 6:34 AM, Aaron Goidel wrote:

>> @@ -3261,6 +3262,26 @@ static int selinux_inode_removexattr(struct dentry *dentry, const char *name)
>>  	return -EACCES;
>>  }
>>  
>> +static int selinux_inode_notify(struct inode *inode, u64 mask)
>> +{
>> +	u32 perm = FILE__WATCH; // basic permission, can a watch be set?
> 
> We don't use // comments in the Linux kernel.
> 

I thought that we had recently moved into the 21st century on that issue,
but I don't see it mentioned in coding-style.rst.  Maybe we need a Doc update.

checkpatch allows C99 comments by default.
Joe, do you recall about this?

thanks.
-- 
~Randy

  reply	other threads:[~2019-07-10 16:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 13:34 [RFC PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications Aaron Goidel
2019-07-10 14:55 ` Amir Goldstein
2019-07-10 17:25   ` [Non-DoD Source] " Aaron Goidel
2019-07-10 16:38 ` Casey Schaufler
2019-07-10 16:49   ` Randy Dunlap [this message]
2019-07-10 16:55     ` Casey Schaufler
2019-07-10 17:18     ` Joe Perches
2019-07-10 17:22       ` Joe Perches
2019-07-10 17:53         ` Randy Dunlap
2019-07-10 18:39   ` Stephen Smalley
2019-07-10 20:09     ` Casey Schaufler
2019-07-12  3:29   ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb754dda-fbce-8169-4cd7-eef66e8d809e@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=acgoide@tycho.nsa.gov \
    --cc=amir73il@gmail.com \
    --cc=casey@schaufler-ca.com \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.cz \
    --cc=jmorris@namei.org \
    --cc=joe@perches.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).