From: Stephen Smalley <sds@tycho.nsa.gov>
To: Petr Lautrbach <plautrba@redhat.com>, selinux@vger.kernel.org
Subject: Re: [PATCH] restorecond: Install DBUS service file with 644 permissions
Date: Wed, 23 Jan 2019 09:19:37 -0500 [thread overview]
Message-ID: <cf455f73-f954-12c4-d1ee-19ce4e6a5499@tycho.nsa.gov> (raw)
In-Reply-To: <20190122114724.1766-1-plautrba@redhat.com>
On 1/22/19 6:47 AM, Petr Lautrbach wrote:
> The original 600 permissions make the service file unreadable for dbus daemon.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1626462
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> restorecond/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/restorecond/Makefile b/restorecond/Makefile
> index 8a0ada1f..6155ca4a 100644
> --- a/restorecond/Makefile
> +++ b/restorecond/Makefile
> @@ -50,7 +50,7 @@ install: all
> -mkdir -p $(DESTDIR)$(AUTOSTARTDIR)
> install -m 644 restorecond.desktop $(DESTDIR)$(AUTOSTARTDIR)/restorecond.desktop
> -mkdir -p $(DESTDIR)$(DBUSSERVICEDIR)
> - install -m 600 org.selinux.Restorecond.service $(DESTDIR)$(DBUSSERVICEDIR)/org.selinux.Restorecond.service
> + install -m 644 org.selinux.Restorecond.service $(DESTDIR)$(DBUSSERVICEDIR)/org.selinux.Restorecond.service
> -mkdir -p $(DESTDIR)$(SYSTEMDDIR)/system
> install -m 644 restorecond.service $(DESTDIR)$(SYSTEMDDIR)/system/
> relabel: install
>
next prev parent reply other threads:[~2019-01-23 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 11:47 [PATCH] restorecond: Install DBUS service file with 644 permissions Petr Lautrbach
2019-01-23 14:19 ` Stephen Smalley [this message]
2019-01-25 14:05 ` Petr Lautrbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf455f73-f954-12c4-d1ee-19ce4e6a5499@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).