From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: bauen1 <j2468h@googlemail.com>, selinux@vger.kernel.org
Subject: Re: [RFC PATCH v2] fixfiles: correctly restore context of mountpoints
Date: Mon, 17 Aug 2020 11:57:55 -0400 [thread overview]
Message-ID: <d8630b0c-3a43-8295-9903-f21746c37539@gmail.com> (raw)
In-Reply-To: <c123b432-07e6-c26a-6d08-2b88863c2432@gmail.com>
On 8/7/20 11:05 AM, Stephen Smalley wrote:
> On 8/6/20 10:48 AM, bauen1 wrote:
>
>> By bind mounting every filesystem we want to relabel we can access all
>> files without anything hidden due to active mounts.
>>
>> This comes at the cost of user experience, because setfiles only
>> displays the percentage if no path is given or the path is /
>>
>> Signed-off-by: Jonathan Hettwer <j2468h@gmail.com>
>
> This looks good to me and running fixfiles -vM relabel appeared to
> work as expected, and a subsequent fixfiles -v relabel didn't show any
> changes so it seems to yield a consistent result. Would welcome
> comments from others though since fixfiles has always been somewhat
> magical / obscure to me and I am not much of a shell programmer.
>
> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Applied.
prev parent reply other threads:[~2020-08-17 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 14:59 [RFC PATCH] fixfiles: correctly restore context of mountpoints bauen1
2020-07-06 18:25 ` Stephen Smalley
2020-07-06 19:16 ` bauen1
2020-07-06 19:48 ` Stephen Smalley
2020-08-06 14:48 ` [RFC PATCH v2] " bauen1
2020-08-07 15:05 ` Stephen Smalley
2020-08-17 15:57 ` Stephen Smalley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8630b0c-3a43-8295-9903-f21746c37539@gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=j2468h@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).