SELinux Archive on lore.kernel.org
 help / color / Atom feed
From: jwcart2 <jwcart2@tycho.nsa.gov>
To: William Roberts <bill.c.roberts@gmail.com>
Cc: Gary Tierney <gary.tierney@fastmail.com>,
	selinux@vger.kernel.org, Steve Smalley <sds@tycho.nsa.gov>
Subject: Re: [Non-DoD Source] [PATCH 0/2] checkmodule: allow building modules of a specific version
Date: Fri, 19 Apr 2019 13:21:41 -0400
Message-ID: <fadcf2d6-9012-ce65-84c3-2646aaf72949@tycho.nsa.gov> (raw)
In-Reply-To: <b845d25a-53bf-97f9-0f8d-fc9df477ad53@tycho.nsa.gov>

On 4/18/19 1:49 PM, jwcart2 wrote:
> On 4/18/19 11:18 AM, William Roberts wrote:
>> On Thu, Apr 18, 2019 at 6:27 AM jwcart2 <jwcart2@tycho.nsa.gov> wrote:
>>>
>>> On 4/17/19 12:37 PM, Gary Tierney wrote:
>>>> These changes come from a report by a user on the Freenode IRC channel that
>>>> they were unable to build policies for a machine that has an older version of
>>>> libsepol installed.
>>>>
>>>> A new `-c` option that mirrors checkpolicy's own has been added to checkmodule,
>>>> and the output of a simple test is shown below:
>>>>
>>>> $ cat > test.te <<EOF
>>>> module test 1.0;
>>>>
>>>> require {
>>>>       type domain;
>>>>       type file_type;
>>>>       class file { read write };
>>>> }
>>>>
>>>> allow domain file_type : file { read write };
>>>> EOF
>>>> $ obj/usr/bin/checkmodule -m -M -c 10 -o test.mod test.te
>>>> $ checkpolicy/test/dismod test.mod
>>>> Reading policy...
>>>> ... snip ...
>>>> Binary policy module file loaded.
>>>> Module name: test
>>>> Module version: 1.0
>>>> Policy version: 10
>>>>
>>>> Worthy of note, however, is that these policy version numbers differ from those
>>>> used by the kernel policy format.
>>>>
>>>> Gary Tierney (2):
>>>>     checkmodule: add support for specifying module policy version
>>>>     dismod: print policy version of loaded modules
>>>>
>>>>    checkpolicy/checkmodule.8 |  5 ++++-
>>>>    checkpolicy/checkmodule.c | 29 +++++++++++++++++++++++++++--
>>>>    checkpolicy/test/dismod.c |  4 ++--
>>>>    3 files changed, 33 insertions(+), 5 deletions(-)
>>>>
>>>
>>> Acked-by: James Carter <jwcart2@tycho.nsa.gov>
>>
>> James there's a superfluous newline between strtol() and errno.
>>
> 
> Thanks, I missed that.
> 
> I don't see the need for another version of the patches. I can fix that minor 
> issue when I merge the patches tomorrow.
> 

Merged with the extra newline removed.

>>>
>>> -- 
>>> James Carter <jwcart2@tycho.nsa.gov>
>>> National Security Agency
>>
> 
> 


-- 
James Carter <jwcart2@tycho.nsa.gov>
National Security Agency

      reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 16:37 Gary Tierney
2019-04-17 16:37 ` [PATCH 1/2] checkmodule: add support for specifying module policy version Gary Tierney
2019-04-18 15:11   ` William Roberts
2019-04-17 16:37 ` [PATCH 2/2] dismod: print policy version of loaded modules Gary Tierney
2019-04-18 15:13   ` William Roberts
2019-04-18 13:17 ` [Non-DoD Source] [PATCH 0/2] checkmodule: allow building modules of a specific version jwcart2
2019-04-18 15:18   ` William Roberts
2019-04-18 17:49     ` jwcart2
2019-04-19 17:21       ` jwcart2 [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fadcf2d6-9012-ce65-84c3-2646aaf72949@tycho.nsa.gov \
    --to=jwcart2@tycho.nsa.gov \
    --cc=bill.c.roberts@gmail.com \
    --cc=gary.tierney@fastmail.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux/0 selinux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux selinux/ https://lore.kernel.org/selinux \
		selinux@vger.kernel.org selinux@archiver.kernel.org
	public-inbox-index selinux


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux


AGPL code for this site: git clone https://public-inbox.org/ public-inbox