From: Stephen Smalley <sds@tycho.nsa.gov>
To: Jeffrey Vander Stoep <jeffv@google.com>,
selinux@vger.kernel.org, Joel Galenson <jgalenson@google.com>,
Petr Lautrbach <plautrba@redhat.com>
Subject: Re: Mislabeled /proc/<pid>/ns/mnt files?
Date: Thu, 9 May 2019 17:11:54 -0400 [thread overview]
Message-ID: <fdcf1946-2151-4502-9755-3a10d0646399@tycho.nsa.gov> (raw)
In-Reply-To: <CABXk95D-4v2aT=sZk9NoeGJBGTy=7NTQ8+yKv5E4RvaODJgWLA@mail.gmail.com>
On 5/9/19 3:56 PM, Jeffrey Vander Stoep wrote:
> I expected files here would have the process's context, but they
> don't. The files are actually all symlinks so it's entirely possible
> that the they shouldn't have the process's context. If that's the
> case, how can I provide different labels for them? Neither "proc" nor
> "unlabeled" are appropriate.
>
> On a device with a 3.18 kernel they have the "proc" context:
> sailfish:/ # ls -LZ1 /proc/1/ns
> u:object_r:proc:s0 mnt
> u:object_r:proc:s0 net
>
> On a device with the 4.9 kernel the have the "unlabeled" context:
> blueline:/ # ls -LZ1 /proc/1/ns
> u:object_r:unlabeled:s0 cgroup
> u:object_r:unlabeled:s0 mnt
> u:object_r:unlabeled:s0 net
First, ls -L dereferences symlinks so you are going to get the context
of the object referenced by the symlink, not the context of the symlink
itself.
Second, the task context is only assigned to proc inodes created via
proc_pid_make_inode(), which has never been the case of /proc/pid/ns
inodes - those have their own implementations and operations.
Third, /proc/pid/ns migrated from proc to its own pseudo filesystem,
nsfs, which requires a corresponding fs_use or genfscon rule in policy
or they will be unlabeled. refpolicy has a genfscon rule. Confusingly
there appears to be both in Fedora policy, a fs_use_task and a genfscon
rule, and it appears that fs_use_task is being applied here. I don't
know why or what exactly that means. It won't be the task context for
the task associated with that /proc/pid directory but instead would be
whichever task context instantiates the inode.
next prev parent reply other threads:[~2019-05-09 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 19:56 Mislabeled /proc/<pid>/ns/mnt files? Jeffrey Vander Stoep
2019-05-09 21:11 ` Stephen Smalley [this message]
2019-05-09 21:47 ` Jeffrey Vander Stoep
2019-05-10 7:12 ` Dominick Grift
2019-05-10 14:28 ` Stephen Smalley
2019-05-10 14:40 ` Dominick Grift
[not found] ` <CAB9W1A2LPEk_XixkFU5mVgr9c2yNoiGzBjXYjpc3vDM1b2VpyA@mail.gmail.com>
2019-05-10 12:38 ` Stephen Smalley
2019-05-10 14:55 ` Stephen Smalley
2019-05-14 20:13 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdcf1946-2151-4502-9755-3a10d0646399@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=jeffv@google.com \
--cc=jgalenson@google.com \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).