From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB01EC07E85 for ; Tue, 11 Dec 2018 09:56:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4E7C2082F for ; Tue, 11 Dec 2018 09:56:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4E7C2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=selinux-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726132AbeLKJ4j (ORCPT ); Tue, 11 Dec 2018 04:56:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbeLKJ4j (ORCPT ); Tue, 11 Dec 2018 04:56:39 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0FF1288304; Tue, 11 Dec 2018 09:56:39 +0000 (UTC) Received: from workstation (unknown [10.43.12.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 535BD608F7; Tue, 11 Dec 2018 09:56:38 +0000 (UTC) From: Petr Lautrbach To: selinux@vger.kernel.org Cc: Nicolas Iooss Subject: Re: [PATCH 2/2] python/chcat: fix removing categories on users with Fedora default setup References: <20181209142323.21149-1-nicolas.iooss@m4x.org> <20181209142323.21149-2-nicolas.iooss@m4x.org> Date: Tue, 11 Dec 2018 10:56:36 +0100 In-Reply-To: <20181209142323.21149-2-nicolas.iooss@m4x.org> (Nicolas Iooss's message of "Sun, 9 Dec 2018 15:23:23 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 11 Dec 2018 09:56:39 +0000 (UTC) Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org Nicolas Iooss writes: > Using Vagrant with fedora/28-cloud-base image, SELinux logins are > configured this way: > > # semanage login -l > Login Name SELinux User MLS/MCS Range Service > > __default__ unconfined_u s0-s0:c0.c1023 * > root unconfined_u s0-s0:c0.c1023 * > vagrant unconfined_u s0-s0:c0.c1023 * > > Using "chcat -l +c42 vagrant" successfully adds the category to user > vagrant, but "chcat -l -- -c42 vagrant" fails to remove it. > semanage login -l returns: > > vagrant unconfined_u s0-s0:c0.c1023,c42 * > > This issue is caused by expandCats(), which refuses to return a list of > more than 25 categories. This causes chcat_user_remove() to work with > cats=['c0.c1023,c42'] instead of cats=['c0.c102','c42'], which leads to > it not been able to remove 'c42' from the list. > > Fix this issue by splitting the list of categories before calling > expandCats(). > > Signed-off-by: Nicolas Iooss Acked-by: Petr Lautrbach > --- > python/chcat/chcat | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/python/chcat/chcat b/python/chcat/chcat > index 73f757258807..5bef0073b7a4 100755 > --- a/python/chcat/chcat > +++ b/python/chcat/chcat > @@ -82,8 +82,7 @@ def chcat_user_add(newcat, users): > if len(serange) > 1: > top = serange[1].split(":") > if len(top) > 1: > - cats.append(top[1]) > - cats = expandCats(cats) > + cats = expandCats(top[1].split(',')) > > for i in newcat[1:]: > if i not in cats: > @@ -163,8 +162,7 @@ def chcat_user_remove(newcat, users): > if len(serange) > 1: > top = serange[1].split(":") > if len(top) > 1: > - cats.append(top[1]) > - cats = expandCats(cats) > + cats = expandCats(top[1].split(',')) > > for i in newcat[1:]: > if i in cats: