From: Petr Lautrbach <plautrba@redhat.com>
To: selinux@vger.kernel.org
Cc: Nicolas Iooss <nicolas.iooss@m4x.org>
Subject: Re: [PATCH 1/1] scripts/run-flake8: run on Python scripts not ending with .py
Date: Tue, 08 Jan 2019 14:11:16 +0100 [thread overview]
Message-ID: <pjdef9nnvkb.fsf@redhat.com> (raw)
In-Reply-To: <20190105155953.19583-1-nicolas.iooss@m4x.org> (Nicolas Iooss's message of "Sat, 5 Jan 2019 16:59:53 +0100")
Nicolas Iooss <nicolas.iooss@m4x.org> writes:
> When running flake8 on a directory, it does not analyze files without an
> extension, like semanage_migrate_store, mlscolor-test, etc. Use grep to
> find files with a Python shebang and build a list which is then given to
> flake8.
>
> This commit is possible now that some clean-up patches have been
> applied, such as commit 69c56bd2f6e9 ("python/chcat: improve the code
> readability") and b7227aaec1da ("mcstrans: fix Python linter warnings on
> test scripts") and 3cb974d2d2a7 ("semanage_migrate_store: fix many
> Python linter warnings").
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Acked-by: Petr Lautrbach <plautrba@redhat.com>
https://github.com/SELinuxProject/selinux/pull/128
> ---
> scripts/run-flake8 | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/run-flake8 b/scripts/run-flake8
> index 6ad029fa6852..24b1202fde99 100755
> --- a/scripts/run-flake8
> +++ b/scripts/run-flake8
> @@ -4,6 +4,11 @@
> # Run on the base directory if no argument has been given
> if [ $# -eq 0 ] ; then
> cd "$(dirname -- "$0")/.." || exit $?
> +
> + # Run on both files ending with .py and Python files without extension
> + # shellcheck disable=SC2046
> + set -- $( (find . -name '*.py' ; grep --exclude-dir=.git -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | sort -u )
> + echo "Analyzing $# Python scripts"
> fi
>
> # Assign each ignore warning on a line, in order to ease testing enabling the warning again
next prev parent reply other threads:[~2019-01-08 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 15:59 [PATCH 1/1] scripts/run-flake8: run on Python scripts not ending with .py Nicolas Iooss
2019-01-08 13:11 ` Petr Lautrbach [this message]
2019-01-09 12:19 ` Petr Lautrbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pjdef9nnvkb.fsf@redhat.com \
--to=plautrba@redhat.com \
--cc=nicolas.iooss@m4x.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).