From: Dominick Grift <dominick.grift@defensec.nl>
To: selinux@vger.kernel.org
Subject: Re: [PATCH] policycoreutils: fix inaccurate description in sestatus
Date: Tue, 21 Jul 2020 13:38:21 +0200 [thread overview]
Message-ID: <ypjl7duxyu6q.fsf@defensec.nl> (raw)
In-Reply-To: <20200721112512.1906547-1-dominick.grift@defensec.nl> (Dominick Grift's message of "Tue, 21 Jul 2020 13:25:12 +0200")
Dominick Grift <dominick.grift@defensec.nl> writes:
> strdup(selinux_policy_root()) does not return a path that can be used to derive "Loaded policy name"
> instead if returns a path that can be used to derive "Policy name from config file".
Even though this seems like a nit, this issue was a bit embarrasing for
me in one of my video tutorials:
https://youtu.be/JsD8GLx_ZKA?t=1965
>
> Signed-off-by: Dominick Grift <dominick.grift@defensec.nl>
> ---
> policycoreutils/sestatus/sestatus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/policycoreutils/sestatus/sestatus.c b/policycoreutils/sestatus/sestatus.c
> index b37f0353..8b03b028 100644
> --- a/policycoreutils/sestatus/sestatus.c
> +++ b/policycoreutils/sestatus/sestatus.c
> @@ -268,7 +268,7 @@ int main(int argc, char **argv)
> free(root_path);
>
> /* Dump all the path information */
> - printf_tab("Loaded policy name:");
> + printf_tab("Policy name from config file:");
> pol_path = strdup(selinux_policy_root());
> if (pol_path) {
> pol_name = basename(pol_path);
--
gpg --locate-keys dominick.grift@defensec.nl
Key fingerprint = FCD2 3660 5D6B 9D27 7FC6 E0FF DA7E 521F 10F6 4098
https://sks-keyservers.net/pks/lookup?op=get&search=0xDA7E521F10F64098
Dominick Grift
next prev parent reply other threads:[~2020-07-21 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 11:25 [PATCH] policycoreutils: fix inaccurate description in sestatus Dominick Grift
2020-07-21 11:38 ` Dominick Grift [this message]
2020-07-21 13:08 ` Stephen Smalley
2020-07-21 13:34 ` Dominick Grift
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ypjl7duxyu6q.fsf@defensec.nl \
--to=dominick.grift@defensec.nl \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).