soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Matthew Hagan <mnhagan88@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	 Rob Herring <robh+dt@kernel.org>,
	Olof Johansson <olof@lixom.net>, SoC Team <soc@kernel.org>,
	 Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	 bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	 Viresh Kumar <viresh.kumar@linaro.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	 Geert Uytterhoeven <geert+renesas@glider.be>,
	DTML <devicetree@vger.kernel.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series
Date: Fri, 25 Jun 2021 11:59:08 +0200	[thread overview]
Message-ID: <CAK8P3a3NAOgBa1j+Zsm6FwSm2ux49rFcnTEYJJsmSF8TggRnYA@mail.gmail.com> (raw)
Message-ID: <20210625095908.CWJ0OesJzJZ2FNtq6uzl_OoTUFA8MM3bSOQNVhEnu0U@z> (raw)
In-Reply-To: <20210625095000.3358973-3-mnhagan88@gmail.com>

On Fri, Jun 25, 2021 at 11:52 AM Matthew Hagan <mnhagan88@gmail.com> wrote:
>
> MX64 & MX64W Hardware info:
>   - CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz
>   - RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR)
>   - Storage: 1 GB (Micron MT29F8G08ABACA)
>   - Networking: BCM58625 internal switch (5x 1GbE ports)
>   - USB: 1x USB2.0
>   - Serial: Internal header
>   - WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus
>
> This patch adds the Meraki MX64 series-specific bindings. Since some
> devices make use of the older A0 SoC, changes need to be made to
> accommodate this case, including removal of coherency options and
> modification to the secondary-boot-reg.
>
> Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>

Removing the dma-coherent flags in the dts file seemed really odd until
I read the text above. It would seem more logical to me to have a .dtsi file
that has all the a0 revision specific changes, and include that from the
dts file.

On the other hand, the /chosen, /aliases and  /memory nodes that you have
in the .dtsi file should probably get moved into the .dts files, as these tend
to be board specific settings, even if the examples you have are all
the same.

       Arnd

  parent reply	other threads:[~2021-06-25 10:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  9:49 [PATCH v4 0/4] ARM: dts: NSP: add Meraki MX64/MX65 series Matthew Hagan
2021-06-25  9:49 ` Matthew Hagan
2021-06-25  9:49 ` Matthew Hagan
2021-06-25  9:49 ` [PATCH v4 1/4] ARM: dts: NSP: Add common bindings for MX64/MX65 Matthew Hagan
2021-06-25  9:49   ` Matthew Hagan
2021-06-25  9:49   ` Matthew Hagan
2021-06-25  9:49 ` [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series Matthew Hagan
2021-06-25  9:49   ` Matthew Hagan
2021-06-25  9:49   ` Matthew Hagan
2021-06-25  9:59   ` Arnd Bergmann [this message]
2021-06-25  9:59     ` Arnd Bergmann
2021-06-25  9:59     ` Arnd Bergmann
2021-06-25 17:26     ` Matthew Hagan
2021-06-25 17:26       ` Matthew Hagan
2021-06-25 17:30       ` Florian Fainelli
2021-06-25 17:30         ` Florian Fainelli
2021-06-25 18:40         ` Arnd Bergmann
2021-06-25 18:40           ` Arnd Bergmann
2021-06-25 18:40           ` Arnd Bergmann
2021-06-25  9:49 ` [PATCH v4 3/4] ARM: dts: NSP: Add DT files for Meraki MX65 series Matthew Hagan
2021-06-25  9:49   ` Matthew Hagan
2021-06-25  9:49   ` Matthew Hagan
2021-06-25  9:49 ` [PATCH v4 4/4] dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65 Matthew Hagan
2021-06-25  9:49   ` Matthew Hagan
2021-06-25  9:49   ` Matthew Hagan
2021-07-02 15:14   ` Rob Herring
2021-07-02 15:14     ` Rob Herring
2021-08-05  8:57 ` [PATCH v4 0/4] ARM: dts: NSP: add Meraki MX64/MX65 series Florian Fainelli
2021-08-05  8:57   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a3NAOgBa1j+Zsm6FwSm2ux49rFcnTEYJJsmSF8TggRnYA@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mnhagan88@gmail.com \
    --cc=olof@lixom.net \
    --cc=olteanv@gmail.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sbranden@broadcom.com \
    --cc=soc@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).