From: Rob Herring <robh@kernel.org> To: Corentin Labbe <clabbe@baylibre.com> Cc: arnd@arndb.de, linus.walleij@linaro.org, olof@lixom.net, soc@kernel.org, ulli.kroll@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] ARM: gemini: add device tree for ssi1328 Date: Mon, 12 Jul 2021 14:11:25 -0600 [thread overview] Message-ID: <20210712201125.GA2401230@robh.at.kernel.org> (raw) In-Reply-To: <20210618205533.1527384-6-clabbe@baylibre.com> On Fri, Jun 18, 2021 at 08:55:33PM +0000, Corentin Labbe wrote: > The SSI 1328 is a NAS box running a SL3516 SoC. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/gemini-ssi1328.dts | 138 +++++++++++++++++++++++++++ > 2 files changed, 139 insertions(+) > create mode 100644 arch/arm/boot/dts/gemini-ssi1328.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 806715f3266d..49bf7af72111 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -221,6 +221,7 @@ dtb-$(CONFIG_ARCH_GEMINI) += \ > gemini-rut1xx.dtb \ > gemini-sl93512r.dtb \ > gemini-sq201.dtb \ > + gemini-ssi1328.dtb \ > gemini-wbd111.dtb \ > gemini-wbd222.dtb > dtb-$(CONFIG_ARCH_HI3xxx) += \ > diff --git a/arch/arm/boot/dts/gemini-ssi1328.dts b/arch/arm/boot/dts/gemini-ssi1328.dts > new file mode 100644 > index 000000000000..2b3e7db84fed > --- /dev/null > +++ b/arch/arm/boot/dts/gemini-ssi1328.dts > @@ -0,0 +1,138 @@ > +// SPDX-License-Identifier: GPL-2.0 Dual license? No one runs BSD or other OS on these devices? > +/* > + * Copyright (C) 2021 Corentin Labbe <clabbe@baylibre.com> > + * Device Tree file for SSI 1328 > + */ > + > +/dts-v1/; > + > +#include "gemini.dtsi" Though the license should match this file. > + > +/ { > + model = "SSI 1328"; > + compatible = "ssi,1328", "cortina,gemini"; Where's ssi,1328 documented? > + #address-cells = <1>; > + #size-cells = <1>; > + > + memory@0 { > + /* 128 MB */ > + device_type = "memory"; > + reg = <0x00000000 0x8000000>; > + }; > + > + aliases { > + mdio-gpio0 = &mdio0; > + }; > + > + chosen { > + bootargs = "console=ttyS0,19200n8 initrd=0x900000,9M"; > + stdout-path = &uart0; Don't need both 'console' and stdout-path. (console should be removed) > + }; > + > + mdio0: mdio { > + compatible = "virtual,mdio-gpio"; > + gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>, /* MDC */ > + <&gpio0 21 GPIO_ACTIVE_HIGH>; /* MDIO */ > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* LAN Marvell 88E1118 */ > + phy0: ethernet-phy@1 { > + reg = <1>; > + device_type = "ethernet-phy"; > + /* We lack the knowledge of necessary GPIO to achieve > + * Gigabit > + */ > + max-speed = <100>; > + }; > + /* WAN ICPlus IP101A */ > + phy1: ethernet-phy@2 { > + reg = <2>; > + device_type = "ethernet-phy"; > + }; > + }; > +}; > + > +ðernet { > + status = "okay"; > + ethernet-port@0 { > + phy-mode = "rgmii"; > + phy-handle = <&phy0>; > + }; > + ethernet-port@1 { > + phy-mode = "rgmii"; > + phy-handle = <&phy1>; > + }; > +}; > + > +&flash { > + status = "okay"; > + /* 32MB of flash */ > + reg = <0x30000000 0x03200000>; > + > + pinctrl-names = "enabled", "disabled"; > + pinctrl-0 = <&pflash_default_pins>; > + pinctrl-1 = <&pflash_disabled_pins>; > + > + partitions { > + compatible = "redboot-fis"; > + /* Eraseblock at 0xfe0000 */ > + fis-index-block = <0x7F>; > + }; > +}; > + > +&gpio0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio0_default_pins>; > +}; > + > +&ide0 { > + status = "okay"; > +}; > + > +&ide1 { > + status = "okay"; > +}; > + > +&sata { > + cortina,gemini-ata-muxmode = <0>; > + cortina,gemini-enable-sata-bridge; > + status = "okay"; > +}; > + > +&syscon { > + pinctrl { > + /* > + * gpio0agrp cover line 0-4 > + * gpio0bgrp cover line 5 > + */ > + gpio0_default_pins: pinctrl-gpio0 { > + mux { > + function = "gpio0"; > + groups = "gpio0agrp", "gpio0bgrp"; > + }; > + }; > + pflash_disabled_pins: pinctrl-pflash-disabled { > + mux { > + function = "gpio0"; > + groups = "gpio0ggrp", "gpio0igrp", "gpio0jgrp", > + "gpio0kgrp"; > + }; > + }; > + pinctrl-gmii { > + /* This platform use both the ethernet ports */ > + mux { > + function = "gmii"; > + groups = "gmii_gmac0_grp", "gmii_gmac1_grp"; > + }; > + }; > + }; > +}; > + > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > -- > 2.31.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Corentin Labbe <clabbe@baylibre.com> Cc: arnd@arndb.de, linus.walleij@linaro.org, olof@lixom.net, soc@kernel.org, ulli.kroll@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] ARM: gemini: add device tree for ssi1328 Date: Mon, 12 Jul 2021 14:11:25 -0600 [thread overview] Message-ID: <20210712201125.GA2401230@robh.at.kernel.org> (raw) Message-ID: <20210712201125.QliN-e4ezYcaHHdPivfEk1HkBxv1ilDsusJz4oAkC8k@z> (raw) In-Reply-To: <20210618205533.1527384-6-clabbe@baylibre.com> On Fri, Jun 18, 2021 at 08:55:33PM +0000, Corentin Labbe wrote: > The SSI 1328 is a NAS box running a SL3516 SoC. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/gemini-ssi1328.dts | 138 +++++++++++++++++++++++++++ > 2 files changed, 139 insertions(+) > create mode 100644 arch/arm/boot/dts/gemini-ssi1328.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 806715f3266d..49bf7af72111 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -221,6 +221,7 @@ dtb-$(CONFIG_ARCH_GEMINI) += \ > gemini-rut1xx.dtb \ > gemini-sl93512r.dtb \ > gemini-sq201.dtb \ > + gemini-ssi1328.dtb \ > gemini-wbd111.dtb \ > gemini-wbd222.dtb > dtb-$(CONFIG_ARCH_HI3xxx) += \ > diff --git a/arch/arm/boot/dts/gemini-ssi1328.dts b/arch/arm/boot/dts/gemini-ssi1328.dts > new file mode 100644 > index 000000000000..2b3e7db84fed > --- /dev/null > +++ b/arch/arm/boot/dts/gemini-ssi1328.dts > @@ -0,0 +1,138 @@ > +// SPDX-License-Identifier: GPL-2.0 Dual license? No one runs BSD or other OS on these devices? > +/* > + * Copyright (C) 2021 Corentin Labbe <clabbe@baylibre.com> > + * Device Tree file for SSI 1328 > + */ > + > +/dts-v1/; > + > +#include "gemini.dtsi" Though the license should match this file. > + > +/ { > + model = "SSI 1328"; > + compatible = "ssi,1328", "cortina,gemini"; Where's ssi,1328 documented? > + #address-cells = <1>; > + #size-cells = <1>; > + > + memory@0 { > + /* 128 MB */ > + device_type = "memory"; > + reg = <0x00000000 0x8000000>; > + }; > + > + aliases { > + mdio-gpio0 = &mdio0; > + }; > + > + chosen { > + bootargs = "console=ttyS0,19200n8 initrd=0x900000,9M"; > + stdout-path = &uart0; Don't need both 'console' and stdout-path. (console should be removed) > + }; > + > + mdio0: mdio { > + compatible = "virtual,mdio-gpio"; > + gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>, /* MDC */ > + <&gpio0 21 GPIO_ACTIVE_HIGH>; /* MDIO */ > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* LAN Marvell 88E1118 */ > + phy0: ethernet-phy@1 { > + reg = <1>; > + device_type = "ethernet-phy"; > + /* We lack the knowledge of necessary GPIO to achieve > + * Gigabit > + */ > + max-speed = <100>; > + }; > + /* WAN ICPlus IP101A */ > + phy1: ethernet-phy@2 { > + reg = <2>; > + device_type = "ethernet-phy"; > + }; > + }; > +}; > + > +ðernet { > + status = "okay"; > + ethernet-port@0 { > + phy-mode = "rgmii"; > + phy-handle = <&phy0>; > + }; > + ethernet-port@1 { > + phy-mode = "rgmii"; > + phy-handle = <&phy1>; > + }; > +}; > + > +&flash { > + status = "okay"; > + /* 32MB of flash */ > + reg = <0x30000000 0x03200000>; > + > + pinctrl-names = "enabled", "disabled"; > + pinctrl-0 = <&pflash_default_pins>; > + pinctrl-1 = <&pflash_disabled_pins>; > + > + partitions { > + compatible = "redboot-fis"; > + /* Eraseblock at 0xfe0000 */ > + fis-index-block = <0x7F>; > + }; > +}; > + > +&gpio0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio0_default_pins>; > +}; > + > +&ide0 { > + status = "okay"; > +}; > + > +&ide1 { > + status = "okay"; > +}; > + > +&sata { > + cortina,gemini-ata-muxmode = <0>; > + cortina,gemini-enable-sata-bridge; > + status = "okay"; > +}; > + > +&syscon { > + pinctrl { > + /* > + * gpio0agrp cover line 0-4 > + * gpio0bgrp cover line 5 > + */ > + gpio0_default_pins: pinctrl-gpio0 { > + mux { > + function = "gpio0"; > + groups = "gpio0agrp", "gpio0bgrp"; > + }; > + }; > + pflash_disabled_pins: pinctrl-pflash-disabled { > + mux { > + function = "gpio0"; > + groups = "gpio0ggrp", "gpio0igrp", "gpio0jgrp", > + "gpio0kgrp"; > + }; > + }; > + pinctrl-gmii { > + /* This platform use both the ethernet ports */ > + mux { > + function = "gmii"; > + groups = "gmii_gmac0_grp", "gmii_gmac1_grp"; > + }; > + }; > + }; > +}; > + > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > -- > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-12 20:11 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-18 20:55 [PATCH v2 0/5] ARM: gemini: add two more board Corentin Labbe 2021-06-18 20:55 ` Corentin Labbe 2021-06-18 20:55 ` [PATCH v2 1/5] ARM: dts: gemini: add labels for USB, IDE, flash and ethernet Corentin Labbe 2021-06-18 20:55 ` Corentin Labbe 2021-06-18 20:55 ` [PATCH v2 2/5] dt-bindings: add vendor prefix for edimax Corentin Labbe 2021-06-18 20:55 ` Corentin Labbe 2021-07-12 20:11 ` Rob Herring 2021-07-12 20:11 ` Rob Herring 2021-06-18 20:55 ` [PATCH v2 3/5] dt-bindings: add vendor prefix for ssi Corentin Labbe 2021-06-18 20:55 ` Corentin Labbe 2021-07-12 20:11 ` Rob Herring 2021-07-12 20:11 ` Rob Herring 2021-06-18 20:55 ` [PATCH v2 4/5] ARM: gemini: add device tree for edimax NS2502 Corentin Labbe 2021-06-18 20:55 ` Corentin Labbe 2021-06-18 20:55 ` [PATCH v2 5/5] ARM: gemini: add device tree for ssi1328 Corentin Labbe 2021-06-18 20:55 ` Corentin Labbe 2021-07-12 20:11 ` Rob Herring [this message] 2021-07-12 20:11 ` Rob Herring 2021-07-23 10:38 ` Linus Walleij 2021-07-23 10:38 ` Linus Walleij 2021-07-23 10:38 ` Linus Walleij 2021-07-23 10:34 ` [PATCH v2 0/5] ARM: gemini: add two more board Linus Walleij 2021-07-23 10:34 ` Linus Walleij 2021-07-23 10:34 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210712201125.GA2401230@robh.at.kernel.org \ --to=robh@kernel.org \ --cc=arnd@arndb.de \ --cc=clabbe@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=olof@lixom.net \ --cc=soc@kernel.org \ --cc=ulli.kroll@googlemail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).