From: Mark Rutland <mark.rutland@arm.com>
To: Bert Vermeulen <bert@biot.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523
Date: Fri, 30 Jul 2021 15:46:27 +0100 [thread overview]
Message-ID: <20210730144627.GB19569@C02TD0UTHF1T.local> (raw)
Message-ID: <20210730144627.1F33ltK1e3sMgh7MQs6CwTqiQKXVoil4-YaMXCRCU-Y@z> (raw)
In-Reply-To: <20210730134552.853350-4-bert@biot.com>
On Fri, Jul 30, 2021 at 03:45:50PM +0200, Bert Vermeulen wrote:
> From: John Crispin <john@phrozen.org>
>
> Add basic support for EcoNet EN7523, enough for booting to console.
>
> The UART is basically 8250-compatible, except for the clock selection.
> A clock-frequency value is synthesized to get this to run at 115200 bps.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bert Vermeulen <bert@biot.com>
> ---
> arch/arm/boot/dts/Makefile | 2 +
> arch/arm/boot/dts/en7523-evb.dts | 17 ++++
> arch/arm/boot/dts/en7523.dtsi | 128 +++++++++++++++++++++++++++++++
> 3 files changed, 147 insertions(+)
> create mode 100644 arch/arm/boot/dts/en7523-evb.dts
> create mode 100644 arch/arm/boot/dts/en7523.dtsi
[...]
> + gic: interrupt-controller@09000000 {
> + compatible = "arm,gic-v3";
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x09000000 0x20000>,
> + <0x09080000 0x80000>;
> + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
> +
> + its: gic-its@09020000 {
> + compatible = "arm,gic-v3-its";
> + msi-controller;
> + #msi-cell = <1>;
> + reg = <0x090200000 0x20000>;
> + };
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
This should be "arm,armv7-timer".
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
GICv3 doesn't have a cpumask in its PPI description, so the
GIC_CPU_MASK_SIMPLE() bits should be removed.
> + clock-frequency = <25000000>;
Please have your FW configure CNTFRQ on each CPU; the clock-frequency
property in the DT is a workaround for broken FW, and it's *vastly*
preferable for FW to configure this correctly (e.g. as it means VMs
should "just work").
Thanks,
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-30 14:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210730134552.853350-1-bert@biot.com>
2021-07-30 13:45 ` [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Bert Vermeulen
2021-07-30 13:45 ` Bert Vermeulen
2021-07-30 14:31 ` Linus Walleij
2021-07-30 14:31 ` Linus Walleij
2021-07-30 14:31 ` Linus Walleij
2021-07-30 14:53 ` Marc Zyngier
2021-07-30 14:53 ` Marc Zyngier
2021-08-01 9:07 ` Bert Vermeulen
2021-08-01 9:07 ` Bert Vermeulen
2021-08-01 9:07 ` Bert Vermeulen
2021-08-01 9:40 ` Arnd Bergmann
2021-08-01 9:40 ` Arnd Bergmann
2021-08-01 9:40 ` Arnd Bergmann
2021-08-01 9:50 ` Marc Zyngier
2021-08-01 9:50 ` Marc Zyngier
2021-07-30 14:45 ` Daniel Palmer
2021-07-30 14:45 ` Daniel Palmer
2021-07-30 14:45 ` Daniel Palmer
2021-07-30 14:46 ` Mark Rutland [this message]
2021-07-30 14:46 ` Mark Rutland
2021-08-04 16:41 ` Bert Vermeulen
2021-08-04 16:41 ` Bert Vermeulen
2021-08-06 20:59 ` Rob Herring
2021-08-06 20:59 ` Rob Herring
2021-07-30 14:59 ` Mark Rutland
2021-07-30 14:59 ` Mark Rutland
2021-08-06 20:52 ` Rob Herring
2021-08-06 20:52 ` Rob Herring
2021-07-30 16:47 ` Andre Przywara
2021-07-30 16:47 ` Andre Przywara
2021-07-30 17:23 ` Marc Zyngier
2021-07-30 17:23 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730144627.GB19569@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=arnd@arndb.de \
--cc=bert@biot.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).