From: Romain Perier <romain.perier@gmail.com>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>, SoC Team <soc@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W
Date: Sat, 11 Sep 2021 14:19:53 +0200 [thread overview]
Message-ID: <CABgxDoLBbD8P-PhRH+SmuuQ8jNR53Ti=8brFL3NXMmiotXU5ww@mail.gmail.com> (raw)
Message-ID: <20210911121953.RD693luphoelS1yjvVLtrvcdVEAEyn8e3mP-kDZaqQw@z> (raw)
In-Reply-To: <CAFr9PXmRXcu_ifE62dT5AwZv2uFbYVfAc5ZX5qBoRkEPKGB+JA@mail.gmail.com>
Hi Daniel,
Ack, I will fix it (remove "common" from the file name and the unneeded space)
Thanks,
Romain
Le sam. 11 sept. 2021 à 05:18, Daniel Palmer <daniel@0x0f.com> a écrit :
>
> Hi Romain,
>
> On Sat, 11 Sept 2021 at 04:03, Romain Perier <romain.perier@gmail.com> wrote:
> > + - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01
> > + - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22W
>
> For anyone wondering why we have two strings here:
> The SBC board is made up of a SoM and a board with the connectors.
> The SoM could be used standalone so we might as well have a compatible
> for it too.
> We have some dtsis for the SoM but really those could be built as is
> to support someone using the SoM on it's own.
>
> > +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01-common.dtsi
>
> For anyone wondering:
>
> The som2d01 can come with an SSD201 (64MB DDR2 integrated) or SSD202D
> (128MB DDR3 integrated) and they need different fixed regulators for
> the DDR supply.
> So we have a common dtsi and then override the regulator in another
> layer of dtsi for the SSD202D version.
>
> Thinking about it now I think we can drop common from the file name.
>
> > @@ -0,0 +1,21 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/*
> > + * Copyright (c) 2021 thingy.jp.
> > + * Author: Daniel Palmer <daniel@thingy.jp>
> > + * Author: Romain Perier <romain.perier@gmail.com>
> > + */
> > +
> > +/ {
> > +
>
> Unneeded space.
>
> > + reg_vcc_dram: regulator-vcc-dram {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_dram";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-boot-on;
> > + };
> > +};
> > +
> > +&pm_uart {
> > + status = "okay";
> > +};
> > diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> > new file mode 100644
> > index 000000000000..20b40b711d4f
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> > @@ -0,0 +1,23 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/*
> > + * Copyright (c) 2021 thingy.jp.
> > + * Author: Daniel Palmer <daniel@thingy.jp>
> > + * Author: Romain Perier <romain.perier@gmail.com>
> > + */
> > +
> > +/dts-v1/;
> > +#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi"
> > +#include <dt-bindings/gpio/gpio.h>
> > +
> > +/ {
> > + model = "Wireless Tag IDO-SBC2D06-1VB-22W";
> > + compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m";
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > + sys_led {
> > + gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "heartbeat";
> > + };
> > + };
> > +};
> > diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> > new file mode 100644
> > index 000000000000..06567a5219c5
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> > @@ -0,0 +1,28 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/*
> > + * Copyright (c) 2021 thingy.jp.
> > + * Author: Daniel Palmer <daniel@thingy.jp>
> > + * Author: Romain Perier <romain.perier@gmail.com>
> > + */
> > +
> > +/dts-v1/;
> > +#include "mstar-infinity2m-ssd202d.dtsi"
> > +#include "mstar-infinity2m-ssd201-som2d01-common.dtsi"
> > +
> > +/ {
> > + model = "Wireless Tag IDO-SOM2D01 (SSD202D)";
> > + compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m";
> > +
> > + aliases {
> > + serial0 = &pm_uart;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +};
> > +
> > +®_vcc_dram {
> > + regulator-min-microvolt = <1500000>;
> > + regulator-max-microvolt = <1500000>;
> > +};
> > --
> > 2.33.0
> >
>
> Cheers,
>
> Daniel
next prev parent reply other threads:[~2021-09-11 12:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210910190318.LiBVdGxNtTh1STWT7X-D6-ycVsuAIw2eGokZ2mGkwHQ@z>
2021-09-10 19:03 ` [PATCH 0/4] Add support for IDO-SBC2D06-V1B-22W Romain Perier
[not found] ` <20210910190319.-W3JSWMF-ViH0xEBABZu9QxYXYsqAMCcnUzaQOuA0VA@z>
2021-09-10 19:03 ` [PATCH 1/4] ARM: mstar: Mark timer with arm, cpu-registers-not-fw-configured Romain Perier
[not found] ` <20210910190320.I83Fh3D9fot2qvtxilXNNe69lepFYpFNP_UhnJbwApA@z>
2021-09-10 19:03 ` [PATCH 2/4] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W Romain Perier
[not found] ` <20210911031832.Cbmi2AFC5itpE51xSVUVcaU38zhQIv6qXNdVfFo7ioE@z>
2021-09-11 3:18 ` Daniel Palmer
2021-09-11 3:18 ` Daniel Palmer
[not found] ` <20210911121953.mlR9YmwioU31zCrhfzJJ30Nc146d4Zpow05SFhNnseg@z>
2021-09-11 12:19 ` Romain Perier [this message]
2021-09-11 12:19 ` Romain Perier
[not found] ` <20210910190321.VxpWTm8epkxLaAggLaakGNK5-Y-sx7hgd4Ljxr_UrA0@z>
2021-09-10 19:03 ` [PATCH 3/4] dt-bindings: add vendor prefix for Wireless Tag Romain Perier
2021-09-11 2:49 ` Daniel Palmer
[not found] ` <20210911025921.UtZhdDpABm5BJya3ddE8il1-rQQrQnCPy8lf195ECQc@z>
2021-09-11 2:59 ` Daniel Palmer
2021-09-11 2:59 ` Daniel Palmer
[not found] ` <20210911122058.1QibK7bSO8D1CnKmHwsH_7kMRLwBwVaKeULAbmLi3_M@z>
2021-09-11 12:20 ` Romain Perier
2021-09-11 12:20 ` Romain Perier
[not found] ` <20210910190322.cLx5d5PXwwjgl_MbuGLEVO8AAmxCkVtVgXIr5kqrZPM@z>
2021-09-10 19:03 ` [PATCH 4/4] MAINTAINERS: Add myself as MStar/Sigmastar Armv7 SoC maintainers Romain Perier
[not found] ` <20210911025633.pjXagSIKnRktvUFq3FZOzk7DaWlktUgXHO0pzS2yYsk@z>
2021-09-11 2:56 ` Daniel Palmer
2021-09-11 2:56 ` Daniel Palmer
[not found] ` <20210914135404.sU3SgUIVmXy-eKlMo7YpzMEaOxhI3idFIzhgE0HY_RM@z>
2021-09-14 13:54 ` Arnd Bergmann
2021-09-14 13:54 ` Arnd Bergmann
[not found] ` <20210914150444.KCVx_MJa2Vc8LA3wb1jkWhLtrwkAWTIfN0saCXwQTn4@z>
2021-09-14 15:04 ` Daniel Palmer
2021-09-14 15:04 ` Daniel Palmer
[not found] ` <20210914152610.naiVsGyusiPbf9b_3tTofLoTeN2hYqpowPYkjGvi4gw@z>
2021-09-14 15:26 ` Arnd Bergmann
2021-09-14 15:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABgxDoLBbD8P-PhRH+SmuuQ8jNR53Ti=8brFL3NXMmiotXU5ww@mail.gmail.com' \
--to=romain.perier@gmail.com \
--cc=arnd@arndb.de \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).