From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75216C77B75 for ; Tue, 16 May 2023 15:51:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 5ADEDC4339E; Tue, 16 May 2023 15:51:51 +0000 (UTC) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 558A6C433EF; Tue, 16 May 2023 15:51:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 558A6C433EF Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-510b6a249a8so76976a12.0; Tue, 16 May 2023 08:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684252308; x=1686844308; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=68srKCHs7MOmD8qVy7azG1dB7pPSq7b9dHnxIkISzTs=; b=iTUS/wUE8BKyDA6qSZodOkI0rEqV0M7K5I7xfvEnet54BGQGXGOSGhMhhOUfZSb563 +uJB+sgkak0HtNnKxCw8ptox//DCDjhU1VLd0XDlfv9DyFVTGIKqopHIss5WaXkZJIeW DSwAX7CTsn5tcFbWaxjfGL29lo2sp/j9d2tYjOMPmzqgboK/m61tUvq7uJnBt8ZMSRmn tldueC/cmvmx6uFV/ZsuEt4w58KFEcPDyjHTa4bjGWbVyRUF68jMpoeWBAa682Jjw05T jWQQ9Z8dBSDUqE8HBlfFox9CUab+Ibq+PVFQ3delRVxLrxogy2nj8atfQfnlZvHpx31L gRiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684252308; x=1686844308; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=68srKCHs7MOmD8qVy7azG1dB7pPSq7b9dHnxIkISzTs=; b=Z9umwc+5U5za8hFAZb3j8L/on/hyw3tauU6F8zHVyMYSdt7fJwxJRYrQlBiunOUGtT 6x8TUiCABPSBsNn9PFN6YFXkxCEVqI85uzVqkEBkGE3oWN32fLXGClTKsGVfe7jy20eH 297tis1q98kJzwnssSdsPxJvlKnqPVNpPaQXBmzhythXCT1CjWlPVIaC/aENfZxrcb+9 F8Uo6bk8RrwU5rmQR4u3+EP56y2SWTBPm0UPabKFgWhKp6eJ/tUeR9tsEBdB3lznZLpW nxjGypY4lInIkhzDI9bwJXy+dsXGwaGcXqc93Oc+HpNWP2KthmjA0Bsg4PFsZ4e4/Tix 63tQ== X-Gm-Message-State: AC+VfDxKJiaeeB4/9P6UmIIwt7MfAuWcj76WfJTB++luwNYnPtYgPg0g 4mpd+bUZOPv6oOHdp6uh+NCoGh9gWAlNtE8M X-Google-Smtp-Source: ACHHUZ6UUBhE2/l4rk0+SCxoMU9t9VVFuC5HUku4gkgS9VHvi0TfYlJHNkXhMHDuH1xgAyrCeRm11A== X-Received: by 2002:aa7:dd0f:0:b0:50c:4b1:8912 with SMTP id i15-20020aa7dd0f000000b0050c04b18912mr31793925edv.15.1684252308282; Tue, 16 May 2023 08:51:48 -0700 (PDT) Received: from giga-mm.home ([2a02:1210:8629:800:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id t5-20020a05640203c500b0050d82f96860sm8527921edw.59.2023.05.16.08.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 08:51:47 -0700 (PDT) Message-ID: <2abeb4d11e8274bc337e504c6b0b42e86899150a.camel@gmail.com> Subject: Re: [PATCH 02/13] ARM: ep93xx: fix missing-prototype warnings From: Alexander Sverdlin List-Id: To: Arnd Bergmann , soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Date: Tue, 16 May 2023 17:51:46 +0200 In-Reply-To: <20230516153109.514251-3-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> <20230516153109.514251-3-arnd@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 Hi Arnd! On Tue, 2023-05-16 at 17:30 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > ep93xx_clocksource_read() is only called from the file it is declared in, > while ep93xx_timer_init() is declared in a header that is not included he= re. >=20 > arch/arm/mach-ep93xx/timer-ep93xx.c:120:13: error: no previous prototype = for 'ep93xx_timer_init' > arch/arm/mach-ep93xx/timer-ep93xx.c:63:5: error: no previous prototype fo= r 'ep93xx_clocksource_read' >=20 > Fixes: 000bc17817bf ("ARM: ep93xx: switch to GENERIC_CLOCKEVENTS") > Signed-off-by: Arnd Bergmann Acked-by: Alexander Sverdlin > --- > =C2=A0arch/arm/mach-ep93xx/timer-ep93xx.c | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/t= imer-ep93xx.c > index dd4b164d1831..a9efa7bc2fa1 100644 > --- a/arch/arm/mach-ep93xx/timer-ep93xx.c > +++ b/arch/arm/mach-ep93xx/timer-ep93xx.c > @@ -9,6 +9,7 @@ > =C2=A0#include > =C2=A0#include > =C2=A0#include "soc.h" > +#include "platform.h" > =C2=A0 > =C2=A0/******************************************************************= ******* > =C2=A0 * Timer handling for EP93xx > @@ -60,7 +61,7 @@ static u64 notrace ep93xx_read_sched_clock(void) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return ret; > =C2=A0} > =C2=A0 > -u64 ep93xx_clocksource_read(struct clocksource *c) > +static u64 ep93xx_clocksource_read(struct clocksource *c) > =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u64 ret; --=20 Alexander Sverdlin.