[PATCH] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC

[PATCH] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC

[Bonnie Lo]

From: Bonnie Lo <Bonnie_Lo@wiwynn.com>

Add linux device tree entry related to
greatlakes specific devices connected to BMC SoC.

Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>
---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-facebook-greatlakes.dts    | 247 ++++++++++++++++++
 2 files changed, 248 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 05d8aef6e5d2..d9f417f2d7df 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1586,6 +1586,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
        aspeed-bmc-facebook-elbert.dtb \
        aspeed-bmc-facebook-fuji.dtb \
        aspeed-bmc-facebook-galaxy100.dtb \
+       aspeed-bmc-facebook-greatlakes.dtb \
        aspeed-bmc-facebook-minipack.dtb \
        aspeed-bmc-facebook-tiogapass.dtb \
        aspeed-bmc-facebook-wedge40.dtb \
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
new file mode 100644
index 000000000000..c368eb33efeb
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-greatlakes.dts
@@ -0,0 +1,247 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2022 Facebook Inc.
+
+/dts-v1/;
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/leds/leds-pca955x.h>
+#include <dt-bindings/i2c/i2c.h>
+
+/ {
+       model = "Facebook Greatlakes BMC";
+       compatible = "facebook,greatlakes-bmc", "aspeed,ast2600";
+
+       aliases {
+               serial4 = &uart5;
+       };
+
+       chosen {
+               bootargs = "console=ttyS4,57600n8";
+       };
+
+       memory@80000000 {
+               device_type = "memory";
+               reg = <0x80000000 0x80000000>;
+       };
+
+       iio-hwmon {
+               compatible = "iio-hwmon";
+               io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+                               <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+                               <&adc1 0>, <&adc1 2>, <&adc1 3>, <&adc1 4>,
+                               <&adc1 5>, <&adc1 6>;
+       };
+};
+
+&uart1 {
+       status = "okay";
+};
+
+&uart2 {
+       status = "okay";
+};
+
+&uart3 {
+       status = "okay";
+};
+
+&uart4 {
+       status = "okay";
+};
+
+&uart5 {
+       status = "okay";
+};
+
+&wdt1 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_wdtrst1_default>;
+       aspeed,reset-type = "soc";
+       aspeed,external-signal;
+       aspeed,ext-push-pull;
+       aspeed,ext-active-high;
+       aspeed,ext-pulse-duration = <256>;
+};
+
+&mac3 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii4_default>;
+       no-hw-checksum;
+       use-ncsi;
+       mlx,multi-host;
+       ncsi-ctrl,start-redo-probe;
+       ncsi-ctrl,no-channel-monitor;
+       ncsi-package = <1>;
+       ncsi-channel = <1>;
+       ncsi-rexmit = <1>;
+       ncsi-timeout = <2>;
+};
+
+&rtc {
+       status = "okay";
+};
+
+&fmc {
+       status = "okay";
+       flash@0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc";
+               spi-rx-bus-width = <4>;
+               spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout-64.dtsi"
+       };
+       flash@1 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc2";
+               spi-rx-bus-width = <4>;
+               spi-max-frequency = <50000000>;
+       };
+};
+
+&i2c0 {
+       status = "okay";
+       multi-master;
+       ipmb0@10 {
+               compatible = "ipmb-dev";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+               i2c-protocol;
+       };
+};
+
+&i2c1 {
+       status = "okay";
+       multi-master;
+       ipmb1@10 {
+               compatible = "ipmb-dev";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+               i2c-protocol;
+       };
+};
+
+&i2c2 {
+       status = "okay";
+       multi-master;
+       ipmb2@10 {
+               compatible = "ipmb-dev";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+               i2c-protocol;
+       };
+};
+
+&i2c3 {
+       status = "okay";
+       multi-master;
+       ipmb3@10 {
+               compatible = "ipmb-dev";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+               i2c-protocol;
+       };
+};
+
+&i2c4 {
+       status = "okay";
+};
+
+&i2c5 {
+       status = "okay";
+};
+
+&i2c6 {
+       status = "okay";
+};
+
+&i2c7 {
+       status = "okay";
+};
+
+&i2c8 {
+       status = "okay";
+       temperature-sensor@1f {
+               compatible = "ti,tmp421";
+               reg = <0x1f>;
+       };
+       // NIC EEPROM
+       eeprom@50 {
+               compatible = "st,24c32";
+               reg = <0x50>;
+       };
+};
+
+&i2c9 {
+       status = "okay";
+       multi-master;
+       ipmb9@10 {
+               compatible = "ipmb-dev";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+               i2c-protocol;
+       };
+};
+
+&i2c10 {
+       status = "okay";
+};
+
+&i2c11 {
+       status = "okay";
+       eeprom@51 {
+               compatible = "atmel,24c128";
+               reg = <0x51>;
+       };
+       eeprom@54 {
+               compatible = "atmel,24c128";
+               reg = <0x54>;
+       };
+};
+
+&i2c12 {
+       status = "okay";
+       temperature-sensor@4f {
+               compatible = "lm75";
+               reg = <0x4f>;
+       };
+};
+
+&i2c13 {
+       status = "okay";
+};
+
+&adc0 {
+       ref_voltage = <2500>;
+       status = "okay";
+       pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+                       &pinctrl_adc2_default &pinctrl_adc3_default
+                       &pinctrl_adc4_default &pinctrl_adc5_default
+                       &pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+       ref_voltage = <2500>;
+       status = "okay";
+       pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc10_default
+                       &pinctrl_adc11_default &pinctrl_adc12_default
+                       &pinctrl_adc13_default &pinctrl_adc14_default>;
+};
+
+
+&ehci0 {
+       status = "okay";
+};
+
+&ehci1 {
+       status = "okay";
+};
+
+&uhci {
+       status = "okay";
+};
+
+&gpio0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_gpiu1_default &pinctrl_gpiu7_default>;
+};
+
+
--
2.17.1

WIWYNN PROPRIETARY
This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.

Re: [PATCH] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC

[Krzysztof Kozlowski]

On 20/09/2022 04:30, Bonnie Lo wrote:
> From: Bonnie Lo <Bonnie_Lo@wiwynn.com>
> 
> Add linux device tree entry related to
> greatlakes specific devices connected to BMC SoC.
> 
> Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>

Do not ignore comments, but either implement them or keep discussion
going. If something is not clear, feel free to ask for clarifications.

Since there are no changes and you resubmit the same patch - NAK.

(...)

> 
> WIWYNN PROPRIETARY
> This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.

This means we have to remove the email because I was not authorized to
copy/distribute it.

Best regards,
Krzysztof

RE: [PATCH] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC

[Bonnie Lo/WYHQ/Wiwynn]

Hi Krzysztof,

I am sorry.
I have revise the DTS according to your comment and revise the subject.
I would like to update the patch to you, so I use "git send email" again.
It seems like it doesn't reply the original mail but resubmit the patch.
Could you guide me how I can reply the original mail thread and update the patch but resubmit it.

Thanks,
Bonnie

-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Tuesday, September 20, 2022 3:07 PM
To: Bonnie Lo/WYHQ/Wiwynn <Bonnie_Lo@wiwynn.com>
Cc: patrick@stwcx.xyz; garnermic@fb.com; Delphine Chiu/WYHQ/Wiwynn <DELPHINE_CHIU@wiwynn.com>; Arnd Bergmann <arnd@arndb.de>; Olof Johansson <olof@lixom.net>; soc@kernel.org; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC

  Security Reminder: Please be aware that this email is sent by an external sender.

On 20/09/2022 04:30, Bonnie Lo wrote:
> From: Bonnie Lo <Bonnie_Lo@wiwynn.com>
>
> Add linux device tree entry related to greatlakes specific devices
> connected to BMC SoC.
>
> Signed-off-by: Bonnie Lo <Bonnie_Lo@wiwynn.com>

Do not ignore comments, but either implement them or keep discussion going. If something is not clear, feel free to ask for clarifications.

Since there are no changes and you resubmit the same patch - NAK.

(...)

>
> WIWYNN PROPRIETARY
> This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.

This means we have to remove the email because I was not authorized to copy/distribute it.

Best regards,
Krzysztof
WIWYNN PROPRIETARY
This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.

Re: [PATCH] ARM: dts: aspeed: greatlakes: Add Facebook greatlakes (AST2600) BMC

[Krzysztof Kozlowski]

On 20/09/2022 09:28, Bonnie Lo/WYHQ/Wiwynn wrote:
> Hi Krzysztof,
> 
> I am sorry.
> I have revise the DTS according to your comment and revise the subject.

You send again the same patch. If you intended to send a version 2,
please indicate it. Git format-patch can help you. Our process also
explains it.

https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst

> I would like to update the patch to you, so I use "git send email" again.
> It seems like it doesn't reply the original mail but resubmit the patch.
> Could you guide me how I can reply the original mail thread and update the patch but resubmit it.

Resubmit same patch is not correct. You just did it. I expect new
versions of your patch. Each new version should be appropriately marked
with version number and changelog. Just take a look at other patches in
the list.

https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst

> 
> Thanks,
> Bonnie

Do not top post.


> This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.

I notify you that I am going to remove the email immediately.

Best regards,
Krzysztof