* [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver
@ 2021-07-21 15:16 Arnd Bergmann
2021-07-21 15:16 ` Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Arnd Bergmann @ 2021-07-21 15:16 UTC (permalink / raw)
To: Linus Walleij
Cc: soc, Arnd Bergmann, Linus Walleij, Imre Kaloz, Krzysztof Halasa,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When this driver is disabled, the board file fails to build,
so add a dependency:
arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit':
arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration]
472 | ixp4xx_pci_preinit();
| ^~~~~~~~~~~~~~~~~~
| iop3xx_pci_preinit
arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit':
arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration]
481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) {
| ^~~~~~~~~~~~~~~
arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function)
231 | .start = IXP4XX_UART1_BASE_PHYS,
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init':
arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration]
376 | ixp4xx_sys_init();
| ^~~~~~~~~~~~~~~
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: soc@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-ixp4xx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig
index bf14d65120b9..34a1c7742088 100644
--- a/arch/arm/mach-ixp4xx/Kconfig
+++ b/arch/arm/mach-ixp4xx/Kconfig
@@ -91,6 +91,7 @@ config MACH_IXDP465
config MACH_GORAMO_MLR
bool "GORAMO Multi Link Router"
+ depends on IXP4XX_PCI_LEGACY
help
Say 'Y' here if you want your kernel to support GORAMO
MultiLink router.
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver
2021-07-21 15:16 [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver Arnd Bergmann
@ 2021-07-21 15:16 ` Arnd Bergmann
2021-07-21 20:25 ` Linus Walleij
2021-08-02 13:32 ` Arnd Bergmann
2 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2021-07-21 15:16 UTC (permalink / raw)
To: Linus Walleij
Cc: soc, Arnd Bergmann, Linus Walleij, Imre Kaloz, Krzysztof Halasa,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When this driver is disabled, the board file fails to build,
so add a dependency:
arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit':
arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration]
472 | ixp4xx_pci_preinit();
| ^~~~~~~~~~~~~~~~~~
| iop3xx_pci_preinit
arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit':
arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration]
481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) {
| ^~~~~~~~~~~~~~~
arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function)
231 | .start = IXP4XX_UART1_BASE_PHYS,
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init':
arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration]
376 | ixp4xx_sys_init();
| ^~~~~~~~~~~~~~~
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: soc@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-ixp4xx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig
index bf14d65120b9..34a1c7742088 100644
--- a/arch/arm/mach-ixp4xx/Kconfig
+++ b/arch/arm/mach-ixp4xx/Kconfig
@@ -91,6 +91,7 @@ config MACH_IXDP465
config MACH_GORAMO_MLR
bool "GORAMO Multi Link Router"
+ depends on IXP4XX_PCI_LEGACY
help
Say 'Y' here if you want your kernel to support GORAMO
MultiLink router.
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver
2021-07-21 15:16 [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver Arnd Bergmann
2021-07-21 15:16 ` Arnd Bergmann
@ 2021-07-21 20:25 ` Linus Walleij
2021-07-21 20:25 ` Linus Walleij
2021-07-21 20:25 ` Linus Walleij
2021-08-02 13:32 ` Arnd Bergmann
2 siblings, 2 replies; 7+ messages in thread
From: Linus Walleij @ 2021-07-21 20:25 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, SoC Team, Arnd Bergmann, Imre Kaloz,
Krzysztof Halasa, Linux ARM, linux-kernel
On Wed, Jul 21, 2021 at 5:16 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When this driver is disabled, the board file fails to build,
> so add a dependency:
>
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration]
> 472 | ixp4xx_pci_preinit();
> | ^~~~~~~~~~~~~~~~~~
> | iop3xx_pci_preinit
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration]
> 481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) {
> | ^~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function)
> 231 | .start = IXP4XX_UART1_BASE_PHYS,
> | ^~~~~~~~~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init':
> arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration]
> 376 | ixp4xx_sys_init();
> | ^~~~~~~~~~~~~~~
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: soc@kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Ooops
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver
2021-07-21 20:25 ` Linus Walleij
@ 2021-07-21 20:25 ` Linus Walleij
2021-07-21 20:25 ` Linus Walleij
1 sibling, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-07-21 20:25 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, SoC Team, Arnd Bergmann, Imre Kaloz,
Krzysztof Halasa, Linux ARM, linux-kernel
On Wed, Jul 21, 2021 at 5:16 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When this driver is disabled, the board file fails to build,
> so add a dependency:
>
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration]
> 472 | ixp4xx_pci_preinit();
> | ^~~~~~~~~~~~~~~~~~
> | iop3xx_pci_preinit
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration]
> 481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) {
> | ^~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function)
> 231 | .start = IXP4XX_UART1_BASE_PHYS,
> | ^~~~~~~~~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init':
> arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration]
> 376 | ixp4xx_sys_init();
> | ^~~~~~~~~~~~~~~
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: soc@kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Ooops
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver
2021-07-21 20:25 ` Linus Walleij
2021-07-21 20:25 ` Linus Walleij
@ 2021-07-21 20:25 ` Linus Walleij
1 sibling, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-07-21 20:25 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, SoC Team, Arnd Bergmann, Imre Kaloz,
Krzysztof Halasa, Linux ARM, linux-kernel
On Wed, Jul 21, 2021 at 5:16 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When this driver is disabled, the board file fails to build,
> so add a dependency:
>
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration]
> 472 | ixp4xx_pci_preinit();
> | ^~~~~~~~~~~~~~~~~~
> | iop3xx_pci_preinit
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration]
> 481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) {
> | ^~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function)
> 231 | .start = IXP4XX_UART1_BASE_PHYS,
> | ^~~~~~~~~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init':
> arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration]
> 376 | ixp4xx_sys_init();
> | ^~~~~~~~~~~~~~~
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: soc@kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Ooops
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver
2021-07-21 15:16 [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver Arnd Bergmann
2021-07-21 15:16 ` Arnd Bergmann
2021-07-21 20:25 ` Linus Walleij
@ 2021-08-02 13:32 ` Arnd Bergmann
2021-08-02 13:32 ` Arnd Bergmann
2 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2021-08-02 13:32 UTC (permalink / raw)
To: Linus Walleij, Arnd Bergmann
Cc: Arnd Bergmann, linux-kernel, Krzysztof Halasa, soc,
linux-arm-kernel, Imre Kaloz, Linus Walleij
From: Arnd Bergmann <arnd@arndb.de>
On Wed, 21 Jul 2021 17:16:04 +0200, Arnd Bergmann wrote:
> When this driver is disabled, the board file fails to build,
> so add a dependency:
>
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration]
> 472 | ixp4xx_pci_preinit();
> | ^~~~~~~~~~~~~~~~~~
> | iop3xx_pci_preinit
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration]
> 481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) {
> | ^~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function)
> 231 | .start = IXP4XX_UART1_BASE_PHYS,
> | ^~~~~~~~~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init':
> arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration]
> 376 | ixp4xx_sys_init();
> | ^~~~~~~~~~~~~~~
Applied to arm/fixes, thanks!
[1/1] ARM: ixp4xx: goramo_mlr depends on old PCI driver
commit: 796a8c85b1216618258e08b463d3bef0d7123760
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver
2021-08-02 13:32 ` Arnd Bergmann
@ 2021-08-02 13:32 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2021-08-02 13:32 UTC (permalink / raw)
To: Linus Walleij, Arnd Bergmann
Cc: Arnd Bergmann, linux-kernel, Krzysztof Halasa, soc,
linux-arm-kernel, Imre Kaloz, Linus Walleij
From: Arnd Bergmann <arnd@arndb.de>
On Wed, 21 Jul 2021 17:16:04 +0200, Arnd Bergmann wrote:
> When this driver is disabled, the board file fails to build,
> so add a dependency:
>
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration]
> 472 | ixp4xx_pci_preinit();
> | ^~~~~~~~~~~~~~~~~~
> | iop3xx_pci_preinit
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit':
> arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration]
> 481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) {
> | ^~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function)
> 231 | .start = IXP4XX_UART1_BASE_PHYS,
> | ^~~~~~~~~~~~~~~~~~~~~~
> arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init':
> arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration]
> 376 | ixp4xx_sys_init();
> | ^~~~~~~~~~~~~~~
Applied to arm/fixes, thanks!
[1/1] ARM: ixp4xx: goramo_mlr depends on old PCI driver
commit: 796a8c85b1216618258e08b463d3bef0d7123760
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-02 13:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 15:16 [PATCH] ARM: ixp4xx: goramo_mlr depends on old PCI driver Arnd Bergmann
2021-07-21 15:16 ` Arnd Bergmann
2021-07-21 20:25 ` Linus Walleij
2021-07-21 20:25 ` Linus Walleij
2021-07-21 20:25 ` Linus Walleij
2021-08-02 13:32 ` Arnd Bergmann
2021-08-02 13:32 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).