From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E66FC433F5 for ; Wed, 6 Oct 2021 09:43:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0088561042 for ; Wed, 6 Oct 2021 09:43:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0088561042 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qdEPtA/qnJ77Pe2JeyDmLMnGlP6z5EHaAhh4W40FCyg=; b=SawW9949jjnt3c TX+mUlGUeq+wfNZjLuxk+92srzTBAJurTm4uMYyWd3cFD48y1mV338BHdFWt7kG90LdipoDkdj5t2 RDYtn5UZ6zSfCBF+6nMIWtwYExOIN/gEICblvxKmSaQJuI/H5gpd6m9ymdp8dIOk2etY1NrmVkONh 37Id+syliU5RN2RlUdWgUtMsod8c/euEUk2A4EZaf/sgsHxE0Ves3/g4T933ulnnAPTpqzPufW0Rn rJn8+zBLvFC8T7XBPiJuO6GLr0VNWQTWjptyxN0+X+MMpdastXknldhVAcStoli0Ht5TsDlNxSF7a sAKFamP1am0N2YJA9wnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY3Qi-00DeSH-Nk; Wed, 06 Oct 2021 09:41:40 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY3Qf-00DeRH-4H for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 09:41:38 +0000 Received: from mail-wr1-f52.google.com ([209.85.221.52]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MIdW9-1mb3Zz42sv-00EZyq for ; Wed, 06 Oct 2021 11:41:34 +0200 Received: by mail-wr1-f52.google.com with SMTP id r10so6879425wra.12 for ; Wed, 06 Oct 2021 02:41:34 -0700 (PDT) X-Gm-Message-State: AOAM533Nq1If439tKnPH6xjTUaUaCjn6pHmHqXzb3yI1EtCSdcehM2PA nwERd3RCV2eAmqxbBLLQUfs2CRHDTFB/u6c4Vgk= X-Google-Smtp-Source: ABdhPJzuUsHOXGfVTMW+P7qssYpQP5oaRsPeV3BXJdI5XYLdC7KWD9rwYpR6EFP3ZXNbb0wReeC/Muz0a9i/u3qzDE0= X-Received: by 2002:adf:ab46:: with SMTP id r6mr4566458wrc.71.1633513294130; Wed, 06 Oct 2021 02:41:34 -0700 (PDT) MIME-Version: 1.0 References: <20211005143748.2471647-1-pan@semihalf.com> <20211005143748.2471647-3-pan@semihalf.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 6 Oct 2021 11:41:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/4] dt-bindings: add bus number property To: =?UTF-8?Q?Pawe=C5=82_Anikiel?= List-Id: Cc: Alexandre Belloni , Arnd Bergmann , jarkko.nikula@linux.intel.com, Andy Shevchenko , Mika Westerberg , Rob Herring , Philipp Zabel , Olof Johansson , SoC Team , Dinh Nguyen , Pratyush Yadav , Tudor Ambarus , Linux I2C , Linux Kernel Mailing List , Sebastian Reichel , "Leizhen (ThunderTown)" , Jonathan Cameron , DTML , Linux ARM , Konrad Adamczyk , Tomasz Nowicki , Jacek Majkowski , Alexandru Stan X-Provags-ID: V03:K1:7aEF5fGfxvWvSYh6gWtfyTu1whUCp5puMARqA/ML+oJvK3xi3LF 7FyyyCQrJ1lfHcLmtGCHtb0zrxd/3j3pzMYGi8F11UIUniRI9NhfaIGOnOu77OJoPDDYr6a wawSYgJ8V87l1Do0kWGCPjc4IarMXaKO4UD6inTxdJ4bK4PTKGoVWQD4JraNrFKdWioU6NG CaqoLbYKGaFLYRD4uDWsg== X-UI-Out-Filterresults: notjunk:1;V03:K0:tGv7rAXP3pw=:Nv4b2cBxkWh5QsDLzfYKDY 6rwxJgj8XBOp6ZjBL5pjJUU3M7HyiP93COq+1j53EMYutWsy5bxcAb51xScpAGUSOC+XjKAgO cYXmvYFlC1LNOwk2SKvh0tziRUizpkuYr+PgUPEijBHKspsKP7PvF1TbhbUBxAyIbQfYSgPmf FD1hlddnTay5U9Sf8dNksb6Ujy7WkNs2JnJRXHymQ0TN6SbaoSbKAw7W8w9C6Cp2YitBCR1YN p0vD6apVZjzQKCvdAgTCIcNSTIUqiJbx55oWlVkwiFSTqx9FovP/FeRRJETKXNWmjlGC30cKV H7lCBivXnAFVAj8DXSqL82+Fz7oH7PWBdpPOOoHNaJJf4pdBdnNfjwml5/Rbh6c3U1iz6b+WO cCVFcr8KqgcYvEB1FIXDUOnmxSQHd65vFB7oeWsWyO+0oc5KGyKuczqp/SKD6bcf/j1UcdVZS 2ekbKjLbIzC4HUJ38bazq+9t4xQoPgCybEh5SGK3gxmmt9dbWpsfKLWe+42Vt2T912E4LcJLR xWKLIGLa0iweFh4Q4/arrsp58deQdb4u5s/VcQiqMpixqaFh5BKQgXie/YdEv7mKBRYJNdOuO ZyA7Y77W7gS3i3JPsUfIhaz07t08ORBst4QLngq9vmKM8arwhZ5hvlzI+Q4wD02yCsRSex/4G zZFtP72dSvmM1PybwL2nmAVsLPgnabuUntGc/YPMaL0m1888HmKuKS8LVIY1clDiXOpx9bFhd ushF55Oma8giLJPngKFP0/SiITzUU5VKXTaE0w== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_024137_486237_76199F02 X-CRM114-Status: GOOD ( 24.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20211006094117.AQee7MSq4c78svBS2Xfh4K4zh5TGQHOfUAbB4byqcCc@z> T24gV2VkLCBPY3QgNiwgMjAyMSBhdCAxMToyMSBBTSBQYXdlxYIgQW5pa2llbCA8cGFuQHNlbWlo YWxmLmNvbT4gd3JvdGU6Cj4gT24gVHVlLCBPY3QgNSwgMjAyMSBhdCA2OjI4IFBNIEFsZXhhbmRy ZSBCZWxsb25pIDxhbGV4YW5kcmUuYmVsbG9uaUBib290bGluLmNvbT4gd3JvdGU6Cj4+Cj4+IFdo YXQgaGFwcGVucyB3aGVuIHR3byBub2RlcyBoYXZlIHRoZSBzYW1lIGJ1c25vIHByb3BlcnR5IGJl Y2F1c2UgZS5nLgo+PiBvbmUgaXMgaW4gYSBkdHNpIGFuZCB0aGUgb3RoZXIgb25lIGlzIGluIGEg ZHRzPwo+Cj4KPiBJZiBidXNubyBpcyBzZXQsIHRoZSBhbGlhcyBpcyBpZ25vcmVkICh0aGUgY29k ZSB0aGF0IGNoZWNrcyBhbGlhc2VzCj4gaXMgbmV2ZXIgcmVhY2hlZCkuIElmIHR3byBub2RlcyBo YXZlIHRoZSBzYW1lIGJ1c25vIHByb3BlcnR5LCB3ZSBnZXQKPiBhIFdBUk4gaW4gZHJpdmVycy9p MmMvaTJjLWNvcmUtYmFzZS5jOjE2MzcsIGFuZCBvbmx5IG9uIG9mIHRoZW0KPiBnZXRzIGF0dGFj aGVkLgo+Cj4gV2hhdCBpcyBhIGJldHRlciB3YXkgb2YgZG9pbmcgdGhpcyB0aGVuPyBJcyBhZGRp bmcgYWxpYXNlcyB0byB0aGUKPiBkZXZpY2V0cmVlIGxpa2UgdGhpcyBva2F5Pwo+Cj4gYWxpYXNl cyB7Cj4gLi4uCj4gaTJjMCA9ICZpMmMwOwo+IGkyYzEgPSAmaTJjMTsKPiB9OwoKWWVzLCB0aGlz IGlzIHRoZSBub3JtYWwgd2F5IHRvIGRvIGl0LgoKVGhlIHdheSBJIHRlbmQgdG8gdGhpbmsgb2Yg aXQgaXMgdGhhdCB0aGUgc29jLmR0c2kgZmlsZSBjb250YWlucyBhIGRlc2NyaXB0aW9uCm9mIGhh cmR3YXJlIHRoYXQgZXhpc3RzIGluc2lkZSBvZiB0aGUgY2hpcCBhbmQgaXMgYXMgbXVjaCBhcyBw b3NzaWJsZQpkZXRhY2hlZCBmcm9tIGhvdyBhbiBPUyB1c2VzIGl0IG9yIHdoYXQgaXMgY29ubmVj dGVkIHRvIGl0IG9uIHRoZQpvdXRzaWRlLiBZb3UgdGhlbiBoYXZlIHRoZSBib2FyZC5kdHMgZmls ZSB0aGF0IGNvbnRhaW5zIGV2ZXJ5dGhpbmcgc3BlY2lmaWMKdG8gdGhlIGJvYXJkLgoKVGhlIC9j aG9zZW4gYW5kIC9hbGlhc2VzIG5vZGVzIGluIHR1cm4gYXJlIHNwZWNpZmljIHRvIHRoZSBpbmRp dmlkdWFsCm1hY2hpbmUsIGJhc2VkIG9uIGxvY2FsIGNvbmZpZ3VyYXRpb24sIGluc3RhbGxlZCBP UyBhbmQgYm9vdCBsb2FkZXIsCmFuZCBob3cgdGhlIGRldmljZXMgb24gdGhlIGJvYXJkIGFyZSB1 c2VkLgoKV2UgdGVuZCB0byBoYXZlIHRoZSAvYWxpYXNlcyBub2RlIHBvcHVsYXRlZCB3aXRoIGEg c2Vuc2libGUgY29uZmlndXJhdGlvbgpvZiBob3cgd2UgZXhwZWN0IHRoZW0gdG8gYmUgdXNlZCBm b3IgYSBnaXZlbiBib2FyZC4gU28gaWYgeW91ciBtYWNoaW5lCmNvbm5lY3RzIHR3byBvZiB0aGUg aW50ZXJuYWwgaTJjIGJ1c2VzIG9uIHRoZSBTb0MsIGl0IG1ha2VzIHNlbnNlIHRvIGFzc2lnbgp0 aGVtIHRoZSBhbGlhc2VzIGkyYzAgYW5kIGkyYzEuIE9uIHRoZSBvdGhlciBoYW5kLCBpZiBvbmUg b2YgdGhlbSBpcwpub3QgY29ubmVjdGVkIGFueXdoZXJlLCB5b3UgbWF5IHNraXAgdGhhdCwgb3Ig aWYgdGhlcmUgaXMgYW4gYWRkaXRpb25hbAppMmMgY29udHJvbGxlciBpbiBwcm9ncmFtbWFibGUg bG9naWMgb3IgYmVoaW5kIHNvbWUgZ3BpbyBsaW5lcywgeW91IGNhbgptYWtlIHRoYXQgeW91ciBp MmMwIGFsaWFzLgoKICAgICAgQXJuZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA53EC433FE for ; Wed, 6 Oct 2021 09:41:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B25486103D for ; Wed, 6 Oct 2021 09:41:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237676AbhJFJn2 convert rfc822-to-8bit (ORCPT ); Wed, 6 Oct 2021 05:43:28 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:36949 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231240AbhJFJn1 (ORCPT ); Wed, 6 Oct 2021 05:43:27 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MQ5aw-1mC0J42QfA-00M4xv; Wed, 06 Oct 2021 11:41:34 +0200 Received: by mail-wr1-f42.google.com with SMTP id k7so6810786wrd.13; Wed, 06 Oct 2021 02:41:34 -0700 (PDT) X-Gm-Message-State: AOAM530u/ownZuuA3zVDh3d2oiuLzMmnMLEJ2x6vQP8VdxU3JEqBkcS+ RVtw8ha/X5+c17u1nQ3WcnBMVUSM4HUVci8Mdr0= X-Google-Smtp-Source: ABdhPJzuUsHOXGfVTMW+P7qssYpQP5oaRsPeV3BXJdI5XYLdC7KWD9rwYpR6EFP3ZXNbb0wReeC/Muz0a9i/u3qzDE0= X-Received: by 2002:adf:ab46:: with SMTP id r6mr4566458wrc.71.1633513294130; Wed, 06 Oct 2021 02:41:34 -0700 (PDT) MIME-Version: 1.0 References: <20211005143748.2471647-1-pan@semihalf.com> <20211005143748.2471647-3-pan@semihalf.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 6 Oct 2021 11:41:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/4] dt-bindings: add bus number property To: =?UTF-8?Q?Pawe=C5=82_Anikiel?= List-Id: Cc: Alexandre Belloni , Arnd Bergmann , jarkko.nikula@linux.intel.com, Andy Shevchenko , Mika Westerberg , Rob Herring , Philipp Zabel , Olof Johansson , SoC Team , Dinh Nguyen , Pratyush Yadav , Tudor Ambarus , Linux I2C , Linux Kernel Mailing List , Sebastian Reichel , "Leizhen (ThunderTown)" , Jonathan Cameron , DTML , Linux ARM , Konrad Adamczyk , Tomasz Nowicki , Jacek Majkowski , Alexandru Stan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:caADEqYTCLfH+k3Y7hPGJn6G9RJraNCHQm1NIlSbgN8T0jbYhbA 7nVXwb3WV3+p9IdemOCH+KkPRvtdrAwzE020vJmV8MKkATQGHhUUpxJBzRhrV48ZfJWjzWs ia1D1VgZM+nDRNwnB3Mzr6jwdqRc1PdEpTyGss1od/qqwa3pVfRLltpy1WV41qggFpjkxfM uWhxGFtjjSmXdTvLM5DJQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:I2PFHYwSZdE=:aihFdij185WnWvcVUAaHfO xnVrmDc/jQxCptzbEScEXqi1kHN0SXlUTwCvlWP4gJFn1upEWOUBSX41C8ij7xPQ0VyDyZbbV k4UM/SGFppTKWJ6PNf5jqUXH7HnwrIqJwqU58VSaFt9Xae9iK2KPR4W1D9gHvPd3um9PDTELD s/gbM8u3NW+hctJ8w4Lfocp8J25colOuvSzYeHrg3U53P70GoROaWrRkyxN8SQWtZ/c83KR45 V40DR/iqNa+yKXDgtFvnuEO+M7UoMhZR0kjpFas/Gx8xEEUL8Q8ncXQxuzUfyyhasJRe5MC4i V6zqCkRzRpfPMvoa94h61UBuqVXWSx4vif7l3rFes7/e9mur+YFkalzKBEDgmY6MuJi+KBXOL ZqPmCp+41rf43HBrbFWYNPa3duk+7YXsEJA1DLgvImo4kCN+ZGDe4iyp+QmyHQpGPjCDcT0wa wQUf6vaQ0ydS1cKzaxPY0aqJwa2FyIgJZJ7v0NGycb57pUuJgJNIEU1feZLydOybq5CIGBuDr IPt1be1PKIAr3Q+9S4K0A7mf+HInfqO6/1ufUA/aLhGourTSDci+DK7XeWPwtPGC12pSAIvnA JLtHoHg1mzn0kQEI7QKJQna68Whn3WejZmFSu6fXC7s9npwyityizSCXN9pqigZCiQwZe8CS3 TUHQRs3+IuMpVS2YOT1cOPEQGRnwQ2ZBE7981v5im3GZbjw2e3S3DKNb8q+p3ClCLec0aXZzk xgQ0c1ZZaDjN8iyxAGrpF8PQ8LOKaNqlPVR3JWC7BE8G5/g/QDKTf60hJ1PGlaCPhn91mOtYw a16EVR7GqmssxpDiWTYkyP1wvAH1DoX4LMnpTKyfglDt3JB0OSO70+bYoYIm7AjJntY9jmxXG a85WgBFu0+TQRbP+XR5Q== Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Message-ID: <20211006094117.S6X1NUWDrYweIRnEUHLJPjJiwuW72BYYghVvL7Gmf-0@z> On Wed, Oct 6, 2021 at 11:21 AM Paweł Anikiel wrote: > On Tue, Oct 5, 2021 at 6:28 PM Alexandre Belloni wrote: >> >> What happens when two nodes have the same busno property because e.g. >> one is in a dtsi and the other one is in a dts? > > > If busno is set, the alias is ignored (the code that checks aliases > is never reached). If two nodes have the same busno property, we get > a WARN in drivers/i2c/i2c-core-base.c:1637, and only on of them > gets attached. > > What is a better way of doing this then? Is adding aliases to the > devicetree like this okay? > > aliases { > ... > i2c0 = &i2c0; > i2c1 = &i2c1; > }; Yes, this is the normal way to do it. The way I tend to think of it is that the soc.dtsi file contains a description of hardware that exists inside of the chip and is as much as possible detached from how an OS uses it or what is connected to it on the outside. You then have the board.dts file that contains everything specific to the board. The /chosen and /aliases nodes in turn are specific to the individual machine, based on local configuration, installed OS and boot loader, and how the devices on the board are used. We tend to have the /aliases node populated with a sensible configuration of how we expect them to be used for a given board. So if your machine connects two of the internal i2c buses on the SoC, it makes sense to assign them the aliases i2c0 and i2c1. On the other hand, if one of them is not connected anywhere, you may skip that, or if there is an additional i2c controller in programmable logic or behind some gpio lines, you can make that your i2c0 alias. Arnd