From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E30C48BC2 for ; Fri, 25 Jun 2021 18:43:21 +0000 (UTC) Received: by mail.kernel.org (Postfix) id 862BD61878; Fri, 25 Jun 2021 18:43:21 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D016460FDB; Fri, 25 Jun 2021 18:43:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D016460FDB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=arnd@arndb.de Received: from mail-wr1-f44.google.com ([209.85.221.44]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MGQax-1m2cVG0tQL-00Gs75; Fri, 25 Jun 2021 20:43:19 +0200 Received: by mail-wr1-f44.google.com with SMTP id g7so6997825wri.7; Fri, 25 Jun 2021 11:43:19 -0700 (PDT) X-Gm-Message-State: AOAM532nd1V04bWUM52VOUrt2/vT4aIavYUrEnIiLIkvAbmdzWDlJ20G gQsJ22uBXSJspiNXYoGXgXsF/XlisoVYHJzJIJM= X-Google-Smtp-Source: ABdhPJwEXB6pH4EHQ72kI8pnEN58pZxj/e6S9sYcBbs1qDXwS2ssmZPovadGPW6KqNN5AXcIRA/EzxF4GTRTCN5h100= X-Received: by 2002:a5d:5905:: with SMTP id v5mr13106064wrd.361.1624646598834; Fri, 25 Jun 2021 11:43:18 -0700 (PDT) MIME-Version: 1.0 References: <20210625095000.3358973-1-mnhagan88@gmail.com> <20210625095000.3358973-3-mnhagan88@gmail.com> <21e895e9-0211-0c97-5e9e-781e6d2fe6dd@gmail.com> In-Reply-To: <21e895e9-0211-0c97-5e9e-781e6d2fe6dd@gmail.com> From: Arnd Bergmann Date: Fri, 25 Jun 2021 20:40:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series To: Florian Fainelli List-Id: Cc: Matthew Hagan , Vladimir Oltean , Rob Herring , Olof Johansson , SoC Team , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Viresh Kumar , Sam Ravnborg , Geert Uytterhoeven , DTML , Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:d4zABLmXnnVOes83YaBXXGE6gK364bunBG+hJ9PbFx/hU6tj0cp s0f7J+iOhyjO+RbyfdAowoiskJKufAKM3OX6UQJQxoYtyHtcIgfl3v/+GucRVpS31suUhlP T0Pc5sTUOv2DMBFQsJ1ATPQo9Y94xOQQ7xe/ezuvaXQeae3FZPRksKujaYvlQlMIUxzvZIo osszY3fyHZb4N3X4lngxQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:7P1IXlhUYIk=:2ZKao+iL21wfGUsqQgtdmJ /JTbNxHUZ3RwH6KJhozHcahGxsBDLG7X9blzs1kBRxZIessoHDFaEznREI0Ge/emC6CSuk6m8 Npmz1pBo9cgU5YL009lqRX13i9weXBHDTBwjeZ9TVxODkE0TW1irHreqgfEHUJptXZ500zbmw JaqcJjOhKPe8B/riXb5q+eh7yKgfyzB+vxAvzp52/nYze/jKraOIdii+nLyg6/m9RawI0SNHr HfJ7ou143yfuwwWMxNPx0WbogdjXfYMUl6M2Ts+cnnOLskLRf6A2cpORTXS8pq6JcqMNG4qWK Nk+014ccY0MLoR6u7mUxFBLc0ag4mZxa6qxpfm/DZFvjOIideU/urIjPIWAX/4vBNuvSL8abq 08qtHnF7deYtKrlCtwpIRZoxd5UHkHb5KkASmOROL0fcEnwxb0xHd3Dzrujnt7X9mlXrpGxh2 FIwZdkFjLP5LNLggdgMUrnXQi5NwEXBa01zE0rzxLnrXrZ58p0/ORXk51FTq5QSPMo65BTcNU 5R8y08VNLf28ZlGi4c/SJEt4Ervta3h902FwGcJkVLzKOcYCitBlQm9o1MbiW0UyNYouOE8mQ jT+i1Fv6chE6vmzWnKQbxzWhWTPhJZ4+dOs9mcEtqK+mC93pUQuyQxTUd/JgArgRmX7JIJts2 S02wcPiPZzFdejg0vtT0HmmQIEYihjv76vGi478gX1DVTmhSc3DA6WfXcjKCUUg3CpsuFz541 oJl5zDMhXq1Sek0xyd6qKWhXriOjZdt6ybjdArYdtXokKvdNbniSxv4fyrKXi6vl8v6r2TVV3 cz0TLwgvv518zVaYvBCJOOoHz0dbaomPrGaTHa183b/vNBcHcywKd5pUcGf/OzCQd91d8Dc On Fri, Jun 25, 2021 at 7:30 PM Florian Fainelli wrote: > On 6/25/21 10:26 AM, Matthew Hagan wrote: > > On 25/06/2021 10:59, Arnd Bergmann wrote: > > > > How about having separate bcm-nsp-ax and bcm-nsp-bx dtsi files with the > > appropriate secondary-boot-reg and dma-coherent (or lack of) > > properties, which then include bcm-nsp.dtsi. Thus we can also avoid use > > of /delete-property/. Would this be preferable? That sounds good to me. > Is there any way that the Ax platforms could use a small shim between > the boot loader and the kernel which could all of the necessary DT > adaptation so the kernel only contains a single Device Tree source? > > Using something like this: > > https://github.com/zonque/pxa-impedance-matcher/ > > could be useful. I don't think that's necessary here, but I wouldn't object if someone finds it useful and does the work. ;-) > >> On the other hand, the /chosen, /aliases and /memory nodes that you have > >> in the .dtsi file should probably get moved into the .dts files, as these tend > >> to be board specific settings, even if the examples you have are all > >> the same. > > > > I did not come across any convention regarding this, though there are > > plenty of cases where the /chosen, /aliases and /memory nodes are > > defined in a .dtsi file and used by multiple similar boards. Also note > > in this case /aliases is defined in bcm-nsp.dtsi, not by me. Would we > > not prefer to avoid having 6x duplication? We are not too consistent about this, and there are cases in which a .dtsi file is used for a family of boards using different SoCs rather than a particular SoC or SoC family. In the bcm-nsp.dtsi example you mention, I would move the aliases into the board files, mainly because there is no guarantee that each board exposes both uarts and all three on-chip ethernet ports. Note that the aliases are supposed to match whatever label you have on the board, not what the numbers are in the chip. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE76C2B9F4 for ; Fri, 25 Jun 2021 18:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B937E60FDB for ; Fri, 25 Jun 2021 18:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbhFYSpl (ORCPT ); Fri, 25 Jun 2021 14:45:41 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:35713 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbhFYSpl (ORCPT ); Fri, 25 Jun 2021 14:45:41 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N3suW-1lF1aJ0tbE-00zlsI; Fri, 25 Jun 2021 20:43:19 +0200 Received: by mail-wr1-f52.google.com with SMTP id m18so11617254wrv.2; Fri, 25 Jun 2021 11:43:19 -0700 (PDT) X-Gm-Message-State: AOAM530m5TLzHZNPkEwTP8ApghGu7WLoOqZ8FvvjVHtz7n8yKZPmHw6n RhxTgQT9ZDY38J65QlH3yTeU7AMzjDVLK1zYL8w= X-Google-Smtp-Source: ABdhPJwEXB6pH4EHQ72kI8pnEN58pZxj/e6S9sYcBbs1qDXwS2ssmZPovadGPW6KqNN5AXcIRA/EzxF4GTRTCN5h100= X-Received: by 2002:a5d:5905:: with SMTP id v5mr13106064wrd.361.1624646598834; Fri, 25 Jun 2021 11:43:18 -0700 (PDT) MIME-Version: 1.0 References: <20210625095000.3358973-1-mnhagan88@gmail.com> <20210625095000.3358973-3-mnhagan88@gmail.com> <21e895e9-0211-0c97-5e9e-781e6d2fe6dd@gmail.com> In-Reply-To: <21e895e9-0211-0c97-5e9e-781e6d2fe6dd@gmail.com> From: Arnd Bergmann Date: Fri, 25 Jun 2021 20:40:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series To: Florian Fainelli List-Id: Cc: Matthew Hagan , Vladimir Oltean , Rob Herring , Olof Johansson , SoC Team , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Viresh Kumar , Sam Ravnborg , Geert Uytterhoeven , DTML , Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Wwf001wfvj2NayxiGf2rtnUg6jjwTI76fEJgg6BbVYd8EX6Bu89 oR7a/hkMSpIyk+MhHFAGY/Mk512mQcOhVPze3K/U49r8RbvIc6BCx2FiO2c3oXxtkXxyOfn WDe5WI7IWdOqw8+rjkKMLNWLqGBUCMNvFRcvjywt893URrUIwO0gLbb0efaw/u9cqsqdWeV PFhHp4gSflJPE9ArlXelw== X-UI-Out-Filterresults: notjunk:1;V03:K0:TZjQyzO/aP0=:13PJSEf0CNg7aKG35AZgBV 4vemKE1HqUHPX8Cj+fil9wrsK6VpEZUWmwSi2aY43maSZZ+ugWBPIheER2YpAtI0Uu9sVm0ts jAiXE2cet0iN9meACkIaKDhDzT1vETPmZsmfWGCcQAW90ln1OBEtZEtUEeFuGqtdUO7G/jDUN uf4k7oPOCppPj+W/fnCq+W11hvWnXIIGs7vlbedkUntCAvr/ogZnnym6cuwhjfHbJgjEdSQlo s6RH7VQsGWryhGiKg5l1sVYYZDpOn9SxusyyYJ4CRcY0Boef6M66YuaaQJWSzzO/5qqHsXka4 GILrMs0lOWWTalrkqlNemwO834my0bhWXSjG+R2MtFmglF1lnSY5UXqwaLr3kNDWQTT6RIP5S MZUcg5xHrZ43iPesOxO9IrCoyU5wxsp1fwi4d1QwnxQbedxsi/t84iOnsMOJY1gPnlB2DPbvh hiiFw5ezN/FDcLYWGRg7boBMxwS7E8NBqkpEPYqj4QGvlpa/E8Zj/E8+uUGiSU+GkQcWJ3FPd MfPLOqYXqXTYSUpKECVXg+j9Z3feN23+5k8z0yfZDalQiKNovULHPey8MmDoHDCyF8QAUV+EZ +xWUagkU/InVHLyr69MFsLXZTnZO6YivTR4izETxCeEH1PrBEPzQ1T2UmRIfD6DHVcCpSNwGi v2xU= Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Message-ID: <20210625184053.90LoYO-66Or60rS519Ryxnhx7a96RlHW653nqbF80Vs@z> On Fri, Jun 25, 2021 at 7:30 PM Florian Fainelli wrote: > On 6/25/21 10:26 AM, Matthew Hagan wrote: > > On 25/06/2021 10:59, Arnd Bergmann wrote: > > > > How about having separate bcm-nsp-ax and bcm-nsp-bx dtsi files with the > > appropriate secondary-boot-reg and dma-coherent (or lack of) > > properties, which then include bcm-nsp.dtsi. Thus we can also avoid use > > of /delete-property/. Would this be preferable? That sounds good to me. > Is there any way that the Ax platforms could use a small shim between > the boot loader and the kernel which could all of the necessary DT > adaptation so the kernel only contains a single Device Tree source? > > Using something like this: > > https://github.com/zonque/pxa-impedance-matcher/ > > could be useful. I don't think that's necessary here, but I wouldn't object if someone finds it useful and does the work. ;-) > >> On the other hand, the /chosen, /aliases and /memory nodes that you have > >> in the .dtsi file should probably get moved into the .dts files, as these tend > >> to be board specific settings, even if the examples you have are all > >> the same. > > > > I did not come across any convention regarding this, though there are > > plenty of cases where the /chosen, /aliases and /memory nodes are > > defined in a .dtsi file and used by multiple similar boards. Also note > > in this case /aliases is defined in bcm-nsp.dtsi, not by me. Would we > > not prefer to avoid having 6x duplication? We are not too consistent about this, and there are cases in which a .dtsi file is used for a family of boards using different SoCs rather than a particular SoC or SoC family. In the bcm-nsp.dtsi example you mention, I would move the aliases into the board files, mainly because there is no guarantee that each board exposes both uarts and all three on-chip ethernet ports. Note that the aliases are supposed to match whatever label you have on the board, not what the numbers are in the chip. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8679CC2B9F4 for ; Fri, 25 Jun 2021 18:44:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E38F61949 for ; Fri, 25 Jun 2021 18:44:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E38F61949 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/hwPAZmaQw+oRQS/P2bEi0EElBNdy1Nn6TF9lBy0DuQ=; b=sT48aUIV+DFPOk IS50m5oasJ3kr34IUZhGrntcVJX5oaVDQVIsS5xclyrGYIzKkEZfatF8lJOdrKFhBm6GqP9HP60QG NasJ4hKXBnl7/yPn+vqUbh+58LOC6F3JnolZsum3+JRUT5Mxsu46uxVt4FSiYPDzfmDFfqPsgTtxV kaAXnRhXy/vUKHc+tXWe3OwlBsu3+HrvnlnCxqV0hk9jWutzHLu4wgRjZQDFAMIczu/n6bWtc22qO onApC1rq7Qx8VUy600mEci3YuWI+qmJZl0bCS2g0CjS08zhH2EQ9WxgFiuxby67HxSvxnzMlUU80d te0ze0XQ0aZLZYuGSaKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwqnX-002bFk-Fk; Fri, 25 Jun 2021 18:43:27 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwqnT-002bEr-EG for linux-arm-kernel@lists.infradead.org; Fri, 25 Jun 2021 18:43:25 +0000 Received: from mail-wr1-f51.google.com ([209.85.221.51]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N6sON-1lBTcO1DJv-018HYs for ; Fri, 25 Jun 2021 20:43:19 +0200 Received: by mail-wr1-f51.google.com with SMTP id i94so11648413wri.4 for ; Fri, 25 Jun 2021 11:43:19 -0700 (PDT) X-Gm-Message-State: AOAM531J3ntLA2ggUlfT9YW/vTLXsjjc5wBBGdAeTrvzy7DWHkJw5/WC aMDiV50tA21Q46IkQ79Kxr/mHugWKz07YY3jvNI= X-Google-Smtp-Source: ABdhPJwEXB6pH4EHQ72kI8pnEN58pZxj/e6S9sYcBbs1qDXwS2ssmZPovadGPW6KqNN5AXcIRA/EzxF4GTRTCN5h100= X-Received: by 2002:a5d:5905:: with SMTP id v5mr13106064wrd.361.1624646598834; Fri, 25 Jun 2021 11:43:18 -0700 (PDT) MIME-Version: 1.0 References: <20210625095000.3358973-1-mnhagan88@gmail.com> <20210625095000.3358973-3-mnhagan88@gmail.com> <21e895e9-0211-0c97-5e9e-781e6d2fe6dd@gmail.com> In-Reply-To: <21e895e9-0211-0c97-5e9e-781e6d2fe6dd@gmail.com> From: Arnd Bergmann Date: Fri, 25 Jun 2021 20:40:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series To: Florian Fainelli List-Id: Cc: Matthew Hagan , Vladimir Oltean , Rob Herring , Olof Johansson , SoC Team , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Viresh Kumar , Sam Ravnborg , Geert Uytterhoeven , DTML , Linux Kernel Mailing List , Linux ARM X-Provags-ID: V03:K1:/jXGN+N2lRZLlwLZjLF50h+vOQJdVhTSSxDi3B0Q42MlF+QjKwc nDLrVnMzFICESfTOWfVBaxThq1eFAoNgAx5gs/7qXNS+hAhPCH6T+HYs3R4Rh8oPt8igFWx 6UmaP/XXNsV6OHrcunEGGbu1p31mOKbNZH2Wh4tlhGVAP1D0gPdKeBcdjOq9e3+4Sddfj9e 5SbVf46KWL/ZNz1aZV4GQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:6/b2Ia1PJhg=:FOp/3IARlNwfRX2Zrpy/wi Cw6dqpfs+734zyicinrjiPsCKWD4mdjfW49FHyJs+vVzXHMFtH8eIFFXqDZP/jQzLzr3Y/goj xSHQpWeHvtMhFtEcD/ME7E0Q6FjY6C5yelrI7+9OVX3Pn0hPZUG/s7AUlbPrbNJhzScXXlLSe xn4W0ti4nReDEc5GMGJJ1gjII3Cjngf5eKkvsFUdzwXbm16lxZSoB9WPhpSQrlUSKPsmObibK qNz+Rz2F1PVEomKw/Hi0iyyqLOy+ESZmvmNpp1j2oyZcZThjGZOFEGERjLShRB62MLEgapdYI W0YKRP5YHn9FU9q68aimqJRHgza+RkszdLkI7IS0V/RrpyVKcvrI8umeYrSbVUa9KT+aQMc04 I2xeZeXZ+ih3044vergHjnVTxQEY+knvOCNXDLkxOb3o0ENfIguIb3tMTxT5W+UkqNvejc61F AjykHzSHL6FOQwdN+r6SEA14lH0WkKXYdRtgi1fW/ccKoy5sZlonnGiGwDIq8kK6enIAT+zrt 3k6x1o9Pi3aMBJ/hHUDC5pAS5hAqFuQ+iacnvcBHpx0CLnmq8y2QmR+t8Qrzcffmj44lAq/z4 No2a1nEE/ehY1YqRDZotsM+PEN6h1cRy/Wjk/mz68kB/YGfnGaSo4M+y3SLnZh/bYXQratmRb UgLWXBrnR7nPkRNsIYnXfTOlygo+btSiQU30sTBwTQ7tDmDeDYJmD4TIIe5bQ0jaj8N9JKy3N nVenPcjTtHi7/5Me6O8urBkeJ7fumJ/oob/9Fbx6xxQcFiG+etzwE44vGPe2Agcx8FchGO7bp DDwRoUQOjUJEpIysk4HF/T9e9gzIBfrB94x+JTX1dRVTQRbmd6vhgmWfWBw7VBVxKtLYbTRqD DsNYRzWgtbTm5iQIetcHmWC36wpDN/EnjiOjbdp2Ge4tbHlqkj+nyPjhwuQot81h6sxcWdxFK AMqDFqJOLMQ/0+ck+dncFmtvlu8ZUE8JluK3td50ihAYiaf39GFRY X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_114323_824054_BC12B207 X-CRM114-Status: GOOD ( 28.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20210625184053.wcagdd6m8mqVmq1GmR-I5oGdkqT1t2UzhqUCQMe3ULY@z> On Fri, Jun 25, 2021 at 7:30 PM Florian Fainelli wrote: > On 6/25/21 10:26 AM, Matthew Hagan wrote: > > On 25/06/2021 10:59, Arnd Bergmann wrote: > > > > How about having separate bcm-nsp-ax and bcm-nsp-bx dtsi files with the > > appropriate secondary-boot-reg and dma-coherent (or lack of) > > properties, which then include bcm-nsp.dtsi. Thus we can also avoid use > > of /delete-property/. Would this be preferable? That sounds good to me. > Is there any way that the Ax platforms could use a small shim between > the boot loader and the kernel which could all of the necessary DT > adaptation so the kernel only contains a single Device Tree source? > > Using something like this: > > https://github.com/zonque/pxa-impedance-matcher/ > > could be useful. I don't think that's necessary here, but I wouldn't object if someone finds it useful and does the work. ;-) > >> On the other hand, the /chosen, /aliases and /memory nodes that you have > >> in the .dtsi file should probably get moved into the .dts files, as these tend > >> to be board specific settings, even if the examples you have are all > >> the same. > > > > I did not come across any convention regarding this, though there are > > plenty of cases where the /chosen, /aliases and /memory nodes are > > defined in a .dtsi file and used by multiple similar boards. Also note > > in this case /aliases is defined in bcm-nsp.dtsi, not by me. Would we > > not prefer to avoid having 6x duplication? We are not too consistent about this, and there are cases in which a .dtsi file is used for a family of boards using different SoCs rather than a particular SoC or SoC family. In the bcm-nsp.dtsi example you mention, I would move the aliases into the board files, mainly because there is no guarantee that each board exposes both uarts and all three on-chip ethernet ports. Note that the aliases are supposed to match whatever label you have on the board, not what the numbers are in the chip. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel