From: Fabio Estevam <festevam@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>, Martin Kaiser <martin@kaiser.cx>
Cc: soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Andre Przywara <andre.przywara@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Viresh Kumar <vireshk@kernel.org>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-clk@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 05/13] ARM: imx: remove unused mx25_revision()
Date: Tue, 16 May 2023 20:34:01 -0300 [thread overview]
Message-ID: <CAOMZO5B0stW2X6YqPTTKDpCOAzPDvm=4HT8jfBAgbTy11gnKgg@mail.gmail.com> (raw)
In-Reply-To: <20230516153109.514251-6-arnd@kernel.org>
Hi Arnd,
On Tue, May 16, 2023 at 12:32 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function has no prototype and no callers:
>
> arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Martin Kaiser sent a patch adding a user for this function:
https://lore.kernel.org/linux-arm-kernel/20220815190748.102664-2-martin@kaiser.cx/
It would be better to apply Martin's patch instead of removing mx25_revision().
Thanks
next prev parent reply other threads:[~2023-05-16 23:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 15:30 [PATCH 00/13] ARM: SoC: address -Wmissing-prototype warnings Arnd Bergmann
2023-05-16 15:30 ` [PATCH 01/13] ARM: davinci: fix davinci_cpufreq_init() declaration Arnd Bergmann
2023-05-16 15:41 ` Bartosz Golaszewski
2023-05-16 15:30 ` [PATCH 02/13] ARM: ep93xx: fix missing-prototype warnings Arnd Bergmann
2023-05-16 15:51 ` Alexander Sverdlin
2023-05-16 15:30 ` [PATCH 03/13] ARM: highbank: add missing include Arnd Bergmann
2023-05-16 15:58 ` Andre Przywara
2023-05-16 15:31 ` [PATCH 04/13] ARM: imx: " Arnd Bergmann
2023-05-16 15:31 ` [PATCH 05/13] ARM: imx: remove unused mx25_revision() Arnd Bergmann
2023-05-16 23:34 ` Fabio Estevam [this message]
2023-05-17 6:39 ` Arnd Bergmann
2023-05-17 15:45 ` Martin Kaiser
2023-07-28 15:59 ` Arnd Bergmann
2023-07-30 16:26 ` Martin Kaiser
2023-05-16 15:31 ` [PATCH 06/13] ARM: lpc32xx: add missing include Arnd Bergmann
2023-05-23 20:17 ` Vladimir Zapolskiy
2023-05-16 15:31 ` [PATCH 07/13] ARM: omap1: " Arnd Bergmann
2023-05-16 23:18 ` Aaro Koskinen
2023-05-17 5:58 ` Tony Lindgren
2023-05-17 5:58 ` Tony Lindgren
2023-05-16 15:31 ` [PATCH 08/13] ARM: omap2: fix missing tick_broadcast() prototype Arnd Bergmann
2023-05-16 23:20 ` Aaro Koskinen
2023-05-16 15:31 ` [PATCH 09/13] ARM: orion5x: fix d2net gpio initialization Arnd Bergmann
2023-05-16 16:17 ` Andrew Lunn
2023-05-16 15:31 ` [PATCH 10/13] ARM: pxa: fix missing-prototypes warnings Arnd Bergmann
2023-05-18 20:10 ` Stephen Boyd
2023-05-28 11:46 ` Greg Kroah-Hartman
2023-05-16 15:31 ` [PATCH 11/13] ARM: sa1100: address missing prototype warnings Arnd Bergmann
2023-05-16 15:31 ` [PATCH 12/13] ARM: spear: include "pl080.h" for pl080_get_signal() prototype Arnd Bergmann
2023-05-17 4:34 ` Viresh Kumar
2023-05-16 15:31 ` [PATCH 13/13] ARM: versatile: mark mmc_status() static Arnd Bergmann
2023-05-26 11:50 ` [PATCH 00/13] ARM: SoC: address -Wmissing-prototype warnings patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5B0stW2X6YqPTTKDpCOAzPDvm=4HT8jfBAgbTy11gnKgg@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=alexander.sverdlin@gmail.com \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=jmkrzyszt@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=martin@kaiser.cx \
--cc=mturquette@baylibre.com \
--cc=robert.jarzmik@free.fr \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=sudeep.holla@arm.com \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).