soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR
@ 2021-07-21 23:26 Dmitry Osipenko
  2021-07-22 10:49 ` Jon Hunter
  2021-08-02 14:36 ` Thierry Reding
  0 siblings, 2 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2021-07-21 23:26 UTC (permalink / raw)
  To: Thierry Reding, Jonathan Hunter, Arnd Bergmann
  Cc: Mark Brown, soc, linux-kernel, linux-tegra

The regulator coupler drivers now use regulator-driver API function that
isn't available during compile-testing. Make regulator coupler drivers
dependent on CONFIG_REGULATOR in Kconfig.

Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---

Changelog:

v2: - No changes. Re-sending to Arnd Bergmann and soc@kernel.org.

 drivers/soc/tegra/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index db49075b1946..1224e1c8c2c9 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -15,7 +15,7 @@ config ARCH_TEGRA_2x_SOC
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select SOC_TEGRA_FLOWCTRL
 	select SOC_TEGRA_PMC
-	select SOC_TEGRA20_VOLTAGE_COUPLER
+	select SOC_TEGRA20_VOLTAGE_COUPLER if REGULATOR
 	select TEGRA_TIMER
 	help
 	  Support for NVIDIA Tegra AP20 and T20 processors, based on the
@@ -29,7 +29,7 @@ config ARCH_TEGRA_3x_SOC
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select SOC_TEGRA_FLOWCTRL
 	select SOC_TEGRA_PMC
-	select SOC_TEGRA30_VOLTAGE_COUPLER
+	select SOC_TEGRA30_VOLTAGE_COUPLER if REGULATOR
 	select TEGRA_TIMER
 	help
 	  Support for NVIDIA Tegra T30 processor family, based on the
@@ -154,7 +154,9 @@ config SOC_TEGRA_POWERGATE_BPMP
 config SOC_TEGRA20_VOLTAGE_COUPLER
 	bool "Voltage scaling support for Tegra20 SoCs"
 	depends on ARCH_TEGRA_2x_SOC || COMPILE_TEST
+	depends on REGULATOR
 
 config SOC_TEGRA30_VOLTAGE_COUPLER
 	bool "Voltage scaling support for Tegra30 SoCs"
 	depends on ARCH_TEGRA_3x_SOC || COMPILE_TEST
+	depends on REGULATOR
-- 
2.32.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR
  2021-07-21 23:26 [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR Dmitry Osipenko
@ 2021-07-22 10:49 ` Jon Hunter
  2021-08-02 14:36 ` Thierry Reding
  1 sibling, 0 replies; 6+ messages in thread
From: Jon Hunter @ 2021-07-22 10:49 UTC (permalink / raw)
  To: Dmitry Osipenko, Thierry Reding, Arnd Bergmann
  Cc: Mark Brown, soc, linux-kernel, linux-tegra


On 22/07/2021 00:26, Dmitry Osipenko wrote:
> The regulator coupler drivers now use regulator-driver API function that
> isn't available during compile-testing. Make regulator coupler drivers
> dependent on CONFIG_REGULATOR in Kconfig.
> 
> Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> 
> Changelog:
> 
> v2: - No changes. Re-sending to Arnd Bergmann and soc@kernel.org.
> 
>  drivers/soc/tegra/Kconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
> index db49075b1946..1224e1c8c2c9 100644
> --- a/drivers/soc/tegra/Kconfig
> +++ b/drivers/soc/tegra/Kconfig
> @@ -15,7 +15,7 @@ config ARCH_TEGRA_2x_SOC
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  	select SOC_TEGRA_FLOWCTRL
>  	select SOC_TEGRA_PMC
> -	select SOC_TEGRA20_VOLTAGE_COUPLER
> +	select SOC_TEGRA20_VOLTAGE_COUPLER if REGULATOR
>  	select TEGRA_TIMER
>  	help
>  	  Support for NVIDIA Tegra AP20 and T20 processors, based on the
> @@ -29,7 +29,7 @@ config ARCH_TEGRA_3x_SOC
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  	select SOC_TEGRA_FLOWCTRL
>  	select SOC_TEGRA_PMC
> -	select SOC_TEGRA30_VOLTAGE_COUPLER
> +	select SOC_TEGRA30_VOLTAGE_COUPLER if REGULATOR
>  	select TEGRA_TIMER
>  	help
>  	  Support for NVIDIA Tegra T30 processor family, based on the
> @@ -154,7 +154,9 @@ config SOC_TEGRA_POWERGATE_BPMP
>  config SOC_TEGRA20_VOLTAGE_COUPLER
>  	bool "Voltage scaling support for Tegra20 SoCs"
>  	depends on ARCH_TEGRA_2x_SOC || COMPILE_TEST
> +	depends on REGULATOR
>  
>  config SOC_TEGRA30_VOLTAGE_COUPLER
>  	bool "Voltage scaling support for Tegra30 SoCs"
>  	depends on ARCH_TEGRA_3x_SOC || COMPILE_TEST
> +	depends on REGULATOR
> 


Acked-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR
  2021-07-21 23:26 [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR Dmitry Osipenko
  2021-07-22 10:49 ` Jon Hunter
@ 2021-08-02 14:36 ` Thierry Reding
  2021-08-02 15:03   ` Arnd Bergmann
  1 sibling, 1 reply; 6+ messages in thread
From: Thierry Reding @ 2021-08-02 14:36 UTC (permalink / raw)
  To: Dmitry Osipenko
  Cc: Thierry Reding, Jonathan Hunter, Arnd Bergmann, Mark Brown, soc,
	linux-kernel, linux-tegra

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

On Thu, Jul 22, 2021 at 02:26:16AM +0300, Dmitry Osipenko wrote:
> The regulator coupler drivers now use regulator-driver API function that
> isn't available during compile-testing. Make regulator coupler drivers
> dependent on CONFIG_REGULATOR in Kconfig.
> 
> Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> 
> Changelog:
> 
> v2: - No changes. Re-sending to Arnd Bergmann and soc@kernel.org.
> 
>  drivers/soc/tegra/Kconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Seeing that Arnd hasn't picked this up yet, I've now applied it to the
Tegra tree and plan to send out a PR for v5.14 later this week.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR
  2021-08-02 14:36 ` Thierry Reding
@ 2021-08-02 15:03   ` Arnd Bergmann
  2021-08-02 15:05     ` Arnd Bergmann
  0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2021-08-02 15:03 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Dmitry Osipenko, Thierry Reding, Jonathan Hunter, Mark Brown,
	SoC Team, Linux Kernel Mailing List,
	open list:TEGRA ARCHITECTURE SUPPORT

On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Thu, Jul 22, 2021 at 02:26:16AM +0300, Dmitry Osipenko wrote:
> > The regulator coupler drivers now use regulator-driver API function that
> > isn't available during compile-testing. Make regulator coupler drivers
> > dependent on CONFIG_REGULATOR in Kconfig.
> >
> > Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> > ---
> >
> > Changelog:
> >
> > v2: - No changes. Re-sending to Arnd Bergmann and soc@kernel.org.
> >
> >  drivers/soc/tegra/Kconfig | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Seeing that Arnd hasn't picked this up yet, I've now applied it to the
> Tegra tree and plan to send out a PR for v5.14 later this week.

Sorry about the mixup. In fact I have just picked it up two hours ago.
If you have other fixes that are already in your fixes branch.

       Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR
  2021-08-02 15:03   ` Arnd Bergmann
@ 2021-08-02 15:05     ` Arnd Bergmann
  2021-08-02 16:23       ` Thierry Reding
  0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2021-08-02 15:05 UTC (permalink / raw)
  To: Thierry Reding
  Cc: Dmitry Osipenko, Thierry Reding, Jonathan Hunter, Mark Brown,
	SoC Team, Linux Kernel Mailing List,
	open list:TEGRA ARCHITECTURE SUPPORT

On Mon, Aug 2, 2021 at 5:03 PM Arnd Bergmann <arnd@kernel.org> wrote:
> On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> If you have other fixes that are already in your fixes branch
... that you want to have in rc5, please send them soon, as I'm going
to prepare that pull request in a few days.

I'll probably do another one for -rc6 though.

       Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR
  2021-08-02 15:05     ` Arnd Bergmann
@ 2021-08-02 16:23       ` Thierry Reding
  0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2021-08-02 16:23 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Dmitry Osipenko, Thierry Reding, Jonathan Hunter, Mark Brown,
	SoC Team, Linux Kernel Mailing List,
	open list:TEGRA ARCHITECTURE SUPPORT

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

On Mon, Aug 02, 2021 at 05:05:01PM +0200, Arnd Bergmann wrote:
> On Mon, Aug 2, 2021 at 5:03 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > If you have other fixes that are already in your fixes branch
> ... that you want to have in rc5, please send them soon, as I'm going
> to prepare that pull request in a few days.
> 
> I'll probably do another one for -rc6 though.

Okay, will do. Thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-02 16:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 23:26 [PATCH v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR Dmitry Osipenko
2021-07-22 10:49 ` Jon Hunter
2021-08-02 14:36 ` Thierry Reding
2021-08-02 15:03   ` Arnd Bergmann
2021-08-02 15:05     ` Arnd Bergmann
2021-08-02 16:23       ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).