From: Colin Foster <colin.foster@in-advantage.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Tony Lindgren" <tony@atomide.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
soc@kernel.org, "Olof Johansson" <olof@lixom.net>,
"Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [RFC v1 1/1] arm: dts: omap4: pcm959: add initial support for phytec pcm959
Date: Tue, 4 Oct 2022 16:01:26 -0700 [thread overview]
Message-ID: <Yzy7RjffvnQF6Geo@colin-ia-desktop> (raw)
In-Reply-To: <6d58c08e-1537-f1ab-2883-baf869650ef2@linaro.org>
Hi Krzysztof,
On Tue, Oct 04, 2022 at 09:04:15AM +0200, Krzysztof Kozlowski wrote:
> On 04/10/2022 04:40, Colin Foster wrote:
> > The Phytec PCM-959 is a development platform for the Phytec PCM-049 SOM.
> > Add initial functionality for the board. The verified interfaces and
> > peripherals are listed below for the SOM (PCM-049) and the dev board
> > (PCM-959)
> >
> > The omap2plus_defconfig was used for testing. Only the On-board LEDs
> > required CONFIG_LEDS_PCA9532 addition.
> >
> > PCM-049:
> > i2c1
> > * EEPROM at 0x50
> > * TMP102 (hwmon) at 0x4b
> > twl6030
> > GPMC
> > * Ethernet
> > * Flash
> > Serial (ttyS2 console)
> >
> > PCM959:
> > MMC1
> > On-board LEDs (with CONFIG_LEDS_PCA9532)
> >
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> > arch/arm/boot/dts/Makefile | 1 +
> > arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi | 352 ++++++++++++++++++++
> > arch/arm/boot/dts/omap4-phytec-pcm-959.dts | 130 ++++++++
> > 3 files changed, 483 insertions(+)
> > create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
> > create mode 100644 arch/arm/boot/dts/omap4-phytec-pcm-959.dts
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 27eec8e670ec..ef225150c5d7 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -949,6 +949,7 @@ dtb-$(CONFIG_ARCH_OMAP4) += \
> > omap4-panda.dtb \
> > omap4-panda-a4.dtb \
> > omap4-panda-es.dtb \
> > + omap4-phytec-pcm-959.dtb \
> > omap4-sdp.dtb \
> > omap4-sdp-es23plus.dtb \
> > omap4-var-dvk-om44.dtb \
> > diff --git a/arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi b/arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
> > new file mode 100644
> > index 000000000000..05b5cd581f15
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/omap4-phytec-pcm-049.dtsi
> > @@ -0,0 +1,352 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + stdout-path = &uart3;
> > + };
> > +
> > + leds: leds {
>
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).
Ahh, I see that now. I had started with
arch/arm/boot/dts/omap4-panda-{es,common} as my inspiration. I'll review
the documentation and be sure to run make dtbs_check before my next
submission.
And thank you for all your other points. They're all valid, and I'll
be sure to implement all of your suggestions before a future submission.
There isn't much use for me to acknowledge each suggestion one-by-one.
Thank you very much.
prev parent reply other threads:[~2022-10-04 23:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 2:40 [RFC v1 0/1] add support for Phytec PCM-049 and PCM-959 Colin Foster
2022-10-04 2:40 ` [RFC v1 1/1] arm: dts: omap4: pcm959: add initial support for phytec pcm959 Colin Foster
2022-10-04 7:04 ` Krzysztof Kozlowski
2022-10-04 23:01 ` Colin Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzy7RjffvnQF6Geo@colin-ia-desktop \
--to=colin.foster@in-advantage.com \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).