From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MISSING_HEADERS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE3DC48BCF for ; Sun, 13 Jun 2021 12:12:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) id 86C95611CA; Sun, 13 Jun 2021 12:12:55 +0000 (UTC) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52AD161153; Sun, 13 Jun 2021 12:12:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52AD161153 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=mnhagan88@gmail.com Received: by mail-wr1-f41.google.com with SMTP id f2so11207924wri.11; Sun, 13 Jun 2021 05:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:cc:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=MSBzfhNHhCZmKOAtF+feGhoOQgIox8era17UjUTrjUE=; b=l2Z1PgZ3TRJ86BB4Fs7L1ANwas3gPy9RlFUkMaQBKOB+gn/9IYQrEoF4G/L6Ndaeb1 GzGwJIvQtzlZfa0izIRGGfQBWm609L01TBKh17QvkTT9uAl9lmKBIauSsKllCrnCx3kV 5cdvOMfVjhCw/7OH+3v+cUI1tRqTbYPLM4DYShDFC1U2nUriGp1caHofZDgbhbMKRGUJ vg1/kshURdPlBksQMkNYy5nQPH378E3TC3y/TyEK/vOH4YYc+Vx/3qQVZatGxq3K9zxN NBo8kJV0lJXyet4BVyjT18OUtYPBsYjSh1Nm5P4tEg/fwgGMLNEAOX8iKKkInEbVPVuF OMxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MSBzfhNHhCZmKOAtF+feGhoOQgIox8era17UjUTrjUE=; b=CANzfj8jC6kcbBgWVx0AnJUtBbFpfOlmSHFBt9q7zSmR15V71v93s50dSVAlNfta8a BrjOLBfxF4VVWYPZ1Nl9jJSWQJTcCpqXBH0nzEL24FujetDCIZ0I6mbQymKo3uWMTaOc +GJxtU9+T7AVQt9HNPfCrHut+vhXDnvQoY8SV2uuuAlJjFhkWkHQ4+JagwYUemAhrQ5p 9GwtzGDkNFMh9w0++r6oaMepkjC/+Z2KtDKqNUdCEkv+RRFjz3FX+Dk7reIP+eD0YYn2 Be09gV4iul3BlNIvUXMaao38FIOkP33axbrEih8K+Alt0EyY1AYybSGWBDxeg0NsLe8l C9+Q== X-Gm-Message-State: AOAM531UU1avUBpXNY7HYz0UjxLVdui6b2piQNta2FAgfNXpWXHNR3/I bR6UYFqyuc83DYmosoyCHP0= X-Google-Smtp-Source: ABdhPJzdsWlJYmHLVODebMS58JP6dspsTQK9rBvzCp8jXQPWPraySMRIFTEHeE+dz3xiXhHRJhSZXQ== X-Received: by 2002:a5d:6d8d:: with SMTP id l13mr13753573wrs.304.1623586373945; Sun, 13 Jun 2021 05:12:53 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id r7sm22167353wma.9.2021.06.13.05.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Jun 2021 05:12:53 -0700 (PDT) Subject: Re: [PATCH v3 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series List-Id: Cc: Florian Fainelli , Vladimir Oltean , Andrew Lunn , Rob Herring , Arnd Bergmann , Olof Johansson , soc@kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sam Ravnborg , Geert Uytterhoeven , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210613101658.3242777-1-mnhagan88@gmail.com> <20210613101658.3242777-3-mnhagan88@gmail.com> From: Matthew Hagan Message-ID: Date: Sun, 13 Jun 2021 13:12:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210613101658.3242777-3-mnhagan88@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 13/06/2021 11:16, Matthew Hagan wrote: > MX64 & MX64W Hardware info: > - CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz > - RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR) > - Storage: 1 GB (Micron MT29F8G08ABACA) > - Networking: BCM58625 internal switch (5x 1GbE ports) > - USB: 1x USB2.0 > - Serial: Internal header > - WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus > > This patch adds the Meraki MX64 series-specific bindings. Since some > devices make use of the older A0 SoC, changes need to be made to > accommodate this case, including removal of coherency options and > modification to the secondary-boot-reg. > > Signed-off-by: Matthew Hagan > --- > arch/arm/boot/dts/Makefile | 4 + > .../boot/dts/bcm958625-meraki-kingpin.dtsi | 165 ++++++++++++++++++ > .../arm/boot/dts/bcm958625-meraki-mx64-a0.dts | 45 +++++ > arch/arm/boot/dts/bcm958625-meraki-mx64.dts | 15 ++ > .../boot/dts/bcm958625-meraki-mx64w-a0.dts | 55 ++++++ > arch/arm/boot/dts/bcm958625-meraki-mx64w.dts | 23 +++ > 6 files changed, 307 insertions(+) > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index f8f09c5066e7..83560b05f797 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -154,6 +154,10 @@ dtb-$(CONFIG_ARCH_BCM_NSP) += \ > bcm958525xmc.dtb \ > bcm958622hr.dtb \ > bcm958623hr.dtb \ > + bcm958625-meraki-mx64.dtb \ > + bcm958625-meraki-mx64-a0.dtb \ > + bcm958625-meraki-mx64w.dtb \ > + bcm958625-meraki-mx64w-a0.dtb \ > bcm958625hr.dtb \ > bcm988312hr.dtb \ > bcm958625k.dtb > diff --git a/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > new file mode 100644 > index 000000000000..107c2167a113 > --- /dev/null > +++ b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > @@ -0,0 +1,165 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Device Tree Bindings for Cisco Meraki MX64 series (Kingpin). > + * > + * Copyright (C) 2020-2021 Matthew Hagan > + */ > + > +#include "bcm958625-meraki-mx6x-common.dtsi" > +#include > +#include dt-bindings/input/input.h should be included in bcm958625-mx6x-common.dtsi. dt-bindings/leds/common.h is already included in bcm958625-mx6x-common.dtsi and isn't required here. Likewise in bcm958625-meraki-alamo.dtsi I will hold off on submitting a v4 until the preparatory SoC patches are sorted out. Matthew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C2BC48BDF for ; Sun, 13 Jun 2021 12:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BE7D61153 for ; Sun, 13 Jun 2021 12:12:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231697AbhFMMO5 (ORCPT ); Sun, 13 Jun 2021 08:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231658AbhFMMO4 (ORCPT ); Sun, 13 Jun 2021 08:14:56 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 938B9C061574; Sun, 13 Jun 2021 05:12:55 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id m18so11230200wrv.2; Sun, 13 Jun 2021 05:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:cc:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=MSBzfhNHhCZmKOAtF+feGhoOQgIox8era17UjUTrjUE=; b=l2Z1PgZ3TRJ86BB4Fs7L1ANwas3gPy9RlFUkMaQBKOB+gn/9IYQrEoF4G/L6Ndaeb1 GzGwJIvQtzlZfa0izIRGGfQBWm609L01TBKh17QvkTT9uAl9lmKBIauSsKllCrnCx3kV 5cdvOMfVjhCw/7OH+3v+cUI1tRqTbYPLM4DYShDFC1U2nUriGp1caHofZDgbhbMKRGUJ vg1/kshURdPlBksQMkNYy5nQPH378E3TC3y/TyEK/vOH4YYc+Vx/3qQVZatGxq3K9zxN NBo8kJV0lJXyet4BVyjT18OUtYPBsYjSh1Nm5P4tEg/fwgGMLNEAOX8iKKkInEbVPVuF OMxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MSBzfhNHhCZmKOAtF+feGhoOQgIox8era17UjUTrjUE=; b=mvfj6XqajempxwxTT/eiUOkvZ+W4Ana0OS0mIh59666nkTfYjetsk3S5hZQLV9fN32 hyqUaK919Fpjpw0KiQbrWlgSX1HQIUje29McS0/svYSPDherdUYfU0W5c6dkW0kS2rXS k8mJg2GBvT5Ed9z6hEvPUkhVeucQwzd+GUmfAuJ239KF5vI0KX3NbGqOMDtKxxwPiRgf zDkkNY0B3sLDMFAfPODvI+/CzTV+kzVc7o1foSomQ/uTHO6fN5tm81XhwAuDWx32Po5t ZVcPtAL/VUmiXJfZj2TrNqbCroHVqkl3uQEpkAHykBhFuYffTA2S2ECnrSjbydXKZRYl 0vyw== X-Gm-Message-State: AOAM533H8WKpy8MR7vLFyQPmwK7HFSqD0msjfMWkwMW4fldrFT8pw+/F tWAkR0AuxyutR26AIJ6jXo0= X-Google-Smtp-Source: ABdhPJzdsWlJYmHLVODebMS58JP6dspsTQK9rBvzCp8jXQPWPraySMRIFTEHeE+dz3xiXhHRJhSZXQ== X-Received: by 2002:a5d:6d8d:: with SMTP id l13mr13753573wrs.304.1623586373945; Sun, 13 Jun 2021 05:12:53 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id r7sm22167353wma.9.2021.06.13.05.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Jun 2021 05:12:53 -0700 (PDT) Subject: Re: [PATCH v3 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series List-Id: Cc: Florian Fainelli , Vladimir Oltean , Andrew Lunn , Rob Herring , Arnd Bergmann , Olof Johansson , soc@kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sam Ravnborg , Geert Uytterhoeven , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210613101658.3242777-1-mnhagan88@gmail.com> <20210613101658.3242777-3-mnhagan88@gmail.com> From: Matthew Hagan Message-ID: Date: Sun, 13 Jun 2021 13:12:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210613101658.3242777-3-mnhagan88@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Message-ID: <20210613121251.0JOyez4-5g0nPccI4krfmbGEQpjjxwYN8mtHWuIjpQs@z> On 13/06/2021 11:16, Matthew Hagan wrote: > MX64 & MX64W Hardware info: > - CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz > - RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR) > - Storage: 1 GB (Micron MT29F8G08ABACA) > - Networking: BCM58625 internal switch (5x 1GbE ports) > - USB: 1x USB2.0 > - Serial: Internal header > - WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus > > This patch adds the Meraki MX64 series-specific bindings. Since some > devices make use of the older A0 SoC, changes need to be made to > accommodate this case, including removal of coherency options and > modification to the secondary-boot-reg. > > Signed-off-by: Matthew Hagan > --- > arch/arm/boot/dts/Makefile | 4 + > .../boot/dts/bcm958625-meraki-kingpin.dtsi | 165 ++++++++++++++++++ > .../arm/boot/dts/bcm958625-meraki-mx64-a0.dts | 45 +++++ > arch/arm/boot/dts/bcm958625-meraki-mx64.dts | 15 ++ > .../boot/dts/bcm958625-meraki-mx64w-a0.dts | 55 ++++++ > arch/arm/boot/dts/bcm958625-meraki-mx64w.dts | 23 +++ > 6 files changed, 307 insertions(+) > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index f8f09c5066e7..83560b05f797 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -154,6 +154,10 @@ dtb-$(CONFIG_ARCH_BCM_NSP) += \ > bcm958525xmc.dtb \ > bcm958622hr.dtb \ > bcm958623hr.dtb \ > + bcm958625-meraki-mx64.dtb \ > + bcm958625-meraki-mx64-a0.dtb \ > + bcm958625-meraki-mx64w.dtb \ > + bcm958625-meraki-mx64w-a0.dtb \ > bcm958625hr.dtb \ > bcm988312hr.dtb \ > bcm958625k.dtb > diff --git a/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > new file mode 100644 > index 000000000000..107c2167a113 > --- /dev/null > +++ b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > @@ -0,0 +1,165 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Device Tree Bindings for Cisco Meraki MX64 series (Kingpin). > + * > + * Copyright (C) 2020-2021 Matthew Hagan > + */ > + > +#include "bcm958625-meraki-mx6x-common.dtsi" > +#include > +#include dt-bindings/input/input.h should be included in bcm958625-mx6x-common.dtsi. dt-bindings/leds/common.h is already included in bcm958625-mx6x-common.dtsi and isn't required here. Likewise in bcm958625-meraki-alamo.dtsi I will hold off on submitting a v4 until the preparatory SoC patches are sorted out. Matthew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MISSING_HEADERS,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E314C48BCF for ; Sun, 13 Jun 2021 12:14:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD5E761153 for ; Sun, 13 Jun 2021 12:14:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD5E761153 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:Subject:Reply-To:To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=CR48dUAVvhH8piCpvp7Q815bi7i6BL+pzj+/LxbKl54=; b=DoESAWPvtqWsXEkdVj2EEGPDku 3RkgUsVJvk7rn5xgm3GCMUQ/8wuWi2eGEnLirkR/BwfCPrdwDI4YQoPzKGGPH+idD2auTAYB6iwhy P85ZsBsCYHSJrJYzu6Zgd9rGS88UEXQpdmGgDzaurpWx9gxZ1HSQCiXCvbOy47TckfptGnJYpvtdk 5w9WxKgd/Dcyn2WNC20KiNPsXUb6sKTv6Ma2MOy1Qvj8nSveV5oev2wTHWny4QTkZRlJG9QqdYHNC I0sgCOLIXX8GT/C14zuQhUva1W74v+5FCGGNeoO9rl7YDWspErKY2OBk26tDpAsIhfpYX9y71d6ig r3RNTA6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsOz6-00AP4X-7e; Sun, 13 Jun 2021 12:13:00 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsOz1-00AP3V-Rq for linux-arm-kernel@lists.infradead.org; Sun, 13 Jun 2021 12:12:57 +0000 Received: by mail-wr1-x42a.google.com with SMTP id f2so11207934wri.11 for ; Sun, 13 Jun 2021 05:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:cc:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=MSBzfhNHhCZmKOAtF+feGhoOQgIox8era17UjUTrjUE=; b=l2Z1PgZ3TRJ86BB4Fs7L1ANwas3gPy9RlFUkMaQBKOB+gn/9IYQrEoF4G/L6Ndaeb1 GzGwJIvQtzlZfa0izIRGGfQBWm609L01TBKh17QvkTT9uAl9lmKBIauSsKllCrnCx3kV 5cdvOMfVjhCw/7OH+3v+cUI1tRqTbYPLM4DYShDFC1U2nUriGp1caHofZDgbhbMKRGUJ vg1/kshURdPlBksQMkNYy5nQPH378E3TC3y/TyEK/vOH4YYc+Vx/3qQVZatGxq3K9zxN NBo8kJV0lJXyet4BVyjT18OUtYPBsYjSh1Nm5P4tEg/fwgGMLNEAOX8iKKkInEbVPVuF OMxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MSBzfhNHhCZmKOAtF+feGhoOQgIox8era17UjUTrjUE=; b=lyUQA8w4ULOB5S5YeeHGWWm++wcDJpEaFur95tBKpvd0nfCmsu4jqnawa8941wlja3 7JOidYuoFJM0MunLGnKBX08/AsRCQz3FVsHDXmxUtmM0bBNNsIff+2PFrT280hzxpzi/ maxlHtXGwpT6I225ylPjePzFwk7FWVXEZag9nPr4PvbZVpW2nNWj21q1wTpCOYoVWSKc kjVGVuSZlm/j2kTHar8v/K954Yb8KtV40wo7nsSv9vNPWDpP5O3wMMTm1RFBpjWkYzLx 2ZmefckRmN8qxJl92d3NUQVb3fDfRNKgDzKUvMEsTbp3RdclQXQfUuxomCjjT857jR6M ypYw== X-Gm-Message-State: AOAM533BV47N/ObR8I4SgHKttGEm56S/57hI3UrKZzFf8Y9E8I42pkND CcYh0m3XvGf0RF6lf2h4gXLNlarYl/zghg== X-Google-Smtp-Source: ABdhPJzdsWlJYmHLVODebMS58JP6dspsTQK9rBvzCp8jXQPWPraySMRIFTEHeE+dz3xiXhHRJhSZXQ== X-Received: by 2002:a5d:6d8d:: with SMTP id l13mr13753573wrs.304.1623586373945; Sun, 13 Jun 2021 05:12:53 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id r7sm22167353wma.9.2021.06.13.05.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Jun 2021 05:12:53 -0700 (PDT) Subject: Re: [PATCH v3 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series List-Id: Cc: Florian Fainelli , Vladimir Oltean , Andrew Lunn , Rob Herring , Arnd Bergmann , Olof Johansson , soc@kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sam Ravnborg , Geert Uytterhoeven , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210613101658.3242777-1-mnhagan88@gmail.com> <20210613101658.3242777-3-mnhagan88@gmail.com> From: Matthew Hagan Message-ID: Date: Sun, 13 Jun 2021 13:12:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210613101658.3242777-3-mnhagan88@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210613_051255_957994_B163C698 X-CRM114-Status: GOOD ( 23.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20210613121251.4SNqz7Hx8rZ_fJVV7HwSnizjv0oGkr3XDvEnPrqiM2c@z> On 13/06/2021 11:16, Matthew Hagan wrote: > MX64 & MX64W Hardware info: > - CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz > - RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR) > - Storage: 1 GB (Micron MT29F8G08ABACA) > - Networking: BCM58625 internal switch (5x 1GbE ports) > - USB: 1x USB2.0 > - Serial: Internal header > - WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus > > This patch adds the Meraki MX64 series-specific bindings. Since some > devices make use of the older A0 SoC, changes need to be made to > accommodate this case, including removal of coherency options and > modification to the secondary-boot-reg. > > Signed-off-by: Matthew Hagan > --- > arch/arm/boot/dts/Makefile | 4 + > .../boot/dts/bcm958625-meraki-kingpin.dtsi | 165 ++++++++++++++++++ > .../arm/boot/dts/bcm958625-meraki-mx64-a0.dts | 45 +++++ > arch/arm/boot/dts/bcm958625-meraki-mx64.dts | 15 ++ > .../boot/dts/bcm958625-meraki-mx64w-a0.dts | 55 ++++++ > arch/arm/boot/dts/bcm958625-meraki-mx64w.dts | 23 +++ > 6 files changed, 307 insertions(+) > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dts > create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index f8f09c5066e7..83560b05f797 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -154,6 +154,10 @@ dtb-$(CONFIG_ARCH_BCM_NSP) += \ > bcm958525xmc.dtb \ > bcm958622hr.dtb \ > bcm958623hr.dtb \ > + bcm958625-meraki-mx64.dtb \ > + bcm958625-meraki-mx64-a0.dtb \ > + bcm958625-meraki-mx64w.dtb \ > + bcm958625-meraki-mx64w-a0.dtb \ > bcm958625hr.dtb \ > bcm988312hr.dtb \ > bcm958625k.dtb > diff --git a/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > new file mode 100644 > index 000000000000..107c2167a113 > --- /dev/null > +++ b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi > @@ -0,0 +1,165 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Device Tree Bindings for Cisco Meraki MX64 series (Kingpin). > + * > + * Copyright (C) 2020-2021 Matthew Hagan > + */ > + > +#include "bcm958625-meraki-mx6x-common.dtsi" > +#include > +#include dt-bindings/input/input.h should be included in bcm958625-mx6x-common.dtsi. dt-bindings/leds/common.h is already included in bcm958625-mx6x-common.dtsi and isn't required here. Likewise in bcm958625-meraki-alamo.dtsi I will hold off on submitting a v4 until the preparatory SoC patches are sorted out. Matthew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel