soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	soc@kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
Date: Sun, 11 Jul 2021 14:27:46 -0700	[thread overview]
Message-ID: <d3154d8d-6f4c-b59b-add1-f3e75462309a@gmail.com> (raw)
In-Reply-To: <1625915095-23077-1-git-send-email-stefan.wahren@i2se.com>



On 7/10/2021 4:04 AM, Stefan Wahren wrote:
> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
> been a "regression source" a lot of times. The last case is breakage of
> USB mass storage boot has been commit e590474768f1 ("driver core: Set
> fw_devlink=on by default") for multi_v7_defconfig. As long as
> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
> endlessly and prevent booting from USB mass storage device. So make
> the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Should not that be fixed somehow?

> 
> Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>   arch/arm/configs/multi_v7_defconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 52a0400..d9abaae 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y
>   CONFIG_USB_HSIC_USB3503=y
>   CONFIG_AB8500_USB=y
>   CONFIG_KEYSTONE_USB_PHY=m
> -CONFIG_NOP_USB_XCEIV=m
> +CONFIG_NOP_USB_XCEIV=y
>   CONFIG_AM335X_PHY_USB=m
>   CONFIG_TWL6030_USB=m
>   CONFIG_USB_GPIO_VBUS=y
> 

-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	soc@kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
Date: Sun, 11 Jul 2021 14:27:46 -0700	[thread overview]
Message-ID: <d3154d8d-6f4c-b59b-add1-f3e75462309a@gmail.com> (raw)
Message-ID: <20210711212746.QWc_Yxdvz4-wnIXcQjqzgLt7MsA78Iwe751sn5e3v0I@z> (raw)
In-Reply-To: <1625915095-23077-1-git-send-email-stefan.wahren@i2se.com>



On 7/10/2021 4:04 AM, Stefan Wahren wrote:
> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
> been a "regression source" a lot of times. The last case is breakage of
> USB mass storage boot has been commit e590474768f1 ("driver core: Set
> fw_devlink=on by default") for multi_v7_defconfig. As long as
> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
> endlessly and prevent booting from USB mass storage device. So make
> the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Should not that be fixed somehow?

> 
> Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>   arch/arm/configs/multi_v7_defconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 52a0400..d9abaae 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y
>   CONFIG_USB_HSIC_USB3503=y
>   CONFIG_AB8500_USB=y
>   CONFIG_KEYSTONE_USB_PHY=m
> -CONFIG_NOP_USB_XCEIV=m
> +CONFIG_NOP_USB_XCEIV=y
>   CONFIG_AM335X_PHY_USB=m
>   CONFIG_TWL6030_USB=m
>   CONFIG_USB_GPIO_VBUS=y
> 

-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-07-11 21:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 11:04 [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in Stefan Wahren
2021-07-10 11:04 ` Stefan Wahren
2021-07-11 21:27 ` Florian Fainelli [this message]
2021-07-11 21:27   ` Florian Fainelli
2021-07-12  5:04   ` Stefan Wahren
2021-07-12  5:04     ` Stefan Wahren
2021-07-16 21:22 ` patchwork-bot+linux-soc
2021-07-16 21:24 ` Arnd Bergmann
2021-07-16 21:24   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3154d8d-6f4c-b59b-add1-f3e75462309a@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenz@kernel.org \
    --cc=olof@lixom.net \
    --cc=rjui@broadcom.com \
    --cc=saravanak@google.com \
    --cc=sbranden@broadcom.com \
    --cc=soc@kernel.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).