soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] soc: samsung: exynos-pmu: select CONFIG_MFD_CORE
       [not found] <20210920100608.4hFeOueXXt8NDJ-XlvTeg72Zv9JS-n8qqfu2KQmHmK8@z>
@ 2021-09-20 10:06 ` Arnd Bergmann
       [not found]   ` <20210920102851.QJufAvUSHHjjK4Xkz4SqDrPIkZcyds2ql0MJpPV2SjI@z>
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-09-20 10:06 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Stephen Boyd, Sylwester Nawrocki
  Cc: soc, Arnd Bergmann, Pankaj Dubey, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Using devm_mfd_add_devices() fails if no driver selects the
MFD core code:

aarch64-linux-ld: drivers/soc/samsung/exynos-pmu.o: in function `exynos_pmu_probe':
exynos-pmu.c:(.text+0xa0): undefined reference to `devm_mfd_add_devices'

Add the missing select statement.

Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/samsung/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
index 5745d7e5908e..1f643c0f5c93 100644
--- a/drivers/soc/samsung/Kconfig
+++ b/drivers/soc/samsung/Kconfig
@@ -25,6 +25,7 @@ config EXYNOS_PMU
 	bool "Exynos PMU controller driver" if COMPILE_TEST
 	depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST)
 	select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS
+	select MFD_CORE
 
 # There is no need to enable these drivers for ARMv8
 config EXYNOS_PMU_ARM_DRIVERS
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] soc: samsung: exynos-pmu: select CONFIG_MFD_CORE
       [not found]   ` <20210920102851.QJufAvUSHHjjK4Xkz4SqDrPIkZcyds2ql0MJpPV2SjI@z>
@ 2021-09-20 10:28     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-20 10:28 UTC (permalink / raw)
  To: Arnd Bergmann, Stephen Boyd, Sylwester Nawrocki
  Cc: soc, Arnd Bergmann, Pankaj Dubey, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On 20/09/2021 12:06, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Using devm_mfd_add_devices() fails if no driver selects the
> MFD core code:
> 
> aarch64-linux-ld: drivers/soc/samsung/exynos-pmu.o: in function `exynos_pmu_probe':
> exynos-pmu.c:(.text+0xa0): undefined reference to `devm_mfd_add_devices'
> 
> Add the missing select statement.
> 
> Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/soc/samsung/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Hi Arnd,

Thanks for the patch but this was already committed few days ago from
different author:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/drivers&id=e37ef6dcdb1f4738b01cec7fb7be46af07816af9


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-20 10:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210920100608.4hFeOueXXt8NDJ-XlvTeg72Zv9JS-n8qqfu2KQmHmK8@z>
2021-09-20 10:06 ` [PATCH] soc: samsung: exynos-pmu: select CONFIG_MFD_CORE Arnd Bergmann
     [not found]   ` <20210920102851.QJufAvUSHHjjK4Xkz4SqDrPIkZcyds2ql0MJpPV2SjI@z>
2021-09-20 10:28     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).