sparclinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg via B4 Relay <devnull+sam.ravnborg.org@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>,
	sparclinux@vger.kernel.org,
	 Andreas Larsson <andreas@gaisler.com>,
	Randy Dunlap <rdunlap@infradead.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	 linux-parport@lists.infradead.org,
	"David S. Miller" <davem@davemloft.net>,
	 Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,  Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v2 4/7] sparc32: Do not select ZONE_DMA
Date: Sat, 24 Feb 2024 18:42:25 +0100	[thread overview]
Message-ID: <20240224-sam-fix-sparc32-all-builds-v2-4-1f186603c5c4@ravnborg.org> (raw)
In-Reply-To: <20240224-sam-fix-sparc32-all-builds-v2-0-1f186603c5c4@ravnborg.org>

From: Sam Ravnborg <sam@ravnborg.org>

sparc32 has no limited DMA zone so there is no need to select ZONE_DMA.

Based on analysis from Marciej:
"
    Actually I think ZONE_DMA should go too (it's linked to GENERIC_ISA_DMA,
    isn't it? -- cf. commit 5ac6da669e24 ("[PATCH] Set CONFIG_ZONE_DMA for
    arches with GENERIC_ISA_DMA")), and the whole thing use:

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

    The GENERIC_ISA_DMA option itself was added to arch/sparc/config.in with
    2.5.31 as:

        define_bool CONFIG_GENERIC_ISA_DMA y

    despite of:

        define_bool CONFIG_ISA n
"

The sparc32 code did not differ between ZONE_NORMAL and ZONE_DMA,
which confirms the above. This patch drop ZONE_DMA.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reported-by: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Andreas Larsson <andreas@gaisler.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Maciej W. Rozycki <macro@orcam.me.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 arch/sparc/Kconfig    | 1 -
 arch/sparc/mm/srmmu.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 734f23daecca..bdbde506c01e 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -62,7 +62,6 @@ config SPARC32
 	select HAVE_UID16
 	select LOCK_MM_AND_FIND_VMA
 	select OLD_SIGACTION
-	select ZONE_DMA
 
 config SPARC64
 	def_bool 64BIT
diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c
index 852085ada368..7aae2f6f4973 100644
--- a/arch/sparc/mm/srmmu.c
+++ b/arch/sparc/mm/srmmu.c
@@ -975,7 +975,6 @@ void __init srmmu_paging_init(void)
 	{
 		unsigned long max_zone_pfn[MAX_NR_ZONES] = { 0 };
 
-		max_zone_pfn[ZONE_DMA] = max_low_pfn;
 		max_zone_pfn[ZONE_NORMAL] = max_low_pfn;
 		max_zone_pfn[ZONE_HIGHMEM] = highend_pfn;
 

-- 
2.34.1


  parent reply	other threads:[~2024-02-24 17:42 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-24 17:42 [PATCH v2 0/7] sparc32: build fixes for all{yes,mod}config builds Sam Ravnborg via B4 Relay
2024-02-24 17:42 ` [PATCH v2 1/7] sparc32: Use generic cmpdi2/ucmpdi2 variants Sam Ravnborg via B4 Relay
2024-03-08 20:00   ` Andreas Larsson
2024-02-24 17:42 ` [PATCH v2 2/7] sparc32: Fix build with trapbase Sam Ravnborg via B4 Relay
2024-03-08 20:01   ` Andreas Larsson
2024-02-24 17:42 ` [PATCH v2 3/7] mtd: maps: sun_uflash: Declare uflash_devinit static Sam Ravnborg via B4 Relay
2024-02-26 10:23   ` Miquel Raynal
2024-03-08 20:02   ` Andreas Larsson
2024-02-24 17:42 ` Sam Ravnborg via B4 Relay [this message]
2024-02-25  0:57   ` [PATCH v2 4/7] sparc32: Do not select ZONE_DMA Maciej W. Rozycki
2024-02-25  7:08     ` Sam Ravnborg
2024-03-02 23:51   ` Randy Dunlap
2024-03-05 15:06   ` Andreas Larsson
2024-03-05 15:26     ` Arnd Bergmann
2024-03-06 14:19       ` Andreas Larsson
2024-03-06 14:45         ` Arnd Bergmann
2024-03-06 15:31           ` Andreas Larsson
2024-03-06 16:22             ` Arnd Bergmann
2024-03-06 18:19               ` Arnd Bergmann
2024-03-07 12:42                 ` Andreas Larsson
2024-03-07 13:06                   ` Arnd Bergmann
2024-03-06 15:04         ` Christoph Hellwig
2024-03-06 15:24           ` Arnd Bergmann
2024-02-24 17:42 ` [PATCH v2 5/7] sparc32: Do not select GENERIC_ISA_DMA Sam Ravnborg via B4 Relay
2024-03-08 20:03   ` Andreas Larsson
2024-03-09  9:04     ` Maciej W. Rozycki
2024-02-24 17:42 ` [PATCH v2 6/7] sparc32: Fix parport build with sparc32 Sam Ravnborg via B4 Relay
2024-03-02 23:52   ` Randy Dunlap
2024-03-08 20:04   ` Andreas Larsson
2024-03-09  9:06     ` Maciej W. Rozycki
2024-02-24 17:42 ` [PATCH v2 7/7] sparc32: Fix section mismatch in leon_pci_grpci Sam Ravnborg via B4 Relay
2024-03-02 23:54   ` Randy Dunlap
2024-03-05 15:06   ` Andreas Larsson
2024-03-07 18:20     ` Andreas Larsson
2024-03-07 20:16       ` Maciej W. Rozycki
2024-03-08  7:06         ` Andreas Larsson
2024-03-08 12:09           ` Maciej W. Rozycki
2024-03-08 22:08       ` Sam Ravnborg
2024-03-08 20:07   ` Andreas Larsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240224-sam-fix-sparc32-all-builds-v2-4-1f186603c5c4@ravnborg.org \
    --to=devnull+sam.ravnborg.org@kernel.org \
    --cc=andreas@gaisler.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parport@lists.infradead.org \
    --cc=macro@orcam.me.uk \
    --cc=miquel.raynal@bootlin.com \
    --cc=rdunlap@infradead.org \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).