From: Alex Deucher <alexdeucher@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Huang Rui <ray.huang@amd.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>,
LKML <linux-kernel@vger.kernel.org>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH] drm/ttm: fix the type mismatch error on sparc64
Date: Tue, 14 Sep 2021 15:48:31 -0400 [thread overview]
Message-ID: <CADnq5_PXOXiob3k5Z+cZz6K2k5iSCdzwNm0ZxKQOuC+PvdJxxg@mail.gmail.com> (raw)
In-Reply-To: <5e365947-4ae1-47a0-7565-7f0cdde0bd84@amd.com>
On Tue, Sep 7, 2021 at 6:25 AM Christian König <christian.koenig@amd.com> wrote:
>
> Am 07.09.21 um 12:03 schrieb Huang Rui:
> > __fls() on sparc64 return "int", but here it is expected as "unsigned
> > long" (x86). It will cause the build errors because the warning becomes
> > fatal while it is using sparc configuration. As suggested by Linus, it
> > can use min_t instead of min to force the type as "unsigned int".
> >
> > Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > Cc: Christian König <christian.koenig@amd.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
Is one of you going to push this to drm-misc?
Alex
>
> > ---
> > drivers/gpu/drm/ttm/ttm_pool.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c
> > index af1b41369626..c961a788b519 100644
> > --- a/drivers/gpu/drm/ttm/ttm_pool.c
> > +++ b/drivers/gpu/drm/ttm/ttm_pool.c
> > @@ -382,7 +382,8 @@ int ttm_pool_alloc(struct ttm_pool *pool, struct ttm_tt *tt,
> > else
> > gfp_flags |= GFP_HIGHUSER;
> >
> > - for (order = min(MAX_ORDER - 1UL, __fls(num_pages)); num_pages;
> > + for (order = min_t(unsigned int, MAX_ORDER - 1, __fls(num_pages));
> > + num_pages;
> > order = min_t(unsigned int, order, __fls(num_pages))) {
> > bool apply_caching = false;
> > struct ttm_pool_type *pt;
>
next prev parent reply other threads:[~2021-09-14 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 10:03 [PATCH] drm/ttm: fix the type mismatch error on sparc64 Huang Rui
2021-09-07 10:24 ` Christian König
2021-09-14 19:48 ` Alex Deucher [this message]
2021-09-14 20:03 ` Linus Torvalds
2021-09-15 8:20 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_PXOXiob3k5Z+cZz6K2k5iSCdzwNm0ZxKQOuC+PvdJxxg@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ray.huang@amd.com \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).