From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFE0DC7EE2A for ; Tue, 9 May 2023 07:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234779AbjEIHGv (ORCPT ); Tue, 9 May 2023 03:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235201AbjEIHGr (ORCPT ); Tue, 9 May 2023 03:06:47 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14104AD28 for ; Tue, 9 May 2023 00:06:37 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-307664010fdso4802670f8f.0 for ; Tue, 09 May 2023 00:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1683615995; x=1686207995; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=useBAoxrYFwGHlGULbrUpovVaQLb6iywksro7xdg1q0=; b=fZP2GHn4DPbtLB9U9ddJiVCa5mTnlQNHnfLoeLLIICTFhTP6H3OheMCsLlesKdlSjE oxU7n/iEvpzCiIYBayhdlJx0vjcsF5ikFN4zXIwD296y1TGVXwz9lO9zjYppSVQl+nN0 xgd6JUvZ32UxidXxTPFEPDuxgQ/X2ydDOHmPHO9scxbna8W/NFSPeDJtdXIHo3ymexpI ep52vrhEvlYwUgGOx/cdDvX1kJfm5x5sc2koohyYVOeWf/Q5Mxww/sb06tbAL+q/sPNa 0eFClRmYTi0tn/TtP8PBkUEdMFbpiX+WXktTpdlFF9cnNJVnyawqlUi+NQlMXW1WKr0u tKSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683615995; x=1686207995; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=useBAoxrYFwGHlGULbrUpovVaQLb6iywksro7xdg1q0=; b=DzwFsJ49YoCfGeMiqWFxDh3IvUR91wfwsrsi15DYrINqvopBJVNMrBhFtYKL5EbPkq 1LUsEExy3p4k7hIZsRx5KRdk/Sgm+npKMR0FGxbtEhMhDnHRWly7RiPxgQEWr6eQyPH/ M/cuYvGCuHnXLgAYUDiH/jFAT/4xu2ky2+ahPafeuxQ/z6D81+WlvnIhLugz0MT/3EtX 05BZqpkF3KbltpZhoeH6+bDOXySERiGCpGCatK2US7CxxloQtEtKtDkFZr5f6RiAyQK6 OwHPcgTYko8Pw7Ll3SyDHMHHk+9SVTvld8ExfExCTOHUEjO0YDSvNZp3Nz9c+L7UL1lk Lapw== X-Gm-Message-State: AC+VfDzXMGDN8t9vgeBvGYxdlc934E2Iwdo1ZPFav7HzrzPhXlOBUfUZ yf6hM2s7i8wz/pjAuxAWpDLYozCXauMKy5HiFq3dhQ== X-Google-Smtp-Source: ACHHUZ48BETwgkFEHm8YnNvXMQpcpYVDJsRZesFXjLdWUvDZRdq9TUHfydeR5bG1gLliOkfOUxpETfIXCAorTp5K1Pw= X-Received: by 2002:a5d:6a47:0:b0:306:2d16:9b4f with SMTP id t7-20020a5d6a47000000b003062d169b4fmr9470428wrw.9.1683615995449; Tue, 09 May 2023 00:06:35 -0700 (PDT) MIME-Version: 1.0 References: <20230306100508.1171812-1-alexghiti@rivosinc.com> In-Reply-To: <20230306100508.1171812-1-alexghiti@rivosinc.com> From: Alexandre Ghiti Date: Tue, 9 May 2023 09:06:23 +0200 Message-ID: Subject: Re: [PATCH v5 00/26] Remove COMMAND_LINE_SIZE from uapi To: Greg KH , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Chris Zankel , Max Filippov , Arnd Bergmann , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org Hi Arnd, On Mon, Mar 6, 2023 at 11:05=E2=80=AFAM Alexandre Ghiti wrote: > > This all came up in the context of increasing COMMAND_LINE_SIZE in the > RISC-V port. In theory that's a UABI break, as COMMAND_LINE_SIZE is the > maximum length of /proc/cmdline and userspace could staticly rely on > that to be correct. > > Usually I wouldn't mess around with changing this sort of thing, but > PowerPC increased it with a5980d064fe2 ("powerpc: Bump COMMAND_LINE_SIZE > to 2048"). There are also a handful of examples of COMMAND_LINE_SIZE > increasing, but they're from before the UAPI split so I'm not quite sure > what that means: e5a6a1c90948 ("powerpc: derive COMMAND_LINE_SIZE from > asm-generic"), 684d2fd48e71 ("[S390] kernel: Append scpdata to kernel > boot command line"), 22242681cff5 ("MIPS: Extend COMMAND_LINE_SIZE"), > and 2b74b85693c7 ("sh: Derive COMMAND_LINE_SIZE from > asm-generic/setup.h."). > > It seems to me like COMMAND_LINE_SIZE really just shouldn't have been > part of the uapi to begin with, and userspace should be able to handle > /proc/cmdline of whatever length it turns out to be. I don't see any > references to COMMAND_LINE_SIZE anywhere but Linux via a quick Google > search, but that's not really enough to consider it unused on my end. > > This issue was already considered in s390 and they reached the same > conclusion in commit 622021cd6c56 ("s390: make command line > configurable"). > > The feedback on the v1 seemed to indicate that COMMAND_LINE_SIZE really > shouldn't be part of uapi, so this now touches all the ports. I've > tried to split this all out and leave it bisectable, but I haven't > tested it all that aggressively. > > Changes since v4 : > * Add my own SoB as suggested by Geert > * Add riscv patches as suggested by Bj=C3=B6rn > * Remove "WITH Linux-syscall-note" from new setup.h not in uapi/, as > suggested by Greg KH, his quoted answer below: > > "The "syscall note" makes no sense at all for any files not in the uapi/ > directory, so you can remove it just fine as that WITH doesn't mean > anything _UNLESS_ the file is in the uapi directory." > > Changes since v3 : > * Added RB/AB > * Added a mention to commit 622021cd6c56 ("s390: make command line > configurable") in the cover letter > > Changes since v2 : > * Fix sh, csky and ia64 builds, as reported by kernel test robot > > Changes since v1 : > * Touches every arch. > > base-commit-tag: next-20230207 > > Alexandre Ghiti (2): > riscv: Remove COMMAND_LINE_SIZE from uapi > riscv: Remove empty > > Palmer Dabbelt (24): > alpha: Remove COMMAND_LINE_SIZE from uapi > arm64: Remove COMMAND_LINE_SIZE from uapi > arm: Remove COMMAND_LINE_SIZE from uapi > ia64: Remove COMMAND_LINE_SIZE from uapi > m68k: Remove COMMAND_LINE_SIZE from uapi > microblaze: Remove COMMAND_LINE_SIZE from uapi > mips: Remove COMMAND_LINE_SIZE from uapi > parisc: Remove COMMAND_LINE_SIZE from uapi > powerpc: Remove COMMAND_LINE_SIZE from uapi > sparc: Remove COMMAND_LINE_SIZE from uapi > xtensa: Remove COMMAND_LINE_SIZE from uapi > asm-generic: Remove COMMAND_LINE_SIZE from uapi > alpha: Remove empty > arc: Remove empty > m68k: Remove empty > arm64: Remove empty > microblaze: Remove empty > sparc: Remove empty > parisc: Remove empty > x86: Remove empty > xtensa: Remove empty > powerpc: Remove empty > mips: Remove empty > s390: Remove empty > > .../admin-guide/kernel-parameters.rst | 2 +- > arch/alpha/include/asm/setup.h | 4 +-- > arch/alpha/include/uapi/asm/setup.h | 7 ----- > arch/arc/include/asm/setup.h | 1 - > arch/arc/include/uapi/asm/setup.h | 6 ----- > arch/arm/include/asm/setup.h | 1 + > arch/arm/include/uapi/asm/setup.h | 2 -- > arch/arm64/include/asm/setup.h | 3 ++- > arch/arm64/include/uapi/asm/setup.h | 27 ------------------- > arch/ia64/include/asm/setup.h | 10 +++++++ > arch/ia64/include/uapi/asm/setup.h | 6 ++--- > arch/loongarch/include/asm/setup.h | 2 +- > arch/m68k/include/asm/setup.h | 3 +-- > arch/m68k/include/uapi/asm/setup.h | 17 ------------ > arch/microblaze/include/asm/setup.h | 2 +- > arch/microblaze/include/uapi/asm/setup.h | 20 -------------- > arch/mips/include/asm/setup.h | 3 ++- > arch/mips/include/uapi/asm/setup.h | 8 ------ > arch/parisc/include/{uapi =3D> }/asm/setup.h | 2 +- > arch/powerpc/include/asm/setup.h | 2 +- > arch/powerpc/include/uapi/asm/setup.h | 7 ----- > arch/riscv/include/asm/setup.h | 7 +++++ > arch/riscv/include/uapi/asm/setup.h | 8 ------ > arch/s390/include/asm/setup.h | 1 - > arch/s390/include/uapi/asm/setup.h | 1 - > arch/sh/include/asm/setup.h | 2 +- > arch/sparc/include/asm/setup.h | 6 ++++- > arch/sparc/include/uapi/asm/setup.h | 16 ----------- > arch/x86/include/asm/setup.h | 2 -- > arch/x86/include/uapi/asm/setup.h | 1 - > arch/xtensa/include/{uapi =3D> }/asm/setup.h | 2 +- > include/asm-generic/Kbuild | 1 + > include/{uapi =3D> }/asm-generic/setup.h | 0 > include/uapi/asm-generic/Kbuild | 1 - > 34 files changed, 40 insertions(+), 143 deletions(-) > delete mode 100644 arch/alpha/include/uapi/asm/setup.h > delete mode 100644 arch/arc/include/uapi/asm/setup.h > delete mode 100644 arch/arm64/include/uapi/asm/setup.h > create mode 100644 arch/ia64/include/asm/setup.h > delete mode 100644 arch/m68k/include/uapi/asm/setup.h > delete mode 100644 arch/microblaze/include/uapi/asm/setup.h > delete mode 100644 arch/mips/include/uapi/asm/setup.h > rename arch/parisc/include/{uapi =3D> }/asm/setup.h (63%) > delete mode 100644 arch/powerpc/include/uapi/asm/setup.h > create mode 100644 arch/riscv/include/asm/setup.h > delete mode 100644 arch/riscv/include/uapi/asm/setup.h > delete mode 100644 arch/s390/include/uapi/asm/setup.h > delete mode 100644 arch/sparc/include/uapi/asm/setup.h > delete mode 100644 arch/x86/include/uapi/asm/setup.h > rename arch/xtensa/include/{uapi =3D> }/asm/setup.h (84%) > rename include/{uapi =3D> }/asm-generic/setup.h (100%) > > -- > 2.37.2 > I don't see this series in 6.4-rc1, I don't mean to bother you, I just want to make sure it did not get lost :) Thanks, Alex