From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA94C43381 for ; Tue, 16 Mar 2021 15:05:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32EDD65094 for ; Tue, 16 Mar 2021 15:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237718AbhCPPEl (ORCPT ); Tue, 16 Mar 2021 11:04:41 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:14352 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237688AbhCPPEM (ORCPT ); Tue, 16 Mar 2021 11:04:12 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F0GjJ5s2vz8ydQ; Tue, 16 Mar 2021 23:02:12 +0800 (CST) Received: from [10.174.177.244] (10.174.177.244) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Tue, 16 Mar 2021 23:04:03 +0800 Subject: Re: [PATCH] mm: Move mem_init_print_info() into mm_init() To: Christophe Leroy , , Andrew Morton CC: , , Peter Zijlstra , Catalin Marinas , "Dave Hansen" , , Guo Ren , , , Jonas Bonn , , Yoshinori Sato , , Huacai Chen , "Russell King" , , Ingo Molnar , , , Heiko Carstens , , , , , Richard Henderson , , , Palmer Dabbelt , , , "David S. Miller" References: <20210316142637.92193-1-wangkefeng.wang@huawei.com> <26cca1c0-bd38-3d5b-5ca4-44081c444396@csgroup.eu> From: Kefeng Wang Message-ID: Date: Tue, 16 Mar 2021 23:04:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <26cca1c0-bd38-3d5b-5ca4-44081c444396@csgroup.eu> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.244] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org On 2021/3/16 22:47, Christophe Leroy wrote: > > > Le 16/03/2021 à 15:26, Kefeng Wang a écrit : >> mem_init_print_info() is called in mem_init() on each architecture, >> and pass NULL argument, cleanup it by using void argument and move >> it into mm_init(). >> >> Signed-off-by: Kefeng Wang >> --- >>   arch/alpha/mm/init.c             | 1 - >>   arch/arc/mm/init.c               | 1 - >>   arch/arm/mm/init.c               | 2 -- >>   arch/arm64/mm/init.c             | 2 -- >>   arch/csky/mm/init.c              | 1 - >>   arch/h8300/mm/init.c             | 2 -- >>   arch/hexagon/mm/init.c           | 1 - >>   arch/ia64/mm/init.c              | 1 - >>   arch/m68k/mm/init.c              | 1 - >>   arch/microblaze/mm/init.c        | 1 - >>   arch/mips/loongson64/numa.c      | 1 - >>   arch/mips/mm/init.c              | 1 - >>   arch/mips/sgi-ip27/ip27-memory.c | 1 - >>   arch/nds32/mm/init.c             | 1 - >>   arch/nios2/mm/init.c             | 1 - >>   arch/openrisc/mm/init.c          | 2 -- >>   arch/parisc/mm/init.c            | 2 -- >>   arch/powerpc/mm/mem.c            | 1 - >>   arch/riscv/mm/init.c             | 1 - >>   arch/s390/mm/init.c              | 2 -- >>   arch/sh/mm/init.c                | 1 - >>   arch/sparc/mm/init_32.c          | 2 -- >>   arch/sparc/mm/init_64.c          | 1 - >>   arch/um/kernel/mem.c             | 1 - >>   arch/x86/mm/init_32.c            | 2 -- >>   arch/x86/mm/init_64.c            | 2 -- >>   arch/xtensa/mm/init.c            | 1 - >>   include/linux/mm.h               | 2 +- >>   init/main.c                      | 1 + >>   mm/page_alloc.c                  | 2 +- >>   30 files changed, 3 insertions(+), 38 deletions(-) >> > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 55d938297ce6..e4a6bf69c806 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -7728,7 +7728,7 @@ unsigned long free_reserved_area(void *start, >> void *end, int poison, const char >>       return pages; >>   } >>   -void __init mem_init_print_info(const char *str) >> +void __init mem_init_print_info(void) >>   { >>       unsigned long physpages, codesize, datasize, rosize, bss_size; >>       unsigned long init_code_size, init_data_size; >> > > And what about the 'str' in the last line of the function ? > >     pr_info("Memory: %luK/%luK available (%luK kernel code, %luK > rwdata, %luK rodata, %luK init, %luK bss, %luK reserved, %luK > cma-reserved" > #ifdef    CONFIG_HIGHMEM >         ", %luK highmem" > #endif >         "%s%s)\n", >         nr_free_pages() << (PAGE_SHIFT - 10), >         physpages << (PAGE_SHIFT - 10), >         codesize >> 10, datasize >> 10, rosize >> 10, >         (init_data_size + init_code_size) >> 10, bss_size >> 10, >         (physpages - totalram_pages() - totalcma_pages) << (PAGE_SHIFT > - 10), >         totalcma_pages << (PAGE_SHIFT - 10), > #ifdef    CONFIG_HIGHMEM >         totalhigh_pages() << (PAGE_SHIFT - 10), > #endif >         str ? ", " : "", str ? str : ""); oh,   I send a bad version，firstly I want to split two patches, one for function move, one for function change. sorry, please ignore it， thanks for your remind. > > > Christophe > . >