From: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
stable-rt <stable-rt@vger.kernel.org>
Subject: Re: kernel-rt: mm/memcg: refill_obj_stock() is being called from IRQ context
Date: Fri, 28 Apr 2023 15:00:29 -0300 [thread overview]
Message-ID: <ZEwJvU69mrXFu8Rg@uudg.org> (raw)
In-Reply-To: <20230428161910.meKaMkWu@linutronix.de>
On Fri, Apr 28, 2023 at 06:19:10PM +0200, Sebastian Andrzej Siewior wrote:
> On 2023-04-28 11:42:25 [-0300], Luis Claudio R. Goncalves wrote:
> > Sebastian et al,
> Hi,
>
> > I am reporting this here, at first, to confirm if there is an obvious solution
> > for the problem or if it is really a problem.
> >
> > In short, refill_obj_stock() is being called from IRQ context and lockdep
> > is complaining about the local lock stock_lock probably not being enough to
> > protect the data.
>
> This has been reported before and a patch has been posted
> https://lore.kernel.org/all/20230425114307.36889-1-wander@redhat.com/
>
> I don't like it but it should cure it.
Thank you! I both forgot about that thread and also missed that in my searches.
And yes, that's a solution for a different issue that fixes the problem I
reported as a side effect :)
I was torn between redoing the locking in that code or using something
similar to an old proposal from Wayman Long, where he had different
variables to account work on atomic and non-atomic contexts (which might
not be applicable here)
> Sebastian
>
---end quoted text---
prev parent reply other threads:[~2023-04-28 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 14:42 kernel-rt: mm/memcg: refill_obj_stock() is being called from IRQ context Luis Claudio R. Goncalves
2023-04-28 16:19 ` Sebastian Andrzej Siewior
2023-04-28 18:00 ` Luis Claudio R. Goncalves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEwJvU69mrXFu8Rg@uudg.org \
--to=lgoncalv@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=rostedt@goodmis.org \
--cc=stable-rt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).