From: Stefan Agner <stefan@agner.ch>
To: Jason Self <jason@bluehome.net>,
Greg KH <gregkh@linuxfoundation.org>,
Johannes Berg <johannes.berg@intel.com>
Cc: stable@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: Regression/boot failure on 5.16.3
Date: Tue, 08 Feb 2022 09:50:59 +0100 [thread overview]
Message-ID: <00b41f5de94fca5ef995ab2c95def4aa@agner.ch> (raw)
In-Reply-To: <20220203161959.3edf1d6e@valencia>
On 2022-02-04 01:19, Jason Self wrote:
> The computer (amd64) fails to boot. The init was stuck at the
> synchronization of the time through the network. This began between
> 5.16.2 (good) and 5.16.3 (bad.) This continues on 5.16.4 and 5.16.5.
> Git bisect revealed the following. In this case the nonfree firmwre is
> not present on the system. Blacklisting the iwflwifi module works as a
> workaround for now.
I have several reports of Intel NUC 10th/11th gen not booting/crashing
during boot after updating to 5.10.96 (from 5.10.91). At least one stack
trace shows iwl_dealloc_ucode in the call path. The below commit is part
of 5.10.96 So this regression seems to not only affect 5.16 series.
Link:
https://github.com/home-assistant/operating-system/issues/1739#issuecomment-1032013069
--
Stefan
>
> 6b5ad4bd0d78fef6bbe0ecdf96e09237c9c52cc1 is the first bad commit
> commit 6b5ad4bd0d78fef6bbe0ecdf96e09237c9c52cc1
> Author: Johannes Berg <johannes.berg@intel.com>
> Date: Fri Dec 10 11:12:42 2021 +0200
>
> iwlwifi: fix leaks/bad data after failed firmware load
>
> [ Upstream commit ab07506b0454bea606095951e19e72c282bfbb42 ]
>
> If firmware load fails after having loaded some parts of the
> firmware, e.g. the IML image, then this would leak. For the
> host command list we'd end up running into a WARN on the next
> attempt to load another firmware image.
>
> Fix this by calling iwl_dealloc_ucode() on failures, and make
> that also clear the data so we start fresh on the next round.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> Link:
>
> https://lore.kernel.org/r/iwlwifi.20211210110539.1f742f0eb58a.I1315f22f6aa632d94ae2069f85e1bca5e734dce0@changeid
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
next prev parent reply other threads:[~2022-02-08 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 0:19 Regression/boot failure on 5.16.3 Jason Self
2022-02-04 7:00 ` Greg KH
2022-02-04 8:48 ` Thorsten Leemhuis
2022-02-08 8:50 ` Stefan Agner [this message]
2022-02-08 18:05 ` Jason Self
2022-02-08 18:22 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00b41f5de94fca5ef995ab2c95def4aa@agner.ch \
--to=stefan@agner.ch \
--cc=gregkh@linuxfoundation.org \
--cc=jason@bluehome.net \
--cc=johannes.berg@intel.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).