Stable Archive on lore.kernel.org
 help / color / Atom feed
From: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)"  <longpeng2@huawei.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<kvm@vger.kernel.org>, <arei.gonglei@huawei.com>,
	<weidong.huang@huawei.com>, <weifuqiang@huawei.com>,
	<kirill.shutemov@linux.intel.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Matthew Wilcox" <willy@infradead.org>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v3] mm/hugetlb: fix a addressing exception caused by huge_pte_offset
Date: Sat, 28 Mar 2020 07:32:27 +0800
Message-ID: <0d8771ec-9661-9ef4-0972-4dadf548487b@huawei.com> (raw)
In-Reply-To: <20200327121100.GR20941@ziepe.ca>



On 2020/3/27 20:11, Jason Gunthorpe wrote:
> On Fri, Mar 27, 2020 at 09:40:07AM +0800, Longpeng(Mike) wrote:
>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>> index dd8737a..d4fab68 100644
>> +++ b/mm/hugetlb.c
>> @@ -4909,29 +4909,33 @@ pte_t *huge_pte_offset(struct mm_struct *mm,
>>  		       unsigned long addr, unsigned long sz)
>>  {
>>  	pgd_t *pgd;
>> -	p4d_t *p4d;
>> -	pud_t *pud;
>> -	pmd_t *pmd;
>> +	p4d_t *p4g, p4d_entry;
>> +	pud_t *pud, pud_entry;
>> +	pmd_t *pmd, pmd_entry;
>>  
>>  	pgd = pgd_offset(mm, addr);
>>  	if (!pgd_present(*pgd))
>>  		return NULL;
>> -	p4d = p4d_offset(pgd, addr);
>> -	if (!p4d_present(*p4d))
>> +
>> +	p4g = p4d_offset(pgd, addr);
> 
> Why p4g here? Shouldn't it be p4d?
> 
Sorry, it's a typo, I'll send v4

> Jason
> .
> 

---
Regards,
Longpeng(Mike)

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  1:40 Longpeng(Mike)
2020-03-27 12:11 ` Jason Gunthorpe
2020-03-27 23:32   ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.) [this message]
2020-03-27 15:03 ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d8771ec-9661-9ef4-0972-4dadf548487b@huawei.com \
    --to=longpeng2@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=arei.gonglei@huawei.com \
    --cc=jgg@ziepe.ca \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=weidong.huang@huawei.com \
    --cc=weifuqiang@huawei.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Stable Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://lore.kernel.org/stable \
		stable@vger.kernel.org
	public-inbox-index stable

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git