From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C6FC0650F for ; Sun, 11 Aug 2019 14:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56FA72085B for ; Sun, 11 Aug 2019 14:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565535234; bh=AdCwgoYTalPpnlFQVOB75E82F+MhnDcfcQVfLs61G9U=; h=Subject:To:Cc:From:Date:List-ID:From; b=iKJZV2UOCn1Js50grx7iApuB4XZM7mg/yYk43s/EXvRNLAT5Q2RUiwqoDYm37B9jK hE28z+qPKSdKPu1KcrMwDsAo65REiB0gfNfr716cdTYHo84+rFsltT6DY4hAHRrGh7 6qHHSxhBOji6J9Mdzz8UG8rxXjFp2HVYoY/YZmYo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726452AbfHKOxx (ORCPT ); Sun, 11 Aug 2019 10:53:53 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:40969 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbfHKOxx (ORCPT ); Sun, 11 Aug 2019 10:53:53 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 67831377; Sun, 11 Aug 2019 10:53:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 11 Aug 2019 10:53:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=eCns1B LDJJj/JrAnxoh252Sq9kRE3uVDQ07jDUx9MQU=; b=KAY6Mb/NB4+1wZr1nNdmc9 xQ4KDSZHmorlxqVYNQqrf7AzPgHVWU83X5eYPNZ3gGi1aIlyYZA34uJ8iBqJOg6W 9/uBW/ZNFcFU3wlMJWxdI5CsG/DlBeZpzWAwqtX6C0xk+6mNbSH5yX2+HdW026mo DMZYwqYoflDVVL/gki10wXQZKtrcTy1LWve1y2g92MmYPw1Xa34rASf8C6zP6WbM Cv6cWDmAx9vsw0cxiaaKL5EO4R3/c2OJsLr3yz0MvIzMCIpCeLTuVIWzMyx/vLRY xxlx4ujYwPUwytRKMd/9OtdKcei12VNcF0cr9SE3nSaw20IFHjFZEq+1/M/tMC+w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddvvddgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecukfhppeekfedrkeeirdekledruddtjeenucfrrghrrghmpehmrghilhhfrhhomh epghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 2BF1E380074; Sun, 11 Aug 2019 10:53:48 -0400 (EDT) Subject: FAILED: patch "[PATCH] iio: adc: gyroadc: fix uninitialized return code" failed to apply to 4.19-stable tree To: arnd@arndb.de, Jonathan.Cameron@huawei.com, wsa+renesas@sang-engineering.com Cc: From: Date: Sun, 11 Aug 2019 16:53:46 +0200 Message-ID: <156553522611126@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 90c6260c1905a68fb596844087f2223bd4657fee Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Thu, 18 Jul 2019 15:57:49 +0200 Subject: [PATCH] iio: adc: gyroadc: fix uninitialized return code gcc-9 complains about a blatant uninitialized variable use that all earlier compiler versions missed: drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] Return -EINVAL instead here and a few lines above it where we accidentally return 0 on failure. Cc: stable@vger.kernel.org Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver") Signed-off-by: Arnd Bergmann Reviewed-by: Wolfram Sang Signed-off-by: Jonathan Cameron diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c index 2d685730f867..c37f201294b2 100644 --- a/drivers/iio/adc/rcar-gyroadc.c +++ b/drivers/iio/adc/rcar-gyroadc.c @@ -382,7 +382,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) dev_err(dev, "Only %i channels supported with %pOFn, but reg = <%i>.\n", num_channels, child, reg); - return ret; + return -EINVAL; } } @@ -391,7 +391,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) dev_err(dev, "Channel %i uses different ADC mode than the rest.\n", reg); - return ret; + return -EINVAL; } /* Channel is valid, grab the regulator. */