From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B913C10F14 for ; Thu, 10 Oct 2019 09:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6577E21D7B for ; Thu, 10 Oct 2019 09:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570699245; bh=6klYKX7TZgVO+s+6Ag9mYzcuqsdR7zxXzveAonCirzw=; h=Subject:To:From:Date:List-ID:From; b=QgaVQLGGGJwgWlBTo02rZXcOTAPDPd57qA7AiUGrgHaPvyyTTXT1vlnLGVvxFncdn 0UPUByHX47duikgflza+yPy1XvqKX5N5CWo+g52caaVhv/aokRvs4SMxKfBlSGP9Cg iDhLWTkT3GtV4MSsY0TL+1nusHHzpnlQKEuoi45Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387900AbfJJJUp (ORCPT ); Thu, 10 Oct 2019 05:20:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:43424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387478AbfJJJUo (ORCPT ); Thu, 10 Oct 2019 05:20:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A181D21D6C; Thu, 10 Oct 2019 09:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570699244; bh=6klYKX7TZgVO+s+6Ag9mYzcuqsdR7zxXzveAonCirzw=; h=Subject:To:From:Date:From; b=eiJE1XqTj1r+NGq/6ONAv6geRk6N8J6eNxbKYDX9TqqwsvjQ5SqC9jET5UJZsSf+i +raG9MXHEsLfx5VbNKDp9gl0LqB53UtKuW69YL3OWyqM4MyrAEpYLjP8CtEQ7XTPt/ tJChlwCnoXoGw5HES8dQ0/9mM0aMd0KTUY7zPFjw= Subject: patch "iio: adc: ad799x: fix probe error handling" added to staging-linus To: m.felsch@pengutronix.de, Jonathan.Cameron@huawei.com, Stable@vger.kernel.org, alexandru.ardelean@analog.com From: Date: Thu, 10 Oct 2019 11:20:08 +0200 Message-ID: <157069920823223@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is a note to let you know that I've just added the patch titled iio: adc: ad799x: fix probe error handling to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From c62dd44901cfff12acc5792bf3d2dec20bcaf392 Mon Sep 17 00:00:00 2001 From: Marco Felsch Date: Tue, 17 Sep 2019 18:09:23 +0200 Subject: iio: adc: ad799x: fix probe error handling Since commit 0f7ddcc1bff1 ("iio:adc:ad799x: Write default config on probe and reset alert status on probe") the error path is wrong since it leaves the vref regulator on. Fix this by disabling both regulators. Fixes: 0f7ddcc1bff1 ("iio:adc:ad799x: Write default config on probe and reset alert status on probe") Signed-off-by: Marco Felsch Reviewed-by: Alexandru Ardelean Cc: Signed-off-by: Jonathan Cameron --- drivers/iio/adc/ad799x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c index 5a3ca5904ded..f658012baad8 100644 --- a/drivers/iio/adc/ad799x.c +++ b/drivers/iio/adc/ad799x.c @@ -810,10 +810,10 @@ static int ad799x_probe(struct i2c_client *client, ret = ad799x_write_config(st, st->chip_config->default_config); if (ret < 0) - goto error_disable_reg; + goto error_disable_vref; ret = ad799x_read_config(st); if (ret < 0) - goto error_disable_reg; + goto error_disable_vref; st->config = ret; ret = iio_triggered_buffer_setup(indio_dev, NULL, -- 2.23.0