From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A05C43331 for ; Mon, 11 Nov 2019 09:43:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1A8F2075B for ; Mon, 11 Nov 2019 09:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbfKKJnP convert rfc822-to-8bit (ORCPT ); Mon, 11 Nov 2019 04:43:15 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:54507 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726770AbfKKJnP (ORCPT ); Mon, 11 Nov 2019 04:43:15 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19156572-1500050 for multiple; Mon, 11 Nov 2019 09:43:14 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <0285daa4-eeb5-b1e1-8b4d-d7220024d429@linux.intel.com> Cc: stable@vger.kernel.org References: <20191109105356.5273-1-chris@chris-wilson.co.uk> <0285daa4-eeb5-b1e1-8b4d-d7220024d429@linux.intel.com> Message-ID: <157346538997.28106.15260731624402142184@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles Date: Mon, 11 Nov 2019 09:43:10 +0000 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Quoting Tvrtko Ursulin (2019-11-11 09:11:03) > > On 09/11/2019 10:53, Chris Wilson wrote: > > We report "frequencies" (actual-frequency, requested-frequency) as the > > number of accumulated cycles so that the average frequency over that > > period may be determined by the user. This means the units we report to > > the user are Mcycles (or just M), not MHz. > > > > Signed-off-by: Chris Wilson > > Cc: Tvrtko Ursulin > > Cc: stable@vger.kernel.org > > --- > > drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > > index 4804775644bf..9b02be0ad4e6 100644 > > --- a/drivers/gpu/drm/i915/i915_pmu.c > > +++ b/drivers/gpu/drm/i915/i915_pmu.c > > @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) > > const char *name; > > const char *unit; > > } events[] = { > > - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), > > - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), > > + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), > > + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), > > __event(I915_PMU_INTERRUPTS, "interrupts", NULL), > > __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), > > }; > > > > MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? The only place where "cycles" pops up is in the perf ui, the other events that I thought were similar in nature are unitless. As the 'cycle' itself is not an SI base unit as it is a mere count. ~o~ I have no idea ~o~ -Chris