From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF9ECC433F5 for ; Fri, 29 Apr 2022 12:45:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359319AbiD2MtL (ORCPT ); Fri, 29 Apr 2022 08:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241199AbiD2MtJ (ORCPT ); Fri, 29 Apr 2022 08:49:09 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2E808BF16 for ; Fri, 29 Apr 2022 05:45:51 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id a11so6838927pff.1 for ; Fri, 29 Apr 2022 05:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=ocs0mbwWAgp+tAzV857SlK6UIswo55neeWcWC4SY3Dg=; b=M75tT7fYDZfjp2tooPLlxMQYQCHtfgnPjxrcG9sjO42fIEVdkZaBnWBzOBXOEmYC9W JabKq23L0OLWu8ahSAEd6NPC3Sfeq91RQmUzFmjWiz4Ws889UkTQi1Fk81nTagfrlfWu K23tTRDPhdroVfIEBbspC8P+AglAXcN+MIvl8wK2OmLa5DHdQ/3VwU6N16EHIuBeYRKi OPJGTUV5KkJ+9ELMNfwH+ihmvDC1E9uPkW9uTbSx2wp8H0o0P+TbBP3ECVmyi4BaHlRb 08sKokJAjEYkmy3pUBk8kB/Y18B8zN3n6WJqZ5QD1zgR+qTs1qncEBVKors9RsYHTRoN aukg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=ocs0mbwWAgp+tAzV857SlK6UIswo55neeWcWC4SY3Dg=; b=uOrzxwD/jcp6KIJDCnwkyWB7NoqdrYBIyBLPEatbMukQQcCe/Vy73Y58xTVb8GM+Nx gpdPnAyKocACuvPLaXUYrBu5YiypNet6QhZrkrUfPbcnkh4e0D7eVsn8A7lesEB/nsUr kFQwqgenSIaPvzR5sP6wyIlfguy9iJrUh8k9g4LyBZoknXRXW8Wi1fhNzPafIw/WYGFz PEPwQVAz+RSSu38SdNA8BA6YG8vJntHI7bfyTIRigWvBOsRgvtNxt5U04zFsFAsiZeQn EBv7bi6ckJkV6rl1L8IZ8XSTAATp04G92kuYsYOhTPgCmEh6DeDSDRkBiTGWZaAUcwY0 FHRw== X-Gm-Message-State: AOAM531h/2tT2RA0/Urk9FoUrgrrxOOmYqFyXOz8QbxiCWeuquvNbAI4 XAOO+48mqVSkQpYXKvZpURpjHA== X-Google-Smtp-Source: ABdhPJwKlSzZpHDij9KxX7qhr19A8CctJ49N5nK9OCJnkYsL5jYSRcGt1HiFqXKIJmXzYMOH6YWc1Q== X-Received: by 2002:a05:6a00:1749:b0:50a:8eed:b824 with SMTP id j9-20020a056a00174900b0050a8eedb824mr39902311pfc.50.1651236351379; Fri, 29 Apr 2022 05:45:51 -0700 (PDT) Received: from [127.0.1.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id x186-20020a6363c3000000b003c14af505f6sm6010824pgb.14.2022.04.29.05.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 05:45:50 -0700 (PDT) From: Jens Axboe To: jack@suse.cz, paolo.valente@linaro.org Cc: yukuai3@huawei.com, stable@vger.kernel.org, linux-block@vger.kernel.org, lists@colorremedies.com In-Reply-To: <20220407140738.9723-1-jack@suse.cz> References: <20220407140738.9723-1-jack@suse.cz> Subject: Re: [PATCH] bfq: Fix warning in bfqq_request_over_limit() Message-Id: <165123635009.46786.3093085989076098329.b4-ty@kernel.dk> Date: Fri, 29 Apr 2022 06:45:50 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 7 Apr 2022 16:07:38 +0200, Jan Kara wrote: > People are occasionally reporting a warning bfqq_request_over_limit() > triggering reporting that BFQ's idea of cgroup hierarchy (and its depth) > does not match what generic blkcg code thinks. This can actually happen > when bfqq gets moved between BFQ groups while bfqq_request_over_limit() > is running. Make sure the code is safe against BFQ queue being moved to > a different BFQ group. > > [...] Applied, thanks! [1/1] bfq: Fix warning in bfqq_request_over_limit() commit: 09df6a75fffa68169c5ef9bef990cd7ba94f3eef Best regards, -- Jens Axboe