From: Rob Herring <robh@kernel.org>
To: "Isaac J. Manjarres" <isaacmanjarres@google.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
stable@vger.kernel.org, Saravana Kannan <saravanak@google.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Calvin Zhang <calvinzhang.cool@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Catalin Marinas <catalin.marinas@arm.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] Revert "mm: kmemleak: alloc gray object for reserved region with direct map"
Date: Fri, 27 Jan 2023 15:38:05 -0600 [thread overview]
Message-ID: <167485548359.726924.14589412750691974893.robh@kernel.org> (raw)
In-Reply-To: <20230124230254.295589-1-isaacmanjarres@google.com>
On Tue, 24 Jan 2023 15:02:54 -0800, Isaac J. Manjarres wrote:
> This reverts commit 972fa3a7c17c9d60212e32ecc0205dc585b1e769.
>
> Kmemleak operates by periodically scanning memory regions for pointers
> to allocated memory blocks to determine if they are leaked or not.
> However, reserved memory regions can be used for DMA transactions
> between a device and a CPU, and thus, wouldn't contain pointers to
> allocated memory blocks, making them inappropriate for kmemleak to
> scan. Thus, revert this commit.
>
> Cc: stable@vger.kernel.org # 5.17+
> Cc: Calvin Zhang <calvinzhang.cool@gmail.com>
> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
> ---
> drivers/of/fdt.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2023-01-27 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 23:02 [PATCH v1] Revert "mm: kmemleak: alloc gray object for reserved region with direct map" Isaac J. Manjarres
2023-01-25 13:29 ` Catalin Marinas
2023-01-27 21:38 ` Rob Herring [this message]
2023-01-27 21:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167485548359.726924.14589412750691974893.robh@kernel.org \
--to=robh@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=calvinzhang.cool@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=isaacmanjarres@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).