stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH bpf-next] bpf: Fix comment for helper bpf_current_task_under_cgroup()
@ 2022-03-10 15:53 Hengqi Chen
  2022-03-10 16:29 ` Yonghong Song
  2022-03-10 22:10 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 5+ messages in thread
From: Hengqi Chen @ 2022-03-10 15:53 UTC (permalink / raw)
  To: bpf; +Cc: hengqi.chen, stable

Fix the descriptions of the return values of helper
bpf_current_task_under_cgroup().

Fixes: c6b5fb8690fa ("bpf: add documentation for eBPF helpers (42-50)")
Cc: <stable@vger.kernel.org>
Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
---
 include/uapi/linux/bpf.h       | 4 ++--
 tools/include/uapi/linux/bpf.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index bc23020b638d..374db485f063 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -2302,8 +2302,8 @@ union bpf_attr {
  * 	Return
  * 		The return value depends on the result of the test, and can be:
  *
- *		* 0, if current task belongs to the cgroup2.
- *		* 1, if current task does not belong to the cgroup2.
+ *		* 1, if current task belongs to the cgroup2.
+ *		* 0, if current task does not belong to the cgroup2.
  * 		* A negative error code, if an error occurred.
  *
  * long bpf_skb_change_tail(struct sk_buff *skb, u32 len, u64 flags)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index bc23020b638d..374db485f063 100644
--- a/tools/include/uapi/linux/bpf.h
+++ b/tools/include/uapi/linux/bpf.h
@@ -2302,8 +2302,8 @@ union bpf_attr {
  * 	Return
  * 		The return value depends on the result of the test, and can be:
  *
- *		* 0, if current task belongs to the cgroup2.
- *		* 1, if current task does not belong to the cgroup2.
+ *		* 1, if current task belongs to the cgroup2.
+ *		* 0, if current task does not belong to the cgroup2.
  * 		* A negative error code, if an error occurred.
  *
  * long bpf_skb_change_tail(struct sk_buff *skb, u32 len, u64 flags)
--
2.30.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next] bpf: Fix comment for helper bpf_current_task_under_cgroup()
  2022-03-10 15:53 [PATCH bpf-next] bpf: Fix comment for helper bpf_current_task_under_cgroup() Hengqi Chen
@ 2022-03-10 16:29 ` Yonghong Song
  2022-03-10 22:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 5+ messages in thread
From: Yonghong Song @ 2022-03-10 16:29 UTC (permalink / raw)
  To: Hengqi Chen, bpf; +Cc: stable



On 3/10/22 7:53 AM, Hengqi Chen wrote:
> Fix the descriptions of the return values of helper
> bpf_current_task_under_cgroup().
> 
> Fixes: c6b5fb8690fa ("bpf: add documentation for eBPF helpers (42-50)")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>

Acked-by: Yonghong Song <yhs@fb.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next] bpf: Fix comment for helper bpf_current_task_under_cgroup()
  2022-03-10 15:53 [PATCH bpf-next] bpf: Fix comment for helper bpf_current_task_under_cgroup() Hengqi Chen
  2022-03-10 16:29 ` Yonghong Song
@ 2022-03-10 22:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-10 22:10 UTC (permalink / raw)
  To: Hengqi Chen; +Cc: bpf, stable

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Thu, 10 Mar 2022 23:53:35 +0800 you wrote:
> Fix the descriptions of the return values of helper
> bpf_current_task_under_cgroup().
> 
> Fixes: c6b5fb8690fa ("bpf: add documentation for eBPF helpers (42-50)")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf: Fix comment for helper bpf_current_task_under_cgroup()
    https://git.kernel.org/bpf/bpf-next/c/58617014405a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH bpf-next] bpf: fix comment for helper bpf_current_task_under_cgroup()
  2020-09-10 20:33 [PATCH bpf-next] bpf: fix " Song Liu
@ 2020-09-11  3:10 ` Alexei Starovoitov
  0 siblings, 0 replies; 5+ messages in thread
From: Alexei Starovoitov @ 2020-09-11  3:10 UTC (permalink / raw)
  To: Song Liu; +Cc: bpf, stable

On Thu, Sep 10, 2020 at 1:36 PM Song Liu <songliubraving@fb.com> wrote:
>
> This should be "current" not "skb".
>
> Fixes: c6b5fb8690fa ("bpf: add documentation for eBPF helpers (42-50)")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Song Liu <songliubraving@fb.com>

Applied. Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH bpf-next] bpf: fix comment for helper bpf_current_task_under_cgroup()
@ 2020-09-10 20:33 Song Liu
  2020-09-11  3:10 ` Alexei Starovoitov
  0 siblings, 1 reply; 5+ messages in thread
From: Song Liu @ 2020-09-10 20:33 UTC (permalink / raw)
  To: bpf; +Cc: Song Liu, stable

This should be "current" not "skb".

Fixes: c6b5fb8690fa ("bpf: add documentation for eBPF helpers (42-50)")
Cc: <stable@vger.kernel.org>
Signed-off-by: Song Liu <songliubraving@fb.com>
---
 include/uapi/linux/bpf.h       | 4 ++--
 tools/include/uapi/linux/bpf.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index 90359cab501d1..7dd314176df76 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -1447,8 +1447,8 @@ union bpf_attr {
  * 	Return
  * 		The return value depends on the result of the test, and can be:
  *
- * 		* 0, if the *skb* task belongs to the cgroup2.
- * 		* 1, if the *skb* task does not belong to the cgroup2.
+ *		* 0, if current task belongs to the cgroup2.
+ *		* 1, if current task does not belong to the cgroup2.
  * 		* A negative error code, if an error occurred.
  *
  * long bpf_skb_change_tail(struct sk_buff *skb, u32 len, u64 flags)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 90359cab501d1..7dd314176df76 100644
--- a/tools/include/uapi/linux/bpf.h
+++ b/tools/include/uapi/linux/bpf.h
@@ -1447,8 +1447,8 @@ union bpf_attr {
  * 	Return
  * 		The return value depends on the result of the test, and can be:
  *
- * 		* 0, if the *skb* task belongs to the cgroup2.
- * 		* 1, if the *skb* task does not belong to the cgroup2.
+ *		* 0, if current task belongs to the cgroup2.
+ *		* 1, if current task does not belong to the cgroup2.
  * 		* A negative error code, if an error occurred.
  *
  * long bpf_skb_change_tail(struct sk_buff *skb, u32 len, u64 flags)
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-10 22:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 15:53 [PATCH bpf-next] bpf: Fix comment for helper bpf_current_task_under_cgroup() Hengqi Chen
2022-03-10 16:29 ` Yonghong Song
2022-03-10 22:10 ` patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2020-09-10 20:33 [PATCH bpf-next] bpf: fix " Song Liu
2020-09-11  3:10 ` Alexei Starovoitov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).