From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E4CC433E0 for ; Fri, 19 Mar 2021 12:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A688064E60 for ; Fri, 19 Mar 2021 12:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230104AbhCSMpZ (ORCPT ); Fri, 19 Mar 2021 08:45:25 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:43377 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbhCSMpL (ORCPT ); Fri, 19 Mar 2021 08:45:11 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F23Wp06NKz1qsZq; Fri, 19 Mar 2021 13:45:09 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F23Wn63ljz1sP6n; Fri, 19 Mar 2021 13:45:09 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id EyYRDuUuRATy; Fri, 19 Mar 2021 13:45:08 +0100 (CET) X-Auth-Info: L7ugS05+sR0la3nUOJWkAnOA++zMYDEjAMB7qSt8ojA= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 19 Mar 2021 13:45:08 +0100 (CET) Subject: Re: [PATCH 5.11 12/31] gpiolib: Read "gpio-line-names" from a firmware node To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Roman Guskov , Andy Shevchenko , Bartosz Golaszewski , Sasha Levin References: <20210319121747.203523570@linuxfoundation.org> <20210319121747.594813307@linuxfoundation.org> <5c3f2fb9-c1bf-5939-2e83-8cd0fa6d0c20@denx.de> From: Marek Vasut Message-ID: <1950c577-51e6-34f1-a4cd-ea46c736fc30@denx.de> Date: Fri, 19 Mar 2021 13:45:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 3/19/21 1:36 PM, Greg Kroah-Hartman wrote: > On Fri, Mar 19, 2021 at 01:27:23PM +0100, Marek Vasut wrote: >> On 3/19/21 1:19 PM, Greg Kroah-Hartman wrote: >>> From: Andy Shevchenko >>> >>> [ Upstream commit b41ba2ec54a70908067034f139aa23d0dd2985ce ] >>> >>> On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, >>> see arch/arm/boot/dts/stm32mp151.dtsi. The driver for >>> pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c >>> and iterates over all of its DT subnodes when registering each GPIO >>> bank gpiochip. Each gpiochip has: >>> >>> - gpio_chip.parent = dev, >>> where dev is the device node of the pin controller >>> - gpio_chip.of_node = np, >>> which is the OF node of the GPIO bank >>> >>> Therefore, dev_fwnode(chip->parent) != of_fwnode_handle(chip.of_node), >>> i.e. pin-controller@50002000 != pin-controller@50002000/gpio@5000*000. >>> >>> The original code behaved correctly, as it extracted the "gpio-line-names" >>> from of_fwnode_handle(chip.of_node) = pin-controller@50002000/gpio@5000*000. >>> >>> To achieve the same behaviour, read property from the firmware node. >> >> I think we agreed to drop this one for now before, see >> [PATCH 5.10 081/290] gpiolib: Read "gpio-line-names" from a firmware node >> Message-ID: > > Sorry, now dropped. Again. No worries, good thing we have the review process in place :)