From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C936C43381 for ; Mon, 25 Mar 2019 17:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2475207DD for ; Mon, 25 Mar 2019 17:10:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Sony.onmicrosoft.com header.i=@Sony.onmicrosoft.com header.b="emqge7uh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729632AbfCYRIF (ORCPT ); Mon, 25 Mar 2019 13:08:05 -0400 Received: from mail-eopbgr780110.outbound.protection.outlook.com ([40.107.78.110]:24769 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725788AbfCYRIE (ORCPT ); Mon, 25 Mar 2019 13:08:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Sony.onmicrosoft.com; s=selector1-Sony-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U1TH4Xe/Xxcnn7RBhidKn9y8eIgysESxHjEIdxqRNwE=; b=emqge7uhIU+9N1YubGDqsaClSTbb0gYjeviYCjdUuEV/VpExoxzc6nswyn8HoRQT2BVBkZbiFVhob9jZcskuUQdGO13ujEus+qUryuhftHFiLp2io/+Z0CPgQgX706KuajnyNk8kGcFLzRagi6/znZk45l5JKDNhJCUdKMM69mc= Received: from MWHPR13CA0028.namprd13.prod.outlook.com (2603:10b6:300:95::14) by MWHPR13MB1407.namprd13.prod.outlook.com (2603:10b6:300:123::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.14; Mon, 25 Mar 2019 17:08:02 +0000 Received: from CY1NAM02FT034.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::206) by MWHPR13CA0028.outlook.office365.com (2603:10b6:300:95::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1750.12 via Frontend Transport; Mon, 25 Mar 2019 17:08:02 +0000 Received-SPF: PermError (protection.outlook.com: domain of sony.com used an invalid SPF mechanism) Received: from usculsndmail04v.am.sony.com (160.33.194.231) by CY1NAM02FT034.mail.protection.outlook.com (10.152.75.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1730.9 via Frontend Transport; Mon, 25 Mar 2019 17:08:01 +0000 Received: from usculsndmail12v.am.sony.com (usculsndmail12v.am.sony.com [146.215.230.103]) by usculsndmail04v.am.sony.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id x2PH80kb001330; Mon, 25 Mar 2019 17:08:00 GMT Received: from USCULXHUB07V.am.sony.com (hub.bc.in.sel.sony.com [146.215.231.168]) by usculsndmail12v.am.sony.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id x2PH80a0000932; Mon, 25 Mar 2019 17:08:00 GMT Received: from USCULXMSG13.am.sony.com ([146.215.231.78]) by USCULXHUB07V.am.sony.com ([146.215.231.168]) with mapi id 14.03.0439.000; Mon, 25 Mar 2019 13:08:00 -0400 From: To: , CC: , Subject: RE: "HID: sony: Update device ids" Patch breaks bluetooth connectivity on 4.4.x Thread-Topic: "HID: sony: Update device ids" Patch breaks bluetooth connectivity on 4.4.x Thread-Index: AQFw+DiTKHJCTtbNogvg06komEvQfabkaf49 Date: Mon, 25 Mar 2019 17:07:59 +0000 Message-ID: <1DD62093774CEE42AFC16E785A108804ABEB6989@USCULXMSG13.am.sony.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [146.215.231.6] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:160.33.194.231;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10019020)(376002)(346002)(136003)(396003)(39860400002)(2980300002)(448002)(199004)(189003)(33656002)(26005)(186003)(97756001)(486006)(426003)(15650500001)(336012)(476003)(11346002)(956004)(446003)(126002)(86362001)(85326001)(46406003)(50466002)(55846006)(66066001)(110136005)(54906003)(53546011)(47776003)(7696005)(76176011)(2876002)(23726003)(3846002)(106466001)(72206003)(8936002)(966005)(478600001)(102836004)(14444005)(8676002)(316002)(55016002)(356004)(8746002)(86152003)(6306002)(6246003)(37786003)(4326008)(5660300002)(7736002)(246002)(229853002)(6346003)(2906002)(6116002)(305945005)(2101003)(5001870100001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR13MB1407;H:usculsndmail04v.am.sony.com;FPR:;SPF:PermError;LANG:en;PTR:mail04.sonyusa.com,mail.sonyusa.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04a4f318-fd56-4d7f-c906-08d6b1447072 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7193020);SRVR:MWHPR13MB1407; X-MS-TrafficTypeDiagnostic: MWHPR13MB1407: X-MS-Exchange-PUrlCount: 1 X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0987ACA2E2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: vgjNKPJ26ESnUYn1KAwtvtqNmJpMOEOvUJWZNRiUnMF7KmOC++M/6tHcjbZ/OihZiIJsqiIMVrZRgdNmaD7EPBijlQeW4xKaFHvuGlrnHtZZjwhgMw8IYWeINFIPuoDYS/7NFiDdtDoZStvA+x1HphCpb5VI+HZM6gsrKJCSb6RGTUCX1ZkYbgsefexQoQvWCb08f0fkTFtsYLlEXe/tRHuv40AJ0OZ7ri8qf6iO0IP3u99mkXdY2EmPBxHhlts/RkSZI/rrb54eo+AppYPkEzEn5zVT+CeaNbI1JH2P0+Q0nxrScVXhXpc5dOqmuwLabrS6ROMJa0QfdFT5MYtz4KVsvVRmvb426R8mYKMQrwWGe33YwEnKtQux4kia22axsRPYb61aZYYmzvUycli9ssEnPGZFV8DEnkNm1cXJU/M= X-OriginatorOrg: sony.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2019 17:08:01.8414 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04a4f318-fd56-4d7f-c906-08d6b1447072 X-MS-Exchange-CrossTenant-Id: 66c65d8a-9158-4521-a2d8-664963db48e4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=66c65d8a-9158-4521-a2d8-664963db48e4;Ip=[160.33.194.231];Helo=[usculsndmail04v.am.sony.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR13MB1407 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org (resubmit as plain text)=0A= =0A= Hi Souhrid, =0A= =0A= Let me try to help with the issue. The issue you are seeing is actually not= due to the patch, but due to bugs in the Android Bluetooth stack assuming = you compiled hid-sony into the kernel.=0A= =0A= The stack in Android 9 lacked support for hid get and set report. The hid-S= ony driver needs these features. Without these features probe fails.=0A= =0A= We have added these features to Android and are in Android aosp. You could = merge those changes. You need some other changes too for power management i= n Android. =0A= =0A= Reverting this patch is not the right option. Honestly without this patch, = the new ds4 falls back to generic hid. However ds4 is practically unusable = then. Without hid-Sony in Bluetooth mode, input latency is variable up to 5= 00ms. It is so bad it is not usable in my opinion. The problem is that the = device is not properly in initialized and moves to a different mode in his-= Sony.=0A= =0A= All our improvements will be in the next major Android version Q. I suspect= the current Q build for e.g. Pixel phones has the changes merged. =0A= =0A= Thanks, =0A= Roderick =0A= ________________________________________=0A= From: Souhrid Nandi [snkm1999@gmail.com]=0A= Sent: Saturday, March 23, 2019 7:44 AM=0A= To: stable@vger.kernel.org=0A= Cc: Colenbrander, Roderick; benjamin.tissoires@redhat.com; jkosina@suse.cz= =0A= Subject: "HID: sony: Update device ids" Patch breaks bluetooth connectivity= on 4.4.x=0A= =0A= Commit in question: https://lkml.org/lkml/2018/9/27/647=0A= Device tested on: OnePlus 5=0A= Android Version: 9, Pie=0A= Kernel Version: 4.4.177 (Personal Kernel)=0A= =0A= This patch seems to break Bluetooth connectivity for DualShock 4=0A= controllers on 4.4. Reverting it fixes the issue, reported and=0A= confirmed by one of my users.=0A= I've confirmed that this happens on other devices of the same kernel=0A= version (4.4.y) - Redmi Note 5 Pro and other OnePlus 5/5T's for=0A= kernels that have this commit.=0A=