From: Jiri Slaby <jirislaby@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: Kangjie Lu <kjlu@umn.edu>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 119/190] Revert "tty: mxs-auart: fix a potential NULL pointer dereference"
Date: Thu, 22 Apr 2021 07:03:55 +0200 [thread overview]
Message-ID: <1af822a8-2a1b-9110-9832-ba0fe237a1c1@kernel.org> (raw)
In-Reply-To: <20210421130105.1226686-120-gregkh@linuxfoundation.org>
On 21. 04. 21, 14:59, Greg Kroah-Hartman wrote:
> This reverts commit 6734330654dac550f12e932996b868c6d0dcb421.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes. The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix. Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Kangjie Lu <kjlu@umn.edu>
> Cc: stable <stable@vger.kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/tty/serial/mxs-auart.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index f414d6acad69..edad6ebbdfd5 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -1644,10 +1644,6 @@ static int mxs_auart_probe(struct platform_device *pdev)
>
> s->port.mapbase = r->start;
> s->port.membase = ioremap(r->start, resource_size(r));
> - if (!s->port.membase) {
> - ret = -ENOMEM;
> - goto out_disable_clks;
> - }
I don't think this needs to be reverted -- the original fix is correct.
> s->port.ops = &mxs_auart_ops;
> s->port.iotype = UPIO_MEM;
> s->port.fifosize = MXS_AUART_FIFO_SIZE;
>
--
js
suse labs
next prev parent reply other threads:[~2021-04-22 5:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210421130105.1226686-1-gregkh@linuxfoundation.org>
2021-04-21 12:58 ` [PATCH 040/190] Revert "ACPI: CPPC: Fix reference count leak in acpi_cppc_processor_probe()" Greg Kroah-Hartman
2021-04-21 17:54 ` Rafael J. Wysocki
2021-04-27 14:50 ` Greg Kroah-Hartman
2021-04-21 12:58 ` [PATCH 041/190] Revert "ACPI: sysfs: Fix reference count leak in acpi_sysfs_add_hotplug_profile()" Greg Kroah-Hartman
2021-04-21 17:54 ` Rafael J. Wysocki
2021-04-27 14:50 ` Greg Kroah-Hartman
2021-04-21 12:59 ` [PATCH 081/190] Revert "tracing: Fix a memory leak by early error exit in trace_pid_write()" Greg Kroah-Hartman
2021-04-21 13:29 ` Steven Rostedt
2021-04-21 13:33 ` Steven Rostedt
2021-04-21 13:51 ` Greg Kroah-Hartman
2021-04-27 12:00 ` Greg Kroah-Hartman
2021-04-21 12:59 ` [PATCH 119/190] Revert "tty: mxs-auart: fix a potential NULL pointer dereference" Greg Kroah-Hartman
2021-04-22 5:03 ` Jiri Slaby [this message]
2021-04-26 17:03 ` Greg Kroah-Hartman
2021-04-21 12:59 ` [PATCH 120/190] Revert "tty: atmel_serial: " Greg Kroah-Hartman
2021-04-22 5:18 ` Jiri Slaby
2021-04-22 6:47 ` Richard Genoud
2021-04-26 17:04 ` Greg Kroah-Hartman
2021-04-21 12:59 ` [PATCH 121/190] Revert "serial: mvebu-uart: Fix to avoid " Greg Kroah-Hartman
2021-04-22 5:25 ` Jiri Slaby
2021-04-21 13:00 ` [PATCH 134/190] Revert "md: Fix failed allocation of md_register_thread" Greg Kroah-Hartman
2021-04-28 5:46 ` Greg Kroah-Hartman
2021-04-30 6:10 ` Song Liu
2021-04-30 6:34 ` Greg Kroah-Hartman
2021-04-21 13:00 ` [PATCH 181/190] Revert "dm ioctl: harden copy_params()'s copy_from_user() from malicious users" Greg Kroah-Hartman
2021-04-27 16:58 ` Greg Kroah-Hartman
2021-04-21 13:01 ` [PATCH 187/190] Revert "ALSA: control: fix a redundant-copy issue" Greg Kroah-Hartman
2021-04-21 16:30 ` Takashi Iwai
2021-04-27 13:57 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1af822a8-2a1b-9110-9832-ba0fe237a1c1@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).