From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-by2nam03on0135.outbound.protection.outlook.com ([104.47.42.135]:16544 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756238AbeDIAbT (ORCPT ); Sun, 8 Apr 2018 20:31:19 -0400 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Dan Carpenter , Kalle Valo , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 165/293] libertas: Fix lbs_prb_rsp_limit_set() Date: Mon, 9 Apr 2018 00:25:03 +0000 Message-ID: <20180409002239.163177-165-alexander.levin@microsoft.com> References: <20180409002239.163177-1-alexander.levin@microsoft.com> In-Reply-To: <20180409002239.163177-1-alexander.levin@microsoft.com> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: From: Dan Carpenter [ Upstream commit 69551f5f370cc20342fab17ca54716b6ec7e332d ] The kstrtoul() test was reversed so this always returned -ENOTSUPP. Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul= ()") Signed-off-by: Dan Carpenter Reviewed-by: James Cameron Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/libertas/mesh.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wir= eless/marvell/libertas/mesh.c index d0c881dd5846..a78c4d18fe4b 100644 --- a/drivers/net/wireless/marvell/libertas/mesh.c +++ b/drivers/net/wireless/marvell/libertas/mesh.c @@ -239,8 +239,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev= , memset(&mesh_access, 0, sizeof(mesh_access)); mesh_access.data[0] =3D cpu_to_le32(CMD_ACT_SET); =20 - if (!kstrtoul(buf, 10, &retry_limit)) - return -ENOTSUPP; + ret =3D kstrtoul(buf, 10, &retry_limit); + if (ret) + return ret; if (retry_limit > 15) return -ENOTSUPP; =20 --=20 2.15.1