From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:35356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726564AbeLMHgo (ORCPT ); Thu, 13 Dec 2018 02:36:44 -0500 Date: Thu, 13 Dec 2018 08:36:40 +0100 From: Greg Kroah-Hartman To: Thomas Zeitlhofer Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mathias Nyman , linux-usb@vger.kernel.org Subject: Re: [PATCH 4.19 014/110] usb: xhci: Prevent bus suspend if a port connect change or polling state is detected Message-ID: <20181213073640.GA31371@kroah.com> References: <20181129135921.231283053@linuxfoundation.org> <20181129135921.817957465@linuxfoundation.org> <20181212225334.GA2651@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181212225334.GA2651@x1> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Dec 12, 2018 at 11:53:34PM +0100, Thomas Zeitlhofer wrote: > Hello, > > On Thu, Nov 29, 2018 at 03:11:45PM +0100, Greg Kroah-Hartman wrote: > > 4.19-stable review patch. If anyone has any objections, please let me > > know. > > > > ------------------ > > > > From: Mathias Nyman > > > > commit 2f31a67f01a8beb22cae754c53522cb61a005750 upstream. > [...] > > on a current Thinkpad X1 Yoga, this breaks resume from hibernate such > that opening the lid has (in the regular use case, see below) no effect > any more: > > The system is configured to hibernate when the lid is closed. So, the > expected behavior, which is restored by reverting this patch, is: > > close lid => system hibernates > open lid => system resumes > > With this patch, the following two cases are observed: > > 1) > close lid => system hibernates > open lid => system stays off > press power button => system boots and resumes > > 2) > # systemctl hibernate => system hibernates > close lid > open lid => system resumes > So this is a problem in Linus's tree? If so, let's work to get this fixed there first. If not, then we have other issues :) thanks, greg k-h