From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 072A5C43387 for ; Fri, 11 Jan 2019 14:16:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C228921783 for ; Fri, 11 Jan 2019 14:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216167; bh=1lRnoQcT6JvBEScvKhR1ZbjtxTTOweW+zH8rn45s4AA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=h6ztSy4x/vaY223btdJkN6cetkwmYQx3PSeQxWajdCRVCkDfriUN5DBgfVW4sJU4d N3Q3jlgxI2N0EswEtN212mJ2dqRp9lrLB14pH1mxJm7rZMd2B+QlvCO4gvVp98VfHy qFY5G4ltHux1XJ68CRFwHkcmmgzOFg3TglGtz5ns= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387553AbfAKOQH (ORCPT ); Fri, 11 Jan 2019 09:16:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:60414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387550AbfAKOQG (ORCPT ); Fri, 11 Jan 2019 09:16:06 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 161B42177B; Fri, 11 Jan 2019 14:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216165; bh=1lRnoQcT6JvBEScvKhR1ZbjtxTTOweW+zH8rn45s4AA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AXSh0S9+7iGaxbkqWLWq/P/9hp9WwJaL+bzbMrL/kYt/XwHd+C/c1qiPWtBbDAHkb CXMAbF8BY1tcrDzgmx9b9eA3iEk3cFzXzalnuuVMnepabE8CZuKZFcMFu3BQhWTqpS VyOuGXUBgdKewwOtzGrc2McqLMLDpuWDKeGOwkvU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Yan, Zheng" , Ilya Dryomov Subject: [PATCH 3.18 45/47] ceph: dont update importing caps mseq when handing cap export Date: Fri, 11 Jan 2019 15:08:30 +0100 Message-Id: <20190111131001.960851612@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111130956.170952125@linuxfoundation.org> References: <20190111130956.170952125@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yan, Zheng commit 3c1392d4c49962a31874af14ae9ff289cb2b3851 upstream. Updating mseq makes client think importer mds has accepted all prior cap messages and importer mds knows what caps client wants. Actually some cap messages may have been dropped because of mseq mismatch. If mseq is left untouched, importing cap's mds_wanted later will get reset by cap import message. Cc: stable@vger.kernel.org Signed-off-by: "Yan, Zheng" Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/caps.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -2830,7 +2830,6 @@ retry: tcap->cap_id = t_cap_id; tcap->seq = t_seq - 1; tcap->issue_seq = t_seq - 1; - tcap->mseq = t_mseq; tcap->issued |= issued; tcap->implemented |= issued; if (cap == ci->i_auth_cap)