From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D40C43387 for ; Fri, 11 Jan 2019 14:45:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77836206B6 for ; Fri, 11 Jan 2019 14:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547217905; bh=uNoZ03c9MBSJ4r+9LOqND5E71pDBH8Uh77c89KOOixc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=B7c34YEuaQ0If33MgnaPpImEwZUoNamACjt5E9SMvrNPhnRLULGb0dIlVtFH1sqG/ f3TZfc5dZrcAszHmWgaTVdfHrA/c6r/97xZXE8RQy5rBWidiCoFKl/HkxfoqDLzFUU tBtHNOmQXN136xcB5Bnsfp7RgOb4QkVyaYa6KP9w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390989AbfAKOpE (ORCPT ); Fri, 11 Jan 2019 09:45:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:37284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404589AbfAKOoU (ORCPT ); Fri, 11 Jan 2019 09:44:20 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0C610206B6; Fri, 11 Jan 2019 14:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547217859; bh=uNoZ03c9MBSJ4r+9LOqND5E71pDBH8Uh77c89KOOixc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NgY0o7Q+0dSFfHCSvm7TVi1MAj3vl45ieS3nDDAQkI9qllBLXQiyR4WbO7Y9W2vt5 NANqW6IOcLeq779a30yjJ3L+lWGBIInDqQZh9Z5NZunQhBRU00gC41x5rAsfJBdRhu yn9IM70G0Atqtn5n3bHKledGZFoPiQsDqgYRkSjU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Priit Laes , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Larry Finger , Kalle Valo Subject: [PATCH 4.20 35/65] b43: Fix error in cordic routine Date: Fri, 11 Jan 2019 15:15:21 +0100 Message-Id: <20190111131101.191291619@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111131055.331350141@linuxfoundation.org> References: <20190111131055.331350141@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Larry Finger commit 8ea3819c0bbef57a51d8abe579e211033e861677 upstream. The cordic routine for calculating sines and cosines that was added in commit 6f98e62a9f1b ("b43: update cordic code to match current specs") contains an error whereby a quantity declared u32 can in fact go negative. This problem was detected by Priit Laes who is switching b43 to use the routine in the library functions of the kernel. Fixes: 986504540306 ("b43: make cordic common (LP-PHY and N-PHY need it)") Reported-by: Priit Laes Cc: Rafał Miłecki Cc: Stable # 2.6.34 Signed-off-by: Larry Finger Signed-off-by: Priit Laes Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/broadcom/b43/phy_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/broadcom/b43/phy_common.c +++ b/drivers/net/wireless/broadcom/b43/phy_common.c @@ -616,7 +616,7 @@ struct b43_c32 b43_cordic(int theta) u8 i; s32 tmp; s8 signx = 1; - u32 angle = 0; + s32 angle = 0; struct b43_c32 ret = { .i = 39797, .q = 0, }; while (theta > (180 << 16))