From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A252CC61CE8 for ; Sat, 19 Jan 2019 13:34:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DC4D2086A for ; Sat, 19 Jan 2019 13:34:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="C9zcyBL8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728024AbfASNeQ (ORCPT ); Sat, 19 Jan 2019 08:34:16 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:46244 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728006AbfASNeP (ORCPT ); Sat, 19 Jan 2019 08:34:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cvEHaUKaFzK8kQEwuJ2yNy3fWVBqJqkK8GsrgFgp/hs=; b=C9zcyBL8GuiK7s5rGf8SVURtWu T7IylM4JSbAKb+Nl3w9ak2r1WDXWJcG/6sYLk4A7GTypZqIFZzBLPl5blnbPzkJCS50asQXDJVX+F h3agsBE5ydF9B52QJSZatpYHPwPyZe4pkRQMd2A/56f5cJ1Eohqy/DcixXBqiu4xtAg8Yu1XtFYzc I3f9NvY86XCgRZdyZb2/3bMHf7SAViydBrwHalD1unmpZybzbReiWIoEC7aGYU9rM8REp2LKVk7t3 y+FUjwuA9rBZOy4RnxuwkvaPRRcFo5SnaRBN4zCGytMIaxivZreONAwj6bCLxKySYlqECVfGn/7i5 PPhqR92Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkqlH-0001vK-2s; Sat, 19 Jan 2019 13:34:11 +0000 Date: Sat, 19 Jan 2019 05:34:10 -0800 From: Christoph Hellwig To: Raju Rangoju Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org, maxg@mellanox.com, swise@opengridcomputing.com, stable@vger.kernel.org Subject: Re: [PATCH v3] nvmet-rdma: fix null dereference under heavy load Message-ID: <20190119133410.GA6963@infradead.org> References: <20190103173531.7987-1-rajur@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190103173531.7987-1-rajur@chelsio.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This looks ok to me: Reviewed-by: Christoph Hellwig In the long run I wonder if we should get rid of the Ρ•tatic preallocation entirely and just use a free pool to avoid constant reallocations..