From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DB1C37120 for ; Mon, 21 Jan 2019 21:05:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6801021019 for ; Mon, 21 Jan 2019 21:05:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="WuU7nt4R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727224AbfAUVFQ (ORCPT ); Mon, 21 Jan 2019 16:05:16 -0500 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]:41457 "EHLO smtp-fw-2101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbfAUVFP (ORCPT ); Mon, 21 Jan 2019 16:05:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1548104715; x=1579640715; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YJi2/xO+5OaKgxlQXWzp7mZmcf/0biFa4FAU618uvw0=; b=WuU7nt4RsF1qVZtaowq56uTLpKXOc3l8pjDQgaEt+OIgqTzKwwhefsNG mgWY9WjF3CYKT9y0+XBlnyFeJkrSFcfdW9is7aVALEs7gH5JyJgDXkYXz qAJm79kvJbgTPaQ6nvVkUG0ECDjekRPtkxPVPnhAzkqBkEkRp6WoiFO4s 8=; X-IronPort-AV: E=Sophos;i="5.56,253,1539648000"; d="scan'208";a="714035333" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-baacba05.us-west-2.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 21 Jan 2019 21:05:14 +0000 Received: from EX13MTAUWC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2b-baacba05.us-west-2.amazon.com (Postfix) with ESMTPS id ECFFBA2310; Mon, 21 Jan 2019 21:05:13 +0000 (UTC) Received: from EX13D17UWC003.ant.amazon.com (10.43.162.206) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 21 Jan 2019 21:05:13 +0000 Received: from dev-dsk-alakeshh-2c-f8a3e6e0.us-west-2.amazon.com (10.43.160.245) by EX13D17UWC003.ant.amazon.com (10.43.162.206) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 21 Jan 2019 21:05:13 +0000 Date: Mon, 21 Jan 2019 21:05:12 +0000 From: Alakesh Haloi To: Greg KH CC: , Steve French Subject: Re: Request for inclusion into linux-4.14.y Message-ID: <20190121210512.GB72263@dev-dsk-alakeshh-2c-f8a3e6e0.us-west-2.amazon.com> References: <20190121193530.GA72263@dev-dsk-alakeshh-2c-f8a3e6e0.us-west-2.amazon.com> <20190121194448.GA6783@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190121194448.GA6783@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.43.160.245] X-ClientProxiedBy: EX13D05UWB003.ant.amazon.com (10.43.161.26) To EX13D17UWC003.ant.amazon.com (10.43.162.206) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 21, 2019 at 08:44:48PM +0100, Greg KH wrote: > On Mon, Jan 21, 2019 at 07:35:43PM +0000, Alakesh Haloi wrote: > > Hello Greg, > > Can you please consider including the following patch in the stable > > linux-4.14.y branch? This is to fix a broken dependency for config option > > CONFIG_CIFS_POSIX > > > > 04f67ed3d83a ("cifs: allow disabling insecure dialects in the config") > > I do not see that commit in Linus's tree, are you sure the sha1 is > correct? > Apologies for pasting a wrong sha1 for the commit. Following is the commit from linus's tree that needs to be included to fix the dependency: 7420451f6a10 ("cifs: allow disabling insecure dialects in the config") > > Following commit introduced a dependency for CONFIG_CIFS_POSIX on the config > > CONFIG_CIFS_ALLOW_INSECURE_LEGACY, but the above mentioned commit that had > > enable CONFIG_CIFS_POSIX in 4.14.94. > > > > ab9697222a1d ("cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy > > (insecure cifs)") > > Was the above patch incorrectly applied? Should it just be dropped > instead? This patch that is already there in 4.14.y looks correct but it does have missing dependency on the patch that is requested to be included. The other option is to drop this patch. But I would prefer to keep the patch and have the dependency resolved. > > thanks, > > greg k-h