* [PATCH 2/5] drm/i915: always return something
[not found] <20190117202113.5190-1-lucas.demarchi@intel.com>
@ 2019-01-17 20:21 ` Lucas De Marchi
2019-01-22 12:01 ` [Intel-gfx] " Kahola, Mika
2019-01-23 14:19 ` Joonas Lahtinen
0 siblings, 2 replies; 4+ messages in thread
From: Lucas De Marchi @ 2019-01-17 20:21 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Paulo Zanoni, stable
Even if we don't have the correct clock and get a warning, we should not
skip the return.
Fixes: 1fa11ee2d9d0 ("drm/i915/icl: start adding the TBT pll")
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: <stable@vger.kernel.org> # v4.19+
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 8dbf6c9e22fb..4dc03e8c6c10 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1021,7 +1021,7 @@ static uint32_t icl_pll_to_ddi_pll_sel(struct intel_encoder *encoder,
return DDI_CLK_SEL_TBT_810;
default:
MISSING_CASE(clock);
- break;
+ return DDI_CLK_SEL_NONE;
}
case DPLL_ID_ICL_MGPLL1:
case DPLL_ID_ICL_MGPLL2:
--
2.20.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH 2/5] drm/i915: always return something
2019-01-17 20:21 ` [PATCH 2/5] drm/i915: always return something Lucas De Marchi
@ 2019-01-22 12:01 ` Kahola, Mika
2019-01-23 14:19 ` Joonas Lahtinen
1 sibling, 0 replies; 4+ messages in thread
From: Kahola, Mika @ 2019-01-22 12:01 UTC (permalink / raw)
To: intel-gfx, De Marchi, Lucas; +Cc: stable, Zanoni, Paulo R
Patch look ok to me.
On Thu, 2019-01-17 at 12:21 -0800, Lucas De Marchi wrote:
> Even if we don't have the correct clock and get a warning, we should
> not
> skip the return.
>
> Fixes: 1fa11ee2d9d0 ("drm/i915/icl: start adding the TBT pll")
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: <stable@vger.kernel.org> # v4.19+
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index 8dbf6c9e22fb..4dc03e8c6c10 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1021,7 +1021,7 @@ static uint32_t icl_pll_to_ddi_pll_sel(struct
> intel_encoder *encoder,
> return DDI_CLK_SEL_TBT_810;
> default:
> MISSING_CASE(clock);
> - break;
> + return DDI_CLK_SEL_NONE;
> }
> case DPLL_ID_ICL_MGPLL1:
> case DPLL_ID_ICL_MGPLL2:
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH 2/5] drm/i915: always return something
2019-01-17 20:21 ` [PATCH 2/5] drm/i915: always return something Lucas De Marchi
2019-01-22 12:01 ` [Intel-gfx] " Kahola, Mika
@ 2019-01-23 14:19 ` Joonas Lahtinen
2019-01-23 18:01 ` Lucas De Marchi
1 sibling, 1 reply; 4+ messages in thread
From: Joonas Lahtinen @ 2019-01-23 14:19 UTC (permalink / raw)
To: Lucas De Marchi, intel-gfx; +Cc: Lucas De Marchi, Paulo Zanoni, stable
The subject of this patch could really be bit more specific "... on DDI clock
selection".
Regards, Joonas
Quoting Lucas De Marchi (2019-01-17 22:21:10)
> Even if we don't have the correct clock and get a warning, we should not
> skip the return.
>
> Fixes: 1fa11ee2d9d0 ("drm/i915/icl: start adding the TBT pll")
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: <stable@vger.kernel.org> # v4.19+
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 8dbf6c9e22fb..4dc03e8c6c10 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1021,7 +1021,7 @@ static uint32_t icl_pll_to_ddi_pll_sel(struct intel_encoder *encoder,
> return DDI_CLK_SEL_TBT_810;
> default:
> MISSING_CASE(clock);
> - break;
> + return DDI_CLK_SEL_NONE;
> }
> case DPLL_ID_ICL_MGPLL1:
> case DPLL_ID_ICL_MGPLL2:
> --
> 2.20.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH 2/5] drm/i915: always return something
2019-01-23 14:19 ` Joonas Lahtinen
@ 2019-01-23 18:01 ` Lucas De Marchi
0 siblings, 0 replies; 4+ messages in thread
From: Lucas De Marchi @ 2019-01-23 18:01 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx, Paulo Zanoni, stable
On Wed, Jan 23, 2019 at 04:19:30PM +0200, Joonas Lahtinen wrote:
>The subject of this patch could really be bit more specific "... on DDI clock
>selection".
Fixed. I'll wait for reviews on other patches to re-spin this series as
it's already conflicting.
thanks
Lucas De Marchi
>
>Regards, Joonas
>
>Quoting Lucas De Marchi (2019-01-17 22:21:10)
>> Even if we don't have the correct clock and get a warning, we should not
>> skip the return.
>>
>> Fixes: 1fa11ee2d9d0 ("drm/i915/icl: start adding the TBT pll")
>> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> Cc: <stable@vger.kernel.org> # v4.19+
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
>> index 8dbf6c9e22fb..4dc03e8c6c10 100644
>> --- a/drivers/gpu/drm/i915/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/intel_ddi.c
>> @@ -1021,7 +1021,7 @@ static uint32_t icl_pll_to_ddi_pll_sel(struct intel_encoder *encoder,
>> return DDI_CLK_SEL_TBT_810;
>> default:
>> MISSING_CASE(clock);
>> - break;
>> + return DDI_CLK_SEL_NONE;
>> }
>> case DPLL_ID_ICL_MGPLL1:
>> case DPLL_ID_ICL_MGPLL2:
>> --
>> 2.20.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-23 18:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190117202113.5190-1-lucas.demarchi@intel.com>
2019-01-17 20:21 ` [PATCH 2/5] drm/i915: always return something Lucas De Marchi
2019-01-22 12:01 ` [Intel-gfx] " Kahola, Mika
2019-01-23 14:19 ` Joonas Lahtinen
2019-01-23 18:01 ` Lucas De Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).