From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3DBAC282C3 for ; Thu, 24 Jan 2019 18:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68583218CD for ; Thu, 24 Jan 2019 18:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548352961; bh=28NXGokAKyb+muwZOJTIUPItE3L4dloHnLPQS9jfxEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=coXHntf3Af0UUptUyMMurA3ZaXatctc57VoJ22HyamLATlRmi27XO3GxKBBRcHN8J Sa5awS7hxbzIepztvBe/869g7jFzsfXG4dI3Yo5l7/SQNO9azTKA8yilYVFdkr8ySQ Ger8Dl4WkvDsbnwKmDEvJb/IYbgeMc9DcjRet3H4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728895AbfAXSCl (ORCPT ); Thu, 24 Jan 2019 13:02:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:39358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728300AbfAXSCk (ORCPT ); Thu, 24 Jan 2019 13:02:40 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D0BA2184C; Thu, 24 Jan 2019 18:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548352960; bh=28NXGokAKyb+muwZOJTIUPItE3L4dloHnLPQS9jfxEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=beAk9N7QkXQxKkGJZlNn34tCper2ki0iY62wd5DvgfWwayK/dodmzNV+PD9wwUn9f +ul+QTpKk/AuO5OR7k1PgDTR/8k6CQ8EJOH/GyvKUpMnej14uiOAXZsf9NT974iy4W td//UW1hS6BOxcmPPyb5Gx1nGIj9EpYqai8vLmu4= Date: Thu, 24 Jan 2019 19:02:37 +0100 From: Greg KH To: Alakesh Haloi Cc: stable@vger.kernel.org, Steve French Subject: Re: Request for inclusion into linux-4.14.y Message-ID: <20190124180237.GE7484@kroah.com> References: <20190121193530.GA72263@dev-dsk-alakeshh-2c-f8a3e6e0.us-west-2.amazon.com> <20190121194448.GA6783@kroah.com> <20190121210512.GB72263@dev-dsk-alakeshh-2c-f8a3e6e0.us-west-2.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190121210512.GB72263@dev-dsk-alakeshh-2c-f8a3e6e0.us-west-2.amazon.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 21, 2019 at 09:05:12PM +0000, Alakesh Haloi wrote: > On Mon, Jan 21, 2019 at 08:44:48PM +0100, Greg KH wrote: > > On Mon, Jan 21, 2019 at 07:35:43PM +0000, Alakesh Haloi wrote: > > > Hello Greg, > > > Can you please consider including the following patch in the stable > > > linux-4.14.y branch? This is to fix a broken dependency for config option > > > CONFIG_CIFS_POSIX > > > > > > 04f67ed3d83a ("cifs: allow disabling insecure dialects in the config") > > > > I do not see that commit in Linus's tree, are you sure the sha1 is > > correct? > > > Apologies for pasting a wrong sha1 for the commit. Following is the commit from > linus's tree that needs to be included to fix the dependency: > > 7420451f6a10 ("cifs: allow disabling insecure dialects in the config") > > > > Following commit introduced a dependency for CONFIG_CIFS_POSIX on the config > > > CONFIG_CIFS_ALLOW_INSECURE_LEGACY, but the above mentioned commit that had > > > enable CONFIG_CIFS_POSIX in 4.14.94. > > > > > > ab9697222a1d ("cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy > > > (insecure cifs)") > > > > Was the above patch incorrectly applied? Should it just be dropped > > instead? > This patch that is already there in 4.14.y looks correct but it does > have missing dependency on the patch that is requested to be included. > The other option is to drop this patch. But I would prefer to keep the > patch and have the dependency resolved. Ok, now queued up, thanks. greg k-h